Skip to contentSkip to conversation

Revert "mtd: spi-nor: Prefer asynchronous probe"

PATCH Applied Vignesh Raghavendra 2 participants 3 messages Oct 5, 2020 – Oct 6, 2020

Subsystems (2)
lore
Share & tools
lore

Vignesh Raghavendra

author maintainer
#0 lore raw

PATCH 1/1 Revert "mtd: spi-nor: Prefer asynchronous probe"

This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.

This leads to warn dump like [1] on some platforms and reorders MTD devices thus may break user space expectations. So revert the change.

[1]:

[    1.849801] ------------[ cut here ]------------
[    1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
[    1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568

[...]

---
 drivers/mtd/spi-nor/core.c | 1 -
 1 file changed, 1 deletion(-)
drivers/mtd/spi-nor/core.c +0 -1
index 2add4a01fce2..0369d98b2d12 100644
@@ -3451,7 +3451,6 @@ static struct spi_mem_driver spi_nor_driver = {
 		.driver = {
 			.name = "spi-nor",
 			.of_match_table = spi_nor_of_table,
-			.probe_type = PROBE_PREFER_ASYNCHRONOUS,
 		},
 		.id_table = spi_nor_dev_ids,
 	},
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 12 lines · Vignesh Raghavendra

This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.

This leads to warn dump like [1] on some platforms and reorders MTD devices thus may break user space expectations. So revert the change.

[1]:

[    1.849801] ------------[ cut here ]------------
[    1.854271] mscc_felix 0000:00:00.5: device is disabled, skipping
[    1.858753] WARNING: CPU: 1 PID: 7 at kernel/kmod.c:136 __request_module+0x3a4/0x568
Quoted 7 lines

[...]

---
 drivers/mtd/spi-nor/core.c | 1 -
 1 file changed, 1 deletion(-)

Thank you for the revert and sorry for the breakage.

author maintainer Applied
#2 lore raw
In reply to Vignesh Raghavendra
Quoted 8 lines · Vignesh Raghavendra

This reverts commit 03edda0e1edaa3c2e99239c66e3c14d749318fd6.

This leads to warn dump like [1] on some platforms and reorders MTD devices thus may break user space expectations. So revert the change.

[1]:

[...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next, thanks! [1/1] Revert "mtd: spi-nor: Prefer asynchronous probe"

      https://git.kernel.org/mtd/c/9a3422a110

--
Regards
Vignesh