kernel: remove igb_uio
PATCH 1/1 kernel: remove igb_uio
As decided in the Technical Board in November 2019, the kernel module igb_uio is moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.html
--- MAINTAINERS | 1 - doc/guides/rel_notes/deprecation.rst | 7 - kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ------- kernel/linux/igb_uio/igb_uio.c | 660 --------------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 7 files changed, 1 insertion(+), 845 deletions(-) delete mode 100644 kernel/linux/igb_uio/Kbuild delete mode 100644 kernel/linux/igb_uio/compat.h delete mode 100644 kernel/linux/igb_uio/igb_uio.c delete mode 100644 kernel/linux/igb_uio/meson.build
MAINTAINERS +0 -1
@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/ Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio* Linux VFIO
doc/guides/rel_notes/deprecation.rst +0 -7
@@ -96,13 +96,6 @@ Deprecation Notices used in the place of rte_cio_*mb APIs. The rte_cio_*mb APIs will be deprecated in 20.11 release. -* igb_uio: In the view of reducing the kernel dependency from the main tree, - as a first step, the Technical Board decided to move ``igb_uio`` - kernel module to the dpdk-kmods repository in the /linux/igb_uio/ directory - in 20.11. - Minutes of Technical Board Meeting of `2019-11-06 - <https://mails.dpdk.org/archives/dev/2019-November/151763.html>`_. - * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is used by iterators, and arrays holding these values are sized with this
kernel/linux/igb_uio/Kbuild deleted +0 -0
kernel/linux/igb_uio/compat.h deleted +0 -0
kernel/linux/igb_uio/igb_uio.c deleted +0 -0
kernel/linux/igb_uio/meson.build deleted +0 -0
kernel/linux/meson.build +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -subdirs = ['igb_uio', 'kni'] +subdirs = ['kni'] # if we are cross-compiling we need kernel_dir specified if get_option('kernel_dir') == '' and meson.is_cross_build()
Signature · 1 line
2.28.0
Quoted 3 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
The code is moved with its git history in
http://git.dpdk.org/dpdk-kmods/
The move process started with these commands:
cd dpdk
dir=igb_uio
path1=lib/librte_eal/linuxapp/$dir
path2=kernel/linux/$dir
git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2
find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \;
cd ../dpdk-kmods
git am ../dpdk/$dir/*
git filter-branch --force
--index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile"
--prune-empty --tag-name-filter cat -- --allMakefile and meson.build files were not imported at all. Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), because they were not very useful and reverted later in the history. Anyway the original history is available forever in dpdk.git.
Currently it cannot compile because the file rte_pci_dev_feature_defs.h is missing, defining enum rte_intr_mode. An option is to import this file.
It would be nice to add a README file in the new igb_uio directory. Volunteers welcome :)
Quoted 26 lines · Thomas Monjalon
Quoted 3 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.The code is moved with its git history in
http://git.dpdk.org/dpdk-kmods/The move process started with these commands:
cd dpdk dir=igb_uio path1=lib/librte_eal/linuxapp/$dir path2=kernel/linux/$dir git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2 find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \; cd ../dpdk-kmods git am ../dpdk/$dir/* git filter-branch --force --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile" --prune-empty --tag-name-filter cat -- --all
Makefileand meson.build files were not imported at all. Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), because they were not very useful and reverted later in the history. Anyway the original history is available forever in dpdk.git.
Quoted 5 lines
Currently it cannot compile because the file
rte_pci_dev_feature_defs.his missing, defining enumrte_intr_mode. An option is to import this file.It would be nice to add a README file in the new
igb_uiodirectory. Volunteers welcome :)
In terms of building the module, one option which I think is worth considering is to try and use meson subject/wrap support to download and build this module as part of the main DPDK build, as now, when enable_kmods option is set. With a wrap file in DPDK it can automatically pull down and build the code as part of a main project build. I assume that integration into main DPDK build is still something worth having? The only thing I don't like about using a wrap file is that it has to be placed in a folder called "subproject" at the top level of the DPDK project.
Thoughts,
/Bruce
08/09/2020 10:25, Bruce Richardson:
Quoted 33 lines · Thomas Monjalon
Quoted 26 lines · Thomas Monjalon
Quoted 3 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.The code is moved with its git history in
http://git.dpdk.org/dpdk-kmods/The move process started with these commands:
cd dpdk dir=igb_uio path1=lib/librte_eal/linuxapp/$dir path2=kernel/linux/$dir git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2 find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \; cd ../dpdk-kmods git am ../dpdk/$dir/* git filter-branch --force --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile" --prune-empty --tag-name-filter cat -- --all
Makefileand meson.build files were not imported at all. Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), because they were not very useful and reverted later in the history. Anyway the original history is available forever in dpdk.git.Quoted 5 lines
Currently it cannot compile because the file
rte_pci_dev_feature_defs.his missing, defining enumrte_intr_mode. An option is to import this file.It would be nice to add a README file in the new
igb_uiodirectory. Volunteers welcome :)
Quoted 8 lines
In terms of building the module, one option which I think is worth considering is to try and use meson subject/wrap support to download and build this module as part of the main DPDK build, as now, when
enable_kmodsoption is set. With a wrap file in DPDK it can automatically pull down and build the code as part of a main project build. I assume that integration into main DPDK build is still something worth having? The only thing I don't like about using a wrap file is that it has to be placed in a folder called "subproject" at the top level of the DPDK project.
The idea is encouraging the use of VFIO and make igb_uio deprecated. I think we should not do any effort to ease igb_uio usage inside dpdk.git. Compiling the kernel module standalone in dpdk-kmods.git looks enough, isn't it?
Quoted 43 lines · Thomas Monjalon
08/09/2020 10:25, Bruce Richardson:
Quoted 33 lines · Thomas Monjalon
Quoted 26 lines · Thomas Monjalon
Quoted 3 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.The code is moved with its git history in
http://git.dpdk.org/dpdk-kmods/The move process started with these commands:
cd dpdk dir=igb_uio path1=lib/librte_eal/linuxapp/$dir path2=kernel/linux/$dir git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2 find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \; cd ../dpdk-kmods git am ../dpdk/$dir/* git filter-branch --force --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile" --prune-empty --tag-name-filter cat -- --all
Makefileand meson.build files were not imported at all. Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), because they were not very useful and reverted later in the history. Anyway the original history is available forever in dpdk.git.Quoted 5 lines
Currently it cannot compile because the file
rte_pci_dev_feature_defs.his missing, defining enumrte_intr_mode. An option is to import this file.It would be nice to add a README file in the new
igb_uiodirectory. Volunteers welcome :)Quoted 8 lines
In terms of building the module, one option which I think is worth considering is to try and use meson subject/wrap support to download and build this module as part of the main DPDK build, as now, when
enable_kmodsoption is set. With a wrap file in DPDK it can automatically pull down and build the code as part of a main project build. I assume that integration into main DPDK build is still something worth having? The only thing I don't like about using a wrap file is that it has to be placed in a folder called "subproject" at the top level of the DPDK project.
Quoted 4 lines
The idea is encouraging the use of VFIO and make
igb_uiodeprecated. I think we should not do any effort to easeigb_uiousage inside dpdk.git. Compiling the kernel module standalone in dpdk-kmods.git looks enough, isn't it?
Ok, that is fine if that is the objective. I thought the objective was to move all kernel modules out of the DPDK tree, but if it's only certain modules, then that is different.
/Bruce
08/09/2020 11:34, Bruce Richardson:
Quoted 44 lines · Thomas Monjalon
Quoted 43 lines
08/09/2020 10:25, Bruce Richardson:
Quoted 41 lines · Thomas Monjalon
Quoted 26 lines · Thomas Monjalon
Quoted 3 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.The code is moved with its git history in
http://git.dpdk.org/dpdk-kmods/The move process started with these commands:
cd dpdk dir=igb_uio path1=lib/librte_eal/linuxapp/$dir path2=kernel/linux/$dir git format-patch -o $dir 0c9a540ed2.. -- $path1 $path2 find $dir -type f -exec sed -i "s,$path1\|$path2,linux/$dir," '{}' \; cd ../dpdk-kmods git am ../dpdk/$dir/* git filter-branch --force --index-filter "git rm --cached --ignore-unmatch linux/$dir/Makefile" --prune-empty --tag-name-filter cat -- --all
Makefileand meson.build files were not imported at all. Some other commits were skipped (virtio, vmxnet3 and Xen dom0 support), because they were not very useful and reverted later in the history. Anyway the original history is available forever in dpdk.git.Quoted 5 lines
Currently it cannot compile because the file
rte_pci_dev_feature_defs.his missing, defining enumrte_intr_mode. An option is to import this file.It would be nice to add a README file in the new
igb_uiodirectory. Volunteers welcome :)In terms of building the module, one option which I think is worth considering is to try and use meson subject/wrap support to download and build this module as part of the main DPDK build, as now, when
enable_kmodsoption is set. With a wrap file in DPDK it can automatically pull down and build the code as part of a main project build. I assume that integration into main DPDK build is still something worth having? The only thing I don't like about using a wrap file is that it has to be placed in a folder called "subproject" at the top level of the DPDK project.
Quoted 7 lines
Quoted 3 lines
The idea is encouraging the use of VFIO and make
igb_uiodeprecated. I think we should not do any effort to easeigb_uiousage inside dpdk.git. Compiling the kernel module standalone in dpdk-kmods.git looks enough, isn't it?Ok, that is fine if that is the objective. I thought the objective was to move all kernel modules out of the DPDK tree, but if it's only certain modules, then that is different.
As we discussed in the Technical Board, the FreeBSD modules are required for any use and should stay inside dpdk.git.
But the question is open for KNI.
I think KNI should be deprecated as well to encourage using other methods which are more "upstream" for Linux.
Quoted 27 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>--- MAINTAINERS | 1 - doc/guides/rel_notes/deprecation.rst | 7 - kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ------- kernel/linux/igb_uio/igb_uio.c | 660 --------------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 7 files changed, 1 insertion(+), 845 deletions(-) delete mode 100644 kernel/linux/igb_uio/Kbuild delete mode 100644 kernel/linux/igb_uio/compat.h delete mode 100644 kernel/linux/igb_uio/igb_uio.c delete mode 100644 kernel/linux/igb_uio/meson.buildMAINTAINERS +0
-0
MAINTAINERS F: doc/guides/linux_gsg/ · line 296
Quoted 6 lines
MAINTAINERS +0
-1@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/ Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio*
What do you think to have the new git repo information here as "T: ..."
To help people looking for the module.
And I think at least 'doc/guides/linux_gsg/linux_drivers.rst' should be updated to document the new home of the kernel module, but there are multiple references in the documentation to the 'igb_uio', perhaps they should be replaced with 'vfio' too?
08/09/2020 14:06, Ferruh Yigit:
Quoted 29 lines · Thomas Monjalon
Quoted 28 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>--- MAINTAINERS | 1 - doc/guides/rel_notes/deprecation.rst | 7 - kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ------- kernel/linux/igb_uio/igb_uio.c | 660 --------------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 7 files changed, 1 insertion(+), 845 deletions(-) delete mode 100644 kernel/linux/igb_uio/Kbuild delete mode 100644 kernel/linux/igb_uio/compat.h delete mode 100644 kernel/linux/igb_uio/igb_uio.c delete mode 100644 kernel/linux/igb_uio/meson.buildMAINTAINERS +0
-0@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/
Quoted 9 lines
MAINTAINERS F: doc/guides/linux_gsg/ · line 296
Quoted 5 lines
MAINTAINERS +0
-1Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio*What do you think to have the new git repo information here as "T: ..."
To help people looking for the module.
I don't think we should reference the new home in the file MAINTAINERS of dpdk.git. But yes, it should be documented. I'll add something in v2.
Quoted 4 lines
And I think at least '
doc/guides/linux_gsg/linux_drivers.rst' should be updated to document the new home of the kernel module, but there are multiple references in the documentation to the 'igb_uio', perhaps they should be replaced with 'vfio' too?
As part of this patch, I will document the new home of igb_uio, but won't change the usage references.
I think moving to VFIO in docs is another patch, and probably multiple.
PATCH v2 1/1 kernel: remove igb_uio
In reply to Thomas MonjalonAs decided in the Technical Board in November 2019, the kernel module igb_uio is moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.html
---
v2: update few docs (including release notes)
--- MAINTAINERS | 1 - doc/guides/linux_gsg/enable_func.rst | 5 +- doc/guides/linux_gsg/linux_drivers.rst | 21 +- doc/guides/rel_notes/deprecation.rst | 7 - doc/guides/rel_notes/release_20_11.rst | 3 + kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ------ kernel/linux/igb_uio/igb_uio.c | 660 ------------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 10 files changed, 12 insertions(+), 863 deletions(-) delete mode 100644 kernel/linux/igb_uio/Kbuild delete mode 100644 kernel/linux/igb_uio/compat.h delete mode 100644 kernel/linux/igb_uio/igb_uio.c delete mode 100644 kernel/linux/igb_uio/meson.build
MAINTAINERS +0 -1
@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/ Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio* Linux VFIO
doc/guides/linux_gsg/enable_func.rst +3 -2
@@ -129,7 +129,7 @@ Loading the DPDK KNI Kernel Module To run the DPDK Kernel NIC Interface (KNI) sample application, an extra kernel module (the kni module) must be loaded into the running kernel. The module is found in the kmod sub-directory of the DPDK target directory. -Similar to the loading of the ``igb_uio`` module, this module should be loaded using the insmod command as shown below +This module should be loaded using the insmod command as shown below (assuming that the current directory is the DPDK target directory): .. code-block:: console
@@ -156,4 +156,5 @@ This results in pass-through of the DMAR (DMA Remapping) lookup in the host. Also, if ``INTEL_IOMMU_DEFAULT_ON`` is not set in the kernel, the ``intel_iommu=on`` kernel parameter must be used too. This ensures that the Intel IOMMU is being initialized as expected. -Please note that while using ``iommu=pt`` is compulsory for ``igb_uio driver``, the ``vfio-pci`` driver can actually work with both ``iommu=pt`` and ``iommu=on``. +Please note that while using ``iommu=pt`` is compulsory for ``igb_uio`` driver, +the ``vfio-pci`` driver can actually work with both ``iommu=pt`` and ``iommu=on``.
doc/guides/linux_gsg/linux_drivers.rst +5 -16
@@ -27,31 +27,20 @@ can provide the uio capability. This module can be loaded using the command: ``uio_pci_generic`` module doesn't support the creation of virtual functions. -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio -module which can be found in the kmod subdirectory referred to above. It can -be loaded as shown below: +As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module +which can be found in the repository ``dpdk-kmods``. +It can be loaded as shown below: .. code-block:: console sudo modprobe uio - sudo insmod kmod/igb_uio.ko - -.. note:: - - ``igb_uio`` module is disabled by default starting from ``DPDK v20.02``. - To build it, the config option ``CONFIG_RTE_EAL_IGB_UIO`` should be enabled. - It is planned to move ``igb_uio`` module to a different git repository. - -.. note:: - - For some devices which lack support for legacy interrupts, e.g. virtual function - (VF) devices, the ``igb_uio`` module may be needed in place of ``uio_pci_generic``. + sudo insmod igb_uio.ko .. note:: If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + ``vfio-pci`` kernel module rather than any UIO-based module. For more details see :ref:`linux_gsg_binding_kernel` below. .. note::
doc/guides/rel_notes/deprecation.rst +0 -7
@@ -96,13 +96,6 @@ Deprecation Notices used in the place of rte_cio_*mb APIs. The rte_cio_*mb APIs will be deprecated in 20.11 release. -* igb_uio: In the view of reducing the kernel dependency from the main tree, - as a first step, the Technical Board decided to move ``igb_uio`` - kernel module to the dpdk-kmods repository in the /linux/igb_uio/ directory - in 20.11. - Minutes of Technical Board Meeting of `2019-11-06 - <https://mails.dpdk.org/archives/dev/2019-November/151763.html>`_. - * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is used by iterators, and arrays holding these values are sized with this
doc/guides/rel_notes/release_20_11.rst +3 -0
@@ -68,6 +68,9 @@ Removed Items Also, make sure to start the actual text at the margin. ======================================================= +kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. + API Changes -----------
kernel/linux/igb_uio/Kbuild deleted +0 -0
kernel/linux/igb_uio/compat.h deleted +0 -0
kernel/linux/igb_uio/igb_uio.c deleted +0 -0
kernel/linux/igb_uio/meson.build deleted +0 -0
kernel/linux/meson.build +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -subdirs = ['igb_uio', 'kni'] +subdirs = ['kni'] # if we are cross-compiling we need kernel_dir specified if get_option('kernel_dir') == '' and meson.is_cross_build()
Signature · 1 line
2.28.0
Quoted 10 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)
<...>
MAINTAINERS F: doc/guides/linux_gsg/ · line 296
Quoted 7 lines
MAINTAINERS +0
-1@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/ Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio*
We are loosing maintainer information for the kernel module, same concern for other kernel modules in the 'dpdk-kmods' repo.
One option is 'dpdk-kmods' repo can have it's maintainers file, but I believe better to have single maintainer file, and cover the maintainer and location information in this file.
<...>
doc/guides/linux_gsg/linux_drivers.rst can provide the uio capability. This module can be loaded using the command: · line 31
Quoted 1 line
doc/guides/linux_gsg/linux_drivers.rst +1
-0+which can be found in the repository ``dpdk-kmods``.
There is no information where 'dpdk-kmods' repo is. It can be good to have it as link.
11/09/2020 18:22, Ferruh Yigit:
Quoted 16 lines · Thomas Monjalon
Quoted 10 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)<...>
Quoted 2 lines
(quoted diff) +0
-0@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/
Quoted 8 lines
MAINTAINERS F: doc/guides/linux_gsg/ · line 296
Quoted 5 lines
MAINTAINERS +0
-1Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio*We are loosing maintainer information for the kernel module, same concern for other kernel modules in the 'dpdk-kmods' repo.
There is not even contribution guidelines, mailing-list etc.
Quoted 3 lines
One option is 'dpdk-kmods' repo can have it's maintainers file, but I believe better to have single maintainer file, and cover the maintainer and location information in this file.
I think the contribution infos (including maintainers contact) should be inside the repo dpdk-kmods.
Quoted 5 lines
<...>
Quoted 1 line
+which can be found in the repository ``dpdk-kmods``.
There is no information where 'dpdk-kmods' repo is. It can be good to have it as link.
The real URL would be the git ones:
git://dpdk.org/dpdk-kmods
http://dpdk.org/git/dpdk-kmods
but the most convenient (for clicking) should be the cgit one:
http://git.dpdk.org/dpdk-kmods/
or directly the sub-directory in cgit:
http://git.dpdk.org/dpdk-kmods/tree/linux/igb_uio
Note that this last one does not show the git URLs for cloning.
Which one do you prefer?
Quoted 45 lines · Thomas Monjalon
11/09/2020 18:22, Ferruh Yigit:
Quoted 16 lines · Thomas Monjalon
Quoted 10 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)<...>
Quoted 2 lines
(quoted diff) +0
-0@@ -292,7 +292,6 @@ F: doc/guides/linux_gsg/Quoted 8 lines
MAINTAINERS F: doc/guides/linux_gsg/ · line 296
Quoted 5 lines
MAINTAINERS +0
-1Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio*We are loosing maintainer information for the kernel module, same concern for other kernel modules in the 'dpdk-kmods' repo.
There is not even contribution guidelines, mailing-list etc.
Quoted 3 lines
One option is 'dpdk-kmods' repo can have it's maintainers file, but I believe better to have single maintainer file, and cover the maintainer and location information in this file.
I think the contribution infos (including maintainers contact) should be inside the repo dpdk-kmods.
Quoted 5 lines
<...>
Quoted 1 line
+which can be found in the repository ``dpdk-kmods``.
There is no information where 'dpdk-kmods' repo is. It can be good to have it as link.
The real URL would be the git ones:
git://dpdk.org/dpdk-kmods
http://dpdk.org/git/dpdk-kmods
but the most convenient (for clicking) should be the cgit one:
Quoted 8 lines
http://git.dpdk.org/dpdk-kmods/or directly the sub-directory in cgit:
http://git.dpdk.org/dpdk-kmods/tree/linux/igb_uio
Note that this last one does not show the git URLs for cloning.Which one do you prefer?
+1 that "http://git.dpdk.org/dpdk-kmods/" is more convenient for documentation. People can figure out the git repo address from there.
Quoted 10 lines · On Fri, 11 Sep 2020 17:54:48 +0200 Thomas Monjalon <[email protected]> wrote:
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)
Good so far:
You may want to address all the references to igb_uio in guides/nics
ark.rstaxgbe.rstbnx2x.rstbnxt.rstbuild_and_test.rstena.rstenic.rstfeatures.rsthns3.rsti40e.rstintel_vf.rstixgbe.rstliquidio.rstmlx4.rstmlx5.rstnfp.rstqede.rstvirtio.rst
What about drivers like ark which don't mention vfio?
Does virtio still require igb_uio? or x86 I/O port for doorbell? Or is this just stale language.
24/09/2020 07:41, Stephen Hemminger:
Quoted 29 lines
Quoted 10 lines · On Fri, 11 Sep 2020 17:54:48 +0200 Thomas Monjalon <[email protected]> wrote:
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)Good so far:
You may want to address all the references to
igb_uioin guides/nics
ark.rstaxgbe.rstbnx2x.rstbnxt.rstbuild_and_test.rstena.rstenic.rstfeatures.rsthns3.rsti40e.rst
Quoted 8 lines
intel_vf.rstixgbe.rstliquidio.rstmlx4.rstmlx5.rstnfp.rstqede.rstvirtio.rst
igb_uio is still available.
A next step in deprecation might be to remove igb_uio references.
Quoted 1 line
What about drivers like ark which don't mention vfio?
They should be updated by their maintainer.
Quoted 2 lines
Does virtio still require
igb_uio? or x86 I/O port for doorbell? Or is this just stale language.
Maxime, any update on the use of igb_uio with virtio?
Quoted 42 lines · Thomas Monjalon
24/09/2020 07:41, Stephen Hemminger:
Quoted 29 lines
Quoted 10 lines · On Fri, 11 Sep 2020 17:54:48 +0200 Thomas Monjalon <[email protected]> wrote:
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)Good so far:
You may want to address all the references to
igb_uioin guides/nics
ark.rstaxgbe.rstbnx2x.rstbnxt.rstbuild_and_test.rstena.rstenic.rstfeatures.rsthns3.rsti40e.rstQuoted 8 lines
intel_vf.rstixgbe.rstliquidio.rstmlx4.rstmlx5.rstnfp.rstqede.rstvirtio.rst
igb_uiois still available.
A next step in deprecation might be to removeigb_uioreferences.
Quoted 8 lines
Quoted 1 line
What about drivers like ark which don't mention vfio?
They should be updated by their maintainer.
Quoted 2 lines
Does virtio still require
igb_uio? or x86 I/O port for doorbell? Or is this just stale language.Maxime, any update on the use of
igb_uiowith virtio?
For sure Virtio don't require igb_uio, I always use vfio myself. It seems the doc needs an update, I'll try to look at it later in this release.
Regards,
Maxime
Quoted 49 lines · Maxime Coquelin
Quoted 46 lines · Thomas Monjalon
24/09/2020 07:41, Stephen Hemminger:
Quoted 29 lines
Quoted 10 lines · On Fri, 11 Sep 2020 17:54:48 +0200 Thomas Monjalon <[email protected]> wrote:
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)Good so far:
You may want to address all the references to
igb_uioin guides/nics
ark.rstaxgbe.rstbnx2x.rstbnxt.rstbuild_and_test.rstena.rstenic.rstfeatures.rsthns3.rsti40e.rstQuoted 8 lines
intel_vf.rstixgbe.rstliquidio.rstmlx4.rstmlx5.rstnfp.rstqede.rstvirtio.rst
igb_uiois still available.
A next step in deprecation might be to removeigb_uioreferences.Quoted 1 line
What about drivers like ark which don't mention vfio?
They should be updated by their maintainer.
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
Does virtio still require
igb_uio? or x86 I/O port for doorbell? Or is this just stale language.Maxime, any update on the use of
igb_uiowith virtio?For sure Virtio don't require
igb_uio, I always use vfio myself. It seems the doc needs an update, I'll try to look at it later in this release.
Another gap I believe we need to close is that we need some instructions in the GSG for using vfio in noiommu mode, for those running in VMs without an emulated iommu. The VM case is the big one where using regular VFIO may cause problems. I do see in the GSG one mention that it's possible to use VFIO without an IOMMU, but no instructions on how to do so.
/Bruce
Quoted 47 lines · Maxime Coquelin
Quoted 45 lines · Thomas Monjalon
24/09/2020 07:41, Stephen Hemminger:
Quoted 28 lines
Quoted 10 lines · On Fri, 11 Sep 2020 17:54:48 +0200 Thomas Monjalon <[email protected]> wrote:
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v2: update few docs (including release notes)Good so far:
You may want to address all the references to
igb_uioin guides/nics
ark.rstaxgbe.rstbnx2x.rstbnxt.rstbuild_and_test.rstena.rstenic.rstfeatures.rsthns3.rsti40e.rstQuoted 8 lines
intel_vf.rstixgbe.rstliquidio.rstmlx4.rstmlx5.rstnfp.rstqede.rstvirtio.rst
igb_uiois still available.
A next step in deprecation might be to removeigb_uioreferences.Quoted 1 line
What about drivers like ark which don't mention vfio?
They should be updated by their maintainer.
Quoted 2 lines
Does virtio still require
igb_uio? or x86 I/O port for doorbell? Or is this just stale language.
Quoted 7 lines
Quoted 1 line
Maxime, any update on the use of
igb_uiowith virtio?For sure Virtio don't require
igb_uio, I always use vfio myself. It seems the doc needs an update, I'll try to look at it later in this release.Regards,
Maxime
PIO/MMIO write(notify backend) needs to go through vfio ioctl call,
which impacts performance. I fix this in another patch. PIO/MMIO
read/write will be executed directly in user space whatever driver is being
used.
/huawei
PATCH v3 1/1 kernel: remove igb_uio
In reply to Thomas MonjalonAs decided in the Technical Board in November 2019, the kernel module igb_uio is moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.html
---
v3: update more docs and provide a link to the new repo
v2: update few docs (including release notes)
--- MAINTAINERS | 1 - doc/guides/bbdevs/fpga_5gnr_fec.rst | 3 +- doc/guides/bbdevs/fpga_lte_fec.rst | 3 +- doc/guides/cryptodevs/ccp.rst | 3 +- doc/guides/cryptodevs/qat.rst | 3 +- doc/guides/howto/lm_bond_virtio_sriov.rst | 2 +- doc/guides/howto/lm_virtio_vhost_user.rst | 2 +- doc/guides/howto/openwrt.rst | 5 - doc/guides/linux_gsg/enable_func.rst | 3 +- doc/guides/linux_gsg/linux_drivers.rst | 23 +- doc/guides/nics/build_and_test.rst | 2 +- doc/guides/nics/ena.rst | 4 +- doc/guides/rel_notes/deprecation.rst | 7 - doc/guides/rel_notes/release_20_11.rst | 4 +- doc/guides/sample_app_ug/multi_process.rst | 2 - drivers/bus/pci/bsd/pci.c | 2 +- kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ----- kernel/linux/igb_uio/igb_uio.c | 660 --------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 21 files changed, 21 insertions(+), 886 deletions(-) delete mode 100644 kernel/linux/igb_uio/Kbuild delete mode 100644 kernel/linux/igb_uio/compat.h delete mode 100644 kernel/linux/igb_uio/igb_uio.c delete mode 100644 kernel/linux/igb_uio/meson.build
MAINTAINERS +0 -1
@@ -290,7 +290,6 @@ F: doc/guides/linux_gsg/ Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio* Linux VFIO
doc/guides/bbdevs/fpga_5gnr_fec.rst +1 -2
@@ -93,8 +93,7 @@ the UIO driver by repeating this command for every function. .. code-block:: console - cd <dpdk-top-level-directory> - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "8086 0d8f" > /sys/bus/pci/drivers/igb_uio/new_id lspci -vd8086:0d8f
doc/guides/bbdevs/fpga_lte_fec.rst +1 -2
@@ -92,8 +92,7 @@ the UIO driver by repeating this command for every function. .. code-block:: console - cd <dpdk-top-level-directory> - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "1172 5052" > /sys/bus/pci/drivers/igb_uio/new_id lspci -vd1172:
doc/guides/cryptodevs/ccp.rst +1 -2
@@ -75,9 +75,8 @@ Initialization Bind the CCP devices to DPDK UIO driver module before running the CCP PMD stack. e.g. for the 0x1456 device:: - cd to the top-level DPDK directory modprobe uio - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "1022 1456" > /sys/bus/pci/drivers/igb_uio/new_id Another way to bind the CCP devices to DPDK UIO driver is by using the ``dpdk-devbind.py`` script.
doc/guides/cryptodevs/qat.rst +1 -2
@@ -642,9 +642,8 @@ Install the DPDK igb_uio driver, bind the VF PCI Device id to it and use lspci to confirm the VF devices are now in use by igb_uio kernel driver, e.g. for the C62x device:: - cd to the top-level DPDK directory modprobe uio - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "8086 37c9" > /sys/bus/pci/drivers/igb_uio/new_id lspci -vvd:37c9
doc/guides/howto/lm_bond_virtio_sriov.rst +1 -1
@@ -591,7 +591,7 @@ Set up DPDK in the Virtual Machine rmmod virtio-pci ixgbevf modprobe uio - insmod /root/dpdk/<build_dir>/kernel/linux/igb_uio/igb_uio.ko + insmod igb_uio.ko /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:03.0 /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:04.0
doc/guides/howto/lm_virtio_vhost_user.rst +1 -1
@@ -421,7 +421,7 @@ setup_dpdk_virtio_in_vm.sh rmmod virtio-pci modprobe uio - insmod /root/dpdk/<build_dir>/kernel/linux/igb_uio/igb_uio.ko + insmod igb_uio.ko /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:03.0 /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:04.0
doc/guides/howto/openwrt.rst +0 -5
@@ -103,11 +103,6 @@ first. meson builddir --cross-file openwrt-cross ninja -C builddir -.. note:: - - For compiling the igb_uio with the kernel version used in target machine, - you need to explicitly specify kernel_dir in meson_options.txt. - Running DPDK application on OpenWrt -----------------------------------
doc/guides/linux_gsg/enable_func.rst +2 -1
@@ -155,4 +155,5 @@ This results in pass-through of the DMAR (DMA Remapping) lookup in the host. Also, if ``INTEL_IOMMU_DEFAULT_ON`` is not set in the kernel, the ``intel_iommu=on`` kernel parameter must be used too. This ensures that the Intel IOMMU is being initialized as expected. -Please note that while using ``iommu=pt`` is compulsory for ``igb_uio driver``, the ``vfio-pci`` driver can actually work with both ``iommu=pt`` and ``iommu=on``. +Please note that while using ``iommu=pt`` is compulsory for ``igb_uio`` driver, +the ``vfio-pci`` driver can actually work with both ``iommu=pt`` and ``iommu=on``.
doc/guides/linux_gsg/linux_drivers.rst +5 -18
@@ -27,33 +27,20 @@ can provide the uio capability. This module can be loaded using the command: ``uio_pci_generic`` module doesn't support the creation of virtual functions. -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio -module which can be found in the kernel/linux subdirectory referred to above. It can -be loaded as shown below: +As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module +which can be found in the repository `dpdk-kmods <http://git.dpdk.org/dpdk-kmods>`_. +It can be loaded as shown below: .. code-block:: console sudo modprobe uio - sudo insmod <build_dir>/kernel/linux/igb_uio/igb_uio.ko - -.. note:: - - Building DPDK Linux kernel modules is disabled by default starting from DPDK 20.02. - To enable them again, the config option "enable_kmods" needs to be set - in the meson build configuration. - See :ref:`adjusting_build_options` for details on how to set/clear build options. - It is planned to move ``igb_uio`` module to a different git repository. - -.. note:: - - For some devices which lack support for legacy interrupts, e.g. virtual function - (VF) devices, the ``igb_uio`` module may be needed in place of ``uio_pci_generic``. + sudo insmod igb_uio.ko .. note:: If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + ``vfio-pci`` kernel module rather than any UIO-based module. For more details see :ref:`linux_gsg_binding_kernel` below. .. note::
doc/guides/nics/build_and_test.rst +1 -1
@@ -69,7 +69,7 @@ This section demonstrates how to setup and run ``testpmd`` in Linux. .. code-block:: console modprobe uio - insmod ./x86_64-native-linux-gcc/kmod/igb_uio.ko + insmod igb_uio.ko or
doc/guides/nics/ena.rst +2 -2
@@ -169,8 +169,8 @@ Prerequisites (*) ENAv2 hardware supports Low Latency Queue v2 (LLQv2). This feature reduces the latency of the packets by pushing the header directly through the PCI to the device, before the DMA is even triggered. For proper work - kernel PCI driver must support write combining (WC). In mainline version of - ``igb_uio`` (in DPDK repo) it must be enabled by loading module with + kernel PCI driver must support write combining (WC). + In DPDK ``igb_uio`` it must be enabled by loading module with ``wc_activate=1`` flag (example below). However, mainline's vfio-pci driver in kernel doesn't have WC support yet (planed to be added). If vfio-pci used user should be either turn off ENAv2 (to avoid performance
doc/guides/rel_notes/deprecation.rst +0 -7
@@ -78,13 +78,6 @@ Deprecation Notices These wrappers must be used for patches that need to be merged in 20.08 onwards. This change will not introduce any performance degradation. -* igb_uio: In the view of reducing the kernel dependency from the main tree, - as a first step, the Technical Board decided to move ``igb_uio`` - kernel module to the dpdk-kmods repository in the /linux/igb_uio/ directory - in 20.11. - Minutes of Technical Board Meeting of `2019-11-06 - <https://mails.dpdk.org/archives/dev/2019-November/151763.html>`_. - * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is used by iterators, and arrays holding these values are sized with this
doc/guides/rel_notes/release_20_11.rst +3 -1
@@ -122,9 +122,11 @@ Removed Items * vhost: Dequeue zero-copy support has been removed. +* kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. + * Removed Python 2 support since it was EOL'd in January 2020. - API Changes -----------
doc/guides/sample_app_ug/multi_process.rst +0 -2
@@ -64,8 +64,6 @@ The process should start successfully and display a command prompt as follows: EAL: Virtual area found at 0x7ff200000000 (size = 0x40000000) ... - EAL: check igb_uio module - EAL: check module finished EAL: Master core 0 is ready (tid=54e41820) EAL: Core 1 is ready (tid=53b32700)
drivers/bus/pci/bsd/pci.c +1 -1
@@ -50,7 +50,7 @@* This code is used to simulate a PCI probe by parsing information in * sysfs. Moreover, when a registered driver matches a device, the * kernel driver currently using it is unloaded and replaced by -* igb_uio module, which is a very minimal userland driver for Intel +* nic_uio module, which is a very minimal userland driver for Intel * network card, only providing access to PCI BAR to applications, and * enabling bus master. */
kernel/linux/igb_uio/Kbuild deleted +0 -0
kernel/linux/igb_uio/compat.h deleted +0 -0
kernel/linux/igb_uio/igb_uio.c deleted +0 -0
kernel/linux/igb_uio/meson.build deleted +0 -0
kernel/linux/meson.build +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -subdirs = ['igb_uio', 'kni'] +subdirs = ['kni'] # if we are cross-compiling we need kernel_dir specified if get_option('kernel_dir') == '' and meson.is_cross_build()
Signature · 1 line
2.28.0
PATCH v4 1/1 kernel/linux: remove igb_uio
In reply to Thomas MonjalonAs decided in the Technical Board in November 2019, the kernel module igb_uio is moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.html
---
v4: Cc more maintainers
v3: update more docs and provide a link to the new repo
v2: update few docs (including release notes)
--- MAINTAINERS | 1 - doc/guides/bbdevs/fpga_5gnr_fec.rst | 3 +- doc/guides/bbdevs/fpga_lte_fec.rst | 3 +- doc/guides/cryptodevs/ccp.rst | 3 +- doc/guides/cryptodevs/qat.rst | 3 +- doc/guides/howto/lm_bond_virtio_sriov.rst | 2 +- doc/guides/howto/lm_virtio_vhost_user.rst | 2 +- doc/guides/howto/openwrt.rst | 5 - doc/guides/linux_gsg/enable_func.rst | 3 +- doc/guides/linux_gsg/linux_drivers.rst | 23 +- doc/guides/nics/build_and_test.rst | 2 +- doc/guides/nics/ena.rst | 4 +- doc/guides/rel_notes/deprecation.rst | 7 - doc/guides/rel_notes/release_20_11.rst | 4 +- doc/guides/sample_app_ug/multi_process.rst | 2 - drivers/bus/pci/bsd/pci.c | 2 +- kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ----- kernel/linux/igb_uio/igb_uio.c | 660 --------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 21 files changed, 21 insertions(+), 886 deletions(-) delete mode 100644 kernel/linux/igb_uio/Kbuild delete mode 100644 kernel/linux/igb_uio/compat.h delete mode 100644 kernel/linux/igb_uio/igb_uio.c delete mode 100644 kernel/linux/igb_uio/meson.build
MAINTAINERS +0 -1
@@ -290,7 +290,6 @@ F: doc/guides/linux_gsg/ Linux UIO M: Ferruh Yigit <[email protected]> -F: kernel/linux/igb_uio/ F: drivers/bus/pci/linux/*uio* Linux VFIO
doc/guides/bbdevs/fpga_5gnr_fec.rst +1 -2
@@ -93,8 +93,7 @@ the UIO driver by repeating this command for every function. .. code-block:: console - cd <dpdk-top-level-directory> - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "8086 0d8f" > /sys/bus/pci/drivers/igb_uio/new_id lspci -vd8086:0d8f
doc/guides/bbdevs/fpga_lte_fec.rst +1 -2
@@ -92,8 +92,7 @@ the UIO driver by repeating this command for every function. .. code-block:: console - cd <dpdk-top-level-directory> - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "1172 5052" > /sys/bus/pci/drivers/igb_uio/new_id lspci -vd1172:
doc/guides/cryptodevs/ccp.rst +1 -2
@@ -75,9 +75,8 @@ Initialization Bind the CCP devices to DPDK UIO driver module before running the CCP PMD stack. e.g. for the 0x1456 device:: - cd to the top-level DPDK directory modprobe uio - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "1022 1456" > /sys/bus/pci/drivers/igb_uio/new_id Another way to bind the CCP devices to DPDK UIO driver is by using the ``dpdk-devbind.py`` script.
doc/guides/cryptodevs/qat.rst +1 -2
@@ -642,9 +642,8 @@ Install the DPDK igb_uio driver, bind the VF PCI Device id to it and use lspci to confirm the VF devices are now in use by igb_uio kernel driver, e.g. for the C62x device:: - cd to the top-level DPDK directory modprobe uio - insmod ./build/kmod/igb_uio.ko + insmod igb_uio.ko echo "8086 37c9" > /sys/bus/pci/drivers/igb_uio/new_id lspci -vvd:37c9
doc/guides/howto/lm_bond_virtio_sriov.rst +1 -1
@@ -591,7 +591,7 @@ Set up DPDK in the Virtual Machine rmmod virtio-pci ixgbevf modprobe uio - insmod /root/dpdk/<build_dir>/kernel/linux/igb_uio/igb_uio.ko + insmod igb_uio.ko /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:03.0 /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:04.0
doc/guides/howto/lm_virtio_vhost_user.rst +1 -1
@@ -421,7 +421,7 @@ setup_dpdk_virtio_in_vm.sh rmmod virtio-pci modprobe uio - insmod /root/dpdk/<build_dir>/kernel/linux/igb_uio/igb_uio.ko + insmod igb_uio.ko /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:03.0 /root/dpdk/usertools/dpdk-devbind.py -b igb_uio 0000:00:04.0
doc/guides/howto/openwrt.rst +0 -5
@@ -103,11 +103,6 @@ first. meson builddir --cross-file openwrt-cross ninja -C builddir -.. note:: - - For compiling the igb_uio with the kernel version used in target machine, - you need to explicitly specify kernel_dir in meson_options.txt. - Running DPDK application on OpenWrt -----------------------------------
doc/guides/linux_gsg/enable_func.rst +2 -1
@@ -155,4 +155,5 @@ This results in pass-through of the DMAR (DMA Remapping) lookup in the host. Also, if ``INTEL_IOMMU_DEFAULT_ON`` is not set in the kernel, the ``intel_iommu=on`` kernel parameter must be used too. This ensures that the Intel IOMMU is being initialized as expected. -Please note that while using ``iommu=pt`` is compulsory for ``igb_uio driver``, the ``vfio-pci`` driver can actually work with both ``iommu=pt`` and ``iommu=on``. +Please note that while using ``iommu=pt`` is compulsory for ``igb_uio`` driver, +the ``vfio-pci`` driver can actually work with both ``iommu=pt`` and ``iommu=on``.
doc/guides/linux_gsg/linux_drivers.rst +5 -18
@@ -27,33 +27,20 @@ can provide the uio capability. This module can be loaded using the command: ``uio_pci_generic`` module doesn't support the creation of virtual functions. -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio -module which can be found in the kernel/linux subdirectory referred to above. It can -be loaded as shown below: +As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module +which can be found in the repository `dpdk-kmods <http://git.dpdk.org/dpdk-kmods>`_. +It can be loaded as shown below: .. code-block:: console sudo modprobe uio - sudo insmod <build_dir>/kernel/linux/igb_uio/igb_uio.ko - -.. note:: - - Building DPDK Linux kernel modules is disabled by default starting from DPDK 20.02. - To enable them again, the config option "enable_kmods" needs to be set - in the meson build configuration. - See :ref:`adjusting_build_options` for details on how to set/clear build options. - It is planned to move ``igb_uio`` module to a different git repository. - -.. note:: - - For some devices which lack support for legacy interrupts, e.g. virtual function - (VF) devices, the ``igb_uio`` module may be needed in place of ``uio_pci_generic``. + sudo insmod igb_uio.ko .. note:: If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + ``vfio-pci`` kernel module rather than any UIO-based module. For more details see :ref:`linux_gsg_binding_kernel` below. .. note::
doc/guides/nics/build_and_test.rst +1 -1
@@ -69,7 +69,7 @@ This section demonstrates how to setup and run ``testpmd`` in Linux. .. code-block:: console modprobe uio - insmod ./x86_64-native-linux-gcc/kmod/igb_uio.ko + insmod igb_uio.ko or
doc/guides/nics/ena.rst +2 -2
@@ -169,8 +169,8 @@ Prerequisites (*) ENAv2 hardware supports Low Latency Queue v2 (LLQv2). This feature reduces the latency of the packets by pushing the header directly through the PCI to the device, before the DMA is even triggered. For proper work - kernel PCI driver must support write combining (WC). In mainline version of - ``igb_uio`` (in DPDK repo) it must be enabled by loading module with + kernel PCI driver must support write combining (WC). + In DPDK ``igb_uio`` it must be enabled by loading module with ``wc_activate=1`` flag (example below). However, mainline's vfio-pci driver in kernel doesn't have WC support yet (planed to be added). If vfio-pci used user should be either turn off ENAv2 (to avoid performance
doc/guides/rel_notes/deprecation.rst +0 -7
@@ -78,13 +78,6 @@ Deprecation Notices These wrappers must be used for patches that need to be merged in 20.08 onwards. This change will not introduce any performance degradation. -* igb_uio: In the view of reducing the kernel dependency from the main tree, - as a first step, the Technical Board decided to move ``igb_uio`` - kernel module to the dpdk-kmods repository in the /linux/igb_uio/ directory - in 20.11. - Minutes of Technical Board Meeting of `2019-11-06 - <https://mails.dpdk.org/archives/dev/2019-November/151763.html>`_. - * lib: will fix extending some enum/define breaking the ABI. There are multiple samples in DPDK that enum/define terminated with a ``.*MAX.*`` value which is used by iterators, and arrays holding these values are sized with this
doc/guides/rel_notes/release_20_11.rst +3 -1
@@ -122,9 +122,11 @@ Removed Items * vhost: Dequeue zero-copy support has been removed. +* kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. + * Removed Python 2 support since it was EOL'd in January 2020. - API Changes -----------
doc/guides/sample_app_ug/multi_process.rst +0 -2
@@ -64,8 +64,6 @@ The process should start successfully and display a command prompt as follows: EAL: Virtual area found at 0x7ff200000000 (size = 0x40000000) ... - EAL: check igb_uio module - EAL: check module finished EAL: Master core 0 is ready (tid=54e41820) EAL: Core 1 is ready (tid=53b32700)
drivers/bus/pci/bsd/pci.c +1 -1
@@ -50,7 +50,7 @@* This code is used to simulate a PCI probe by parsing information in * sysfs. Moreover, when a registered driver matches a device, the * kernel driver currently using it is unloaded and replaced by -* igb_uio module, which is a very minimal userland driver for Intel +* nic_uio module, which is a very minimal userland driver for Intel * network card, only providing access to PCI BAR to applications, and * enabling bus master. */
kernel/linux/igb_uio/Kbuild deleted +0 -0
kernel/linux/igb_uio/compat.h deleted +0 -0
kernel/linux/igb_uio/igb_uio.c deleted +0 -0
kernel/linux/igb_uio/meson.build deleted +0 -0
kernel/linux/meson.build +1 -1
@@ -1,7 +1,7 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Intel Corporation -subdirs = ['igb_uio', 'kni'] +subdirs = ['kni'] # if we are cross-compiling we need kernel_dir specified if get_option('kernel_dir') == '' and meson.is_cross_build()
Signature · 1 line
2.28.0
Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
Quoted 9 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>
Jerin Jacob
Acked-byRe: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
Quoted 6 lines · Andrew Rybchenko
Quoted 4 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
Quoted 7 lines
Quoted 5 lines
Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>Acked-by Andrew Rybchenko <[email protected]>
Quoted 1 line
Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
In reply to Thomas MonjalonQuoted 36 lines · Thomas Monjalon
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.Minutes of Technical Board meeting:
https://mails.dpdk.org/archives/dev/2019-November/151763.htmlSigned-off-by Thomas Monjalon <[email protected]>---
v4: Cc more maintainers
v3: update more docs and provide a link to the new repo
v2: update few docs (including release notes)--- MAINTAINERS | 1 - doc/guides/bbdevs/fpga_5gnr_fec.rst | 3 +- doc/guides/bbdevs/fpga_lte_fec.rst | 3 +- doc/guides/cryptodevs/ccp.rst | 3 +- doc/guides/cryptodevs/qat.rst | 3 +- doc/guides/howto/lm_bond_virtio_sriov.rst | 2 +- doc/guides/howto/lm_virtio_vhost_user.rst | 2 +- doc/guides/howto/openwrt.rst | 5 - doc/guides/linux_gsg/enable_func.rst | 3 +- doc/guides/linux_gsg/linux_drivers.rst | 23 +- doc/guides/nics/build_and_test.rst | 2 +- doc/guides/nics/ena.rst | 4 +- doc/guides/rel_notes/deprecation.rst | 7 - doc/guides/rel_notes/release_20_11.rst | 4 +- doc/guides/sample_app_ug/multi_process.rst | 2 - drivers/bus/pci/bsd/pci.c | 2 +- kernel/linux/igb_uio/Kbuild | 2 - kernel/linux/igb_uio/compat.h | 154 ----- kernel/linux/igb_uio/igb_uio.c | 660 --------------------- kernel/linux/igb_uio/meson.build | 20 - kernel/linux/meson.build | 2 +- 21 files changed, 21 insertions(+), 886 deletions(-)
Quoted 5 lines
delete mode 100644
kernel/linux/igb_uio/Kbuilddelete mode 100644kernel/linux/igb_uio/compat.hdelete mode 100644kernel/linux/igb_uio/igb_uio.cdelete mode 100644kernel/linux/igb_uio/meson.build
Patch doesn't apply cleanly, not sure why, CI seems having same problem:
http://mails.dpdk.org/archives/test-report/2020-October/156378.html
<...>
Quoted 30 lines
index
7789c572bb..080b44955a100644doc/guides/linux_gsg/linux_drivers.rst +3
-16@@ -27,33 +27,20 @@ can provide the uio capability. This module can be loaded using the command: ``uio_pci_generic`` module doesn't support the creation of virtual functions. -As an alternative to the ``uio_pci_generic``, the DPDK also includes the igb_uio -module which can be found in the kernel/linux subdirectory referred to above. It can -be loaded as shown below: +As an alternative to the ``uio_pci_generic``, there is the ``igb_uio`` module +which can be found in the repository `dpdk-kmods <http://git.dpdk.org/dpdk-kmods>`_. +It can be loaded as shown below: .. code-block:: console sudo modprobe uio - sudo insmod <build_dir>/kernel/linux/igb_uio/igb_uio.ko - -.. note:: - - Building DPDK Linux kernel modules is disabled by default starting from DPDK 20.02. - To enable them again, the config option "enable_kmods" needs to be set - in the meson build configuration. - See :ref:`adjusting_build_options` for details on how to set/clear build options. - It is planned to move ``igb_uio`` module to a different git repository. - -.. note:: - - For some devices which lack support for legacy interrupts, e.g. virtual function
doc/guides/linux_gsg/linux_drivers.rst can provide the uio capability. This module can be loaded using the command: · line 44
Quoted 10 lines
doc/guides/linux_gsg/linux_drivers.rst +2
-2- (VF) devices, the ``igb_uio`` module may be needed in place of ``uio_pci_generic``. + sudo insmod igb_uio.ko .. note:: If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + ``vfio-pci`` kernel module rather than any UIO-based module. For more details see :ref:`linux_gsg_binding_kernel` below.
Should we change the order of the kernel drivers, currently first section is "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out of the repo, should we list the "VfIO" first?
<...>
doc/guides/rel_notes/release_20_11.rst Removed Items · line 127
Quoted 10 lines
index
4e61431c6c..243bd940a4100644doc/guides/rel_notes/release_20_11.rst +3
-0@@ -122,9 +122,11 @@ Removed Items * vhost: Dequeue zero-copy support has been removed. +* kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. +
Doc build giving warning on this:
WARNING: Bullet list ends without a blank line; unexpected unindent.
Except from above minor comments looks good to me,
Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
06/10/2020 12:16, Ferruh Yigit:
Quoted 4 lines · Thomas Monjalon
Quoted 3 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
[...]
Quoted 2 lines
Patch doesn't apply cleanly, not sure why, CI seems having same problem:
http://mails.dpdk.org/archives/test-report/2020-October/156378.html
That's because I used --irreversible-delete to minimize the size of the patch.
[...]
Quoted 9 lines
doc/guides/linux_gsg/linux_drivers.rst can provide the uio capability. This module can be loaded using the command: · line 44
Quoted 5 lines
If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the
doc/guides/linux_gsg/linux_drivers.rst +1
-1- ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + ``vfio-pci`` kernel module rather than any UIO-based module. For more details see :ref:`linux_gsg_binding_kernel` below.Should we change the order of the kernel drivers, currently first section is "UIO" and second section is "VFIO". Since we encoruage vfio and move
igb_uioout of the repo, should we list the "VfIO" first?
Absolutely.
In general we need to encourage more VFIO and remove some references to igb_uio. But I don't want to do such "marketing" change in this patch. The goal of this patch is just to move the code.
[...]
Quoted 6 lines
doc/guides/rel_notes/release_20_11.rst Removed Items · line 127
Quoted 3 lines
doc/guides/rel_notes/release_20_11.rst +3
-0+* kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. +Doc build giving warning on this:
WARNING: Bullet list ends without a blank line; unexpected unindent.
Probably a merge issue. That's fine on my side.
Quoted 2 lines
Except from above minor comments looks good to me,
Reviewed-by Ferruh Yigit <[email protected]>
Do we agree I can merge without any change?
Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
Quoted 19 lines · Thomas Monjalon
06/10/2020 12:16, Ferruh Yigit:
Quoted 4 lines · Thomas Monjalon
Quoted 3 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.[...]
Quoted 2 lines
Patch doesn't apply cleanly, not sure why, CI seems having same problem:
http://mails.dpdk.org/archives/test-report/2020-October/156378.htmlThat's because I used --irreversible-delete to minimize the size of the patch.
[...]
Quoted 6 lines
Quoted 5 lines
If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the
doc/guides/linux_gsg/linux_drivers.rst +1
-1- ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. + ``vfio-pci`` kernel module rather than any UIO-based module. For more details see :ref:`linux_gsg_binding_kernel` below.
Quoted 9 lines
Quoted 3 lines
Should we change the order of the kernel drivers, currently first section is "UIO" and second section is "VFIO". Since we encoruage vfio and move
igb_uioout of the repo, should we list the "VfIO" first?Absolutely.
In general we need to encourage more VFIO and remove some references toigb_uio. But I don't want to do such "marketing" change in this patch. The goal of this patch is just to move the code.
OK.
Quoted 10 lines
[...]
Quoted 6 lines
doc/guides/rel_notes/release_20_11.rst Removed Items · line 127
Quoted 3 lines
doc/guides/rel_notes/release_20_11.rst +3
-0+* kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. +Doc build giving warning on this:
WARNING: Bullet list ends without a blank line; unexpected unindent.Probably a merge issue. That's fine on my side.
I can see it is wrong in the patch itself, please double check in your end to be sure warning is not hidden in doc build. I am good as long as there is no warning.
Quoted 5 lines
Quoted 2 lines
Except from above minor comments looks good to me,
Reviewed-by Ferruh Yigit <[email protected]>Do we agree I can merge without any change?
Agree if the above doc warning is gone.
Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
06/10/2020 13:09, Ferruh Yigit:
Quoted 10 lines · Thomas Monjalon
Quoted 9 lines
06/10/2020 12:16, Ferruh Yigit:
Quoted 7 lines · Thomas Monjalon
doc/guides/rel_notes/release_20_11.rst Removed Items · line 127
Quoted 3 lines
doc/guides/rel_notes/release_20_11.rst +3
-0+* kernel: The module ``igb_uio`` has been moved to the git repository +``dpdk-kmods`` in a new directory ``linux/igb_uio``. +Doc build giving warning on this:
WARNING: Bullet list ends without a blank line; unexpected unindent.
Quoted 4 lines
Quoted 1 line
Probably a merge issue. That's fine on my side.
I can see it is wrong in the patch itself, please double check in your end to be sure warning is not hidden in doc build.
Yes you're right.
I misinterpreted the warning, now I see the missing indent, and my sphinx reports the problem as well.
Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio
In reply to Ferruh Yigit06/10/2020 13:09, Ferruh Yigit:
Quoted 7 lines · Thomas Monjalon
Quoted 6 lines
06/10/2020 12:16, Ferruh Yigit:
Quoted 4 lines · Thomas Monjalon
Quoted 3 lines
As decided in the Technical Board in November 2019, the kernel module
igb_uiois moved to the dpdk-kmods repository in the /linux/igb_uio/ directory.
Quoted 7 lines
Quoted 5 lines
[...]
Quoted 2 lines
Except from above minor comments looks good to me,
Reviewed-by Ferruh Yigit <[email protected]>Do we agree I can merge without any change?
Agree if the above doc warning is gone.
Fixed the warning and applied.
igb_uio is now retired in http://git.dpdk.org/dpdk-kmods/tree/linux/igb_uio
Next steps:
- remove unneeded references to igb_uio.
- plan what to do with kni.