Skip to contentSkip to conversation

i2c: i801: Exclude device from suspend direct complete optimization

PATCH In review Jean Delvare 2 participants 2 messages Oct 5, 2020 – Oct 9, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: i801: Exclude device from suspend direct complete optimization

commit 845b89127bc5458d0152a4d63f165c62a22fcb70 upstream.

By default, PCI drivers with runtime PM enabled will skip the calls to suspend and resume on system PM. For this driver, we don't want that, as we need to perform additional steps for system PM to work properly on all systems. So instruct the PM core to not skip these calls.

Fixes a9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM")

---
This is the backported version for kernel trees 5.4 and 4.19. The difference with the upstream commit is that DPM_FLAG_NEVER_SKIP is used instead of DPM_FLAG_NO_DIRECT_COMPLETE, which did not exist back then.

 drivers/i2c/busses/i2c-i801.c |    1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-i801.c +1 -0
@@ -1891,6 +1891,7 @@ static int i801_probe(struct pci_dev *de
 
 	pci_set_drvdata(dev, priv);
 
+	dev_pm_set_driver_flags(&dev->dev, DPM_FLAG_NEVER_SKIP);
 	pm_runtime_set_autosuspend_delay(&dev->dev, 1000);
 	pm_runtime_use_autosuspend(&dev->dev);
 	pm_runtime_put_autosuspend(&dev->dev);
Signature · 2 lines
Jean Delvare
SUSE L3 Support
maintainer
#1 lore raw
Quoted 13 lines · Jean Delvare

commit 845b89127bc5458d0152a4d63f165c62a22fcb70 upstream.

By default, PCI drivers with runtime PM enabled will skip the calls to suspend and resume on system PM. For this driver, we don't want that, as we need to perform additional steps for system PM to work properly on all systems. So instruct the PM core to not skip these calls.

Fixes a9c8088c7988 ("i2c: i801: Don't restore config registers on runtime PM")
Quoted 4 lines

---
This is the backported version for kernel trees 5.4 and 4.19. The difference with the upstream commit is that DPM_FLAG_NEVER_SKIP is used instead of DPM_FLAG_NO_DIRECT_COMPLETE, which did not exist back then.

Thanks, now queue dup.

greg k-h