drm/i915: Fix DMA mapped scatterlist walks
Subsystems (2)
PATCH 1/2 drm/i915: Fix DMA mapped scatterlist walks
From: Tvrtko Ursulin <[email protected]>
When walking DMA mapped scatterlists sg_dma_len has to be used since it can be different (coalesced) from the backing store entry.
This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker.
Both issues were there in theory for some time but were hidden by the fact Intel IOMMU driver was never coalescing entries. As there are ongoing efforts to change this we need to start handling it.
v2:
* Use unsigned int for local storing sg_dma_len. (Logan)
References: 85d1225ec066 ("drm/i915: Introduce & use new lightweight SGL iterators")
References: b31144c0daa8 ("drm/i915: Micro-optimise gen6_ppgtt_insert_entries()")
--- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 6 +++--- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 17 ++++++++++------- drivers/gpu/drm/i915/gt/intel_gtt.h | 2 +- drivers/gpu/drm/i915/i915_scatterlist.h | 12 ++++++++---- 4 files changed, 22 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/gt/gen6_ppgtt.c +3 -3
@@ -131,17 +131,17 @@ static void gen6_ppgtt_insert_entries(struct i915_address_space *vm, vaddr =kmap_atomic_px (i915_pt_entry (pd, act_pt)); do { - GEM_BUG_ON(iter.sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter.sg) < I915_GTT_PAGE_SIZE); vaddr[act_pte] = pte_encode | GEN6_PTE_ADDR_ENCODE(iter.dma); iter.dma += I915_GTT_PAGE_SIZE; if (iter.dma == iter.max) { iter.sg = __sg_next(iter.sg); - if (!iter.sg) + if (!iter.sg || sg_dma_len(iter.sg) == 0) break; iter.dma = sg_dma_address(iter.sg); - iter.max = iter.dma + iter.sg->length; + iter.max = iter.dma + sg_dma_len(iter.sg); } if (++act_pte == GEN6_PTES) {
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +10 -7
@@ -372,19 +372,19 @@ gen8_ppgtt_insert_pte(struct i915_ppgtt *ppgtt, pd =i915_pd_entry (pdp,gen8_pd_index (idx,2 )); vaddr =kmap_atomic_px (i915_pt_entry (pd,gen8_pd_index (idx,1 ))); do { - GEM_BUG_ON(iter->sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter->sg) < I915_GTT_PAGE_SIZE); vaddr[gen8_pd_index(idx, 0)] = pte_encode | iter->dma; iter->dma += I915_GTT_PAGE_SIZE; if (iter->dma >= iter->max) { iter->sg = __sg_next(iter->sg); - if (!iter->sg) { + if (!iter->sg || sg_dma_len(iter->sg) == 0) { idx = 0; break; } iter->dma = sg_dma_address(iter->sg); - iter->max = iter->dma + iter->sg->length; + iter->max = iter->dma + sg_dma_len(iter->sg); } if (gen8_pd_index(++idx, 0) == 0) {
@@ -413,8 +413,8 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, u32 flags) {const gen8_pte_t pte_encode =gen8_pte_encode (0 , cache_level, flags); +unsigned int rem =sg_dma_len (iter->sg);u64 start = vma->node.start; -dma_addr_t rem = iter->sg->length;GEM_BUG_ON (!i915_vm_is_4lvl (vma->vm));
@@ -456,7 +456,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, } do { - GEM_BUG_ON(iter->sg->length < page_size); + GEM_BUG_ON(sg_dma_len(iter->sg) < page_size); vaddr[index++] = encode | iter->dma; start += page_size;
@@ -467,7 +467,10 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma,if (!iter->sg)break ; - rem = iter->sg->length; + rem =sg_dma_len (iter->sg); +if (!rem) +break ; + iter->dma =sg_dma_address (iter->sg); iter->max = iter->dma + rem;
@@ -525,7 +528,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, } vma->page_sizes.gtt |= page_size; - }while (iter->sg); + }while (iter->sg &&sg_dma_len (iter->sg)); } static void gen8_ppgtt_insert(struct i915_address_space *vm,
drivers/gpu/drm/i915/gt/intel_gtt.h +1 -1
@@ -580,7 +580,7 @@ static inline struct sgt_dma {struct scatterlist *sg = vma->pages->sgl;dma_addr_t addr =sg_dma_address (sg); - return (struct sgt_dma){ sg, addr, addr + sg->length }; + return (struct sgt_dma){ sg, addr, addr + sg_dma_len(sg) }; }#endif
drivers/gpu/drm/i915/i915_scatterlist.h +8 -4
@@ -27,13 +27,17 @@ static __always_inline struct sgt_iter { } __sgt_iter(struct scatterlist *sgl, bool dma) {struct sgt_iter s = { .sgp = sgl }; -if (s.sgp) { +if (dma && s.sgp &&sg_dma_len (s.sgp) ==0 ) { + s.sgp =NULL ; + }else if (s.sgp) { s.max = s.curr = s.sgp->offset; - s.max += s.sgp->length; -if (dma) +if (dma) { s.dma =sg_dma_address (s.sgp); -else + s.max +=sg_dma_len (s.sgp); + }else { s.pfn =page_to_pfn (sg_page (s.sgp)); + s.max += s.sgp->length; + } }return s;
Signature · 6 lines
2.25.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915: Fix DMA mapped scatterlist lookup
From: Tvrtko Ursulin <[email protected]>
As the previous patch fixed the places where we walk the whole scatterlist for DMA addresses, this patch fixes the random lookup functionality.
To achieve this we have to add a second lookup iterator and add a i915_gem_object_get_sg_dma helper, to be used analoguous to existing i915_gem_object_get_sg_dma. Therefore two lookup caches are maintained per object and they are flushed at the same point for simplicity. (Strictly speaking the DMA cache should be flushed from i915_gem_gtt_finish_pages, but today this conincides with unsetting of the pages in general.)
Partial VMA view is then fixed to use the new DMA lookup and properly query sg length.
v2:
* Checkpatch.
--- drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 ++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 20 +++++++++++++++++- .../gpu/drm/i915/gem/i915_gem_object_types.h | 17 ++++++++------- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 21 ++++++++++++------- drivers/gpu/drm/i915/gt/intel_ggtt.c | 4 ++-- drivers/gpu/drm/i915/i915_scatterlist.h | 5 +++++ 6 files changed, 51 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.c +2 -0
@@ -82,6 +82,8 @@ void i915_gem_object_init(struct drm_i915_gem_object *obj, obj->mm.madv =I915_MADV_WILLNEED ;INIT_RADIX_TREE (&obj->mm.get_page.radix,GFP_KERNEL | __GFP_NOWARN);mutex_init (&obj->mm.get_page.lock); +INIT_RADIX_TREE (&obj->mm.get_dma_page.radix,GFP_KERNEL | __GFP_NOWARN); +mutex_init (&obj->mm.get_dma_page.lock);if (IS_ENABLED (CONFIG_LOCKDEP ) &&i915_gem_object_is_shrinkable (obj)) i915_gem_shrinker_taints_mutex(to_i915(obj->base.dev),
drivers/gpu/drm/i915/gem/i915_gem_object.h +19 -1
@@ -272,8 +272,26 @@ int i915_gem_object_set_tiling(struct drm_i915_gem_object *obj, unsigned int tiling, unsigned int stride);struct scatterlist * +__i915_gem_object_get_sg (struct drm_i915_gem_object *obj, +struct i915_gem_object_page_iter *iter, +unsigned int n, +unsigned int *offset); + +static inline struct scatterlist *i915_gem_object_get_sg (struct drm_i915_gem_object *obj, -unsigned int n,unsigned int *offset); +unsigned int n, +unsigned int *offset) +{ +return __i915_gem_object_get_sg (obj, &obj->mm.get_page, n, offset); +} + +static inline struct scatterlist * +i915_gem_object_get_sg_dma (struct drm_i915_gem_object *obj, +unsigned int n, +unsigned int *offset) +{ +return __i915_gem_object_get_sg (obj, &obj->mm.get_dma_page, n, offset); +}struct page * i915_gem_object_get_page(struct drm_i915_gem_object *obj,
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +10 -7
@@ -80,6 +80,14 @@ struct i915_mmap_offset {struct rb_node offset; }; +struct i915_gem_object_page_iter { +struct scatterlist *sg_pos; +unsigned int sg_idx;/* in pages, but 32bit eek! */ + +struct radix_tree_root radix; +struct mutex lock;/* protects this cache */ +}; +struct drm_i915_gem_object {struct drm_gem_object base;
@@ -246,13 +254,8 @@ struct drm_i915_gem_object { I915_SELFTEST_DECLARE(unsigned int page_mask); -struct i915_gem_object_page_iter { -struct scatterlist *sg_pos; -unsigned int sg_idx;/* in pages, but 32bit eek! */ - -struct radix_tree_root radix; -struct mutex lock;/* protects this cache */ - } get_page; +struct i915_gem_object_page_iter get_page; +struct i915_gem_object_page_iter get_dma_page;/** * Element within i915->mm.unbound_list or i915->mm.bound_list,
drivers/gpu/drm/i915/gem/i915_gem_pages.c +13 -8
@@ -33,6 +33,8 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj, obj->mm.get_page.sg_pos = pages->sgl; obj->mm.get_page.sg_idx =0 ; + obj->mm.get_dma_page.sg_pos = pages->sgl; + obj->mm.get_dma_page.sg_idx =0 ; obj->mm.pages = pages;
@@ -155,6 +157,8 @@ static void __i915_gem_object_reset_page_iter(struct drm_i915_gem_object *obj)rcu_read_lock ();radix_tree_for_each_slot (slot, &obj->mm.get_page.radix, &iter,0 )radix_tree_delete (&obj->mm.get_page.radix, iter.index); +radix_tree_for_each_slot (slot, &obj->mm.get_dma_page.radix, &iter,0 ) +radix_tree_delete (&obj->mm.get_dma_page.radix, iter.index);rcu_read_unlock (); }
@@ -450,11 +454,12 @@ void __i915_gem_object_release_map(struct drm_i915_gem_object *obj) }struct scatterlist * -i915_gem_object_get_sg (struct drm_i915_gem_object *obj, -unsigned int n, -unsigned int *offset) +__i915_gem_object_get_sg (struct drm_i915_gem_object *obj, +struct i915_gem_object_page_iter *iter, +unsigned int n, +unsigned int *offset) { -struct i915_gem_object_page_iter *iter = &obj->mm.get_page; +const bool dma = iter == &obj->mm.get_dma_page;struct scatterlist *sg;unsigned int idx, count;
@@ -483,7 +488,7 @@ i915_gem_object_get_sg(struct drm_i915_gem_object *obj, sg = iter->sg_pos; idx = iter->sg_idx; - count =__sg_page_count (sg); + count = dma ?__sg_dma_page_count (sg) :__sg_page_count (sg);while (idx + count <= n) {void *entry;
@@ -511,7 +516,7 @@ i915_gem_object_get_sg(struct drm_i915_gem_object *obj, idx += count; sg =____sg_next (sg); - count =__sg_page_count (sg); + count = dma ?__sg_dma_page_count (sg) :__sg_page_count (sg); } scan:
@@ -529,7 +534,7 @@ i915_gem_object_get_sg(struct drm_i915_gem_object *obj,while (idx + count <= n) { idx += count; sg =____sg_next (sg); - count =__sg_page_count (sg); + count = dma ?__sg_dma_page_count (sg) :__sg_page_count (sg); } *offset = n - idx;
@@ -596,7 +601,7 @@ i915_gem_object_get_dma_address_len(struct drm_i915_gem_object *obj,struct scatterlist *sg;unsigned int offset; - sg =i915_gem_object_get_sg (obj, n, &offset); + sg =i915_gem_object_get_sg_dma (obj, n, &offset);if (len) *len =sg_dma_len (sg) - (offset <<PAGE_SHIFT );
drivers/gpu/drm/i915/gt/intel_ggtt.c +2 -2
@@ -1383,7 +1383,7 @@ intel_partial_pages(const struct i915_ggtt_view *view,if (ret) goto err_sg_alloc; - iter =i915_gem_object_get_sg (obj, view->partial.offset, &offset); + iter =i915_gem_object_get_sg_dma (obj, view->partial.offset, &offset);GEM_BUG_ON (!iter); sg = st->sgl;
@@ -1391,7 +1391,7 @@ intel_partial_pages(const struct i915_ggtt_view *view, do { unsigned int len; - len = min(iter->length - (offset << PAGE_SHIFT), + len = min(sg_dma_len(iter) - (offset << PAGE_SHIFT), count << PAGE_SHIFT); sg_set_page(sg, NULL, len, 0); sg_dma_address(sg) =
drivers/gpu/drm/i915/i915_scatterlist.h +5 -0
@@ -48,6 +48,11 @@ static inline int __sg_page_count(const struct scatterlist *sg)return sg->length >>PAGE_SHIFT ; } +static inline int __sg_dma_page_count (const struct scatterlist *sg) +{ +return sg_dma_len (sg) >>PAGE_SHIFT ; +} +static inline struct scatterlist *____sg_next (struct scatterlist *sg) { ++sg;
Signature · 6 lines
2.25.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Fix DMA mapped scatterlist walks
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Fix DMA mapped scatterlist walks
URL : https://patchwork.freedesktop.org/series/82402/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9102 -> Patchwork_18631
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18631:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@gt_pm:
- {fi-kbl-7560u}: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-kbl-7560u/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-kbl-7560u/igt@i915_selftest@live@gt_pm.html
Known issues
------------
Here are the changes found in Patchwork_18631 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-bsw-kefka/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-bsw-kefka/igt@[email protected]
* igt@i915_selftest@live@coherency:
- fi-gdg-551: [PASS][5] -> [DMESG-FAIL][6] ([i915#1748])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-gdg-551/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-gdg-551/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [PASS][7] -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-kbl-x1275/igt@kms_busy@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-icl-u2/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-icl-u2/igt@kms_flip@[email protected]
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-bsw-n3050/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-bsw-n3050/igt@[email protected]
- {fi-kbl-7560u}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-kbl-7560u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-kbl-7560u/igt@[email protected]
* igt@kms_force_connector_basic@force-connector-state:
- {fi-tgl-dsi}: [DMESG-WARN][15] ([i915#1982] / [i915#402]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-tgl-dsi/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-tgl-dsi/igt@[email protected]
#### Warnings ####
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-kbl-x1275/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92]) -> [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95]) +8 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1748]: https://gitlab.freedesktop.org/drm/intel/issues/1748
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (43 -> 39)
------------------------------
Additional (2): fi-bdw-5557u fi-skl-6600u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9102 -> Patchwork_18631
CI-20190529: 20190529
CI_DRM_9102: 001564b45c93f68da80965b38a50eb77d12fa477 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5800: 982ca4122fd4f04ad3dfa80c6246f190b36e0c72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18631: 79a3042eaf97fb93693d93fd058968e3a439f689 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
79a3042eaf97 drm/i915: Fix DMA mapped scatterlist lookup 12a5c0fa9f8f drm/i915: Fix DMA mapped scatterlist walks
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Fix DMA mapped scatterlist walks
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Fix DMA mapped scatterlist walks
URL : https://patchwork.freedesktop.org/series/82402/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9102_full -> Patchwork_18631_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18631_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-skl: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][3] -> [FAIL][4] ([i915#2346])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][5] -> [FAIL][6] ([i915#79])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl9/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-kbl2/igt@kms_flip@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#2122])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl1/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-tiling-y:
- shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-tglb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-tglb2/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#1188])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl9/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [i915#265])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#1542])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [FAIL][21] ([i915#2389]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-hsw7/igt@gem_exec_reloc@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-hsw1/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [DMESG-WARN][23] ([i915#118] / [i915#95]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-glk4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-glk8/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-kbl7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-kbl6/igt@[email protected]
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-glk: [FAIL][27] ([i915#2521]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-glk2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-glk4/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge:
- shard-glk: [DMESG-WARN][29] ([i915#1982]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-glk3/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-glk2/igt@[email protected]
* igt@kms_cursor_legacy@all-pipes-torture-move:
- shard-iclb: [DMESG-WARN][31] ([i915#128]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-iclb6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-iclb3/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-skl: [DMESG-WARN][33] ([i915#1982]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl6/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][35] ([i915#2122]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl5/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl4/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][39] ([fdo#108145] / [i915#265]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-skl8/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-skl7/igt@[email protected]
* igt@kms_setmode@basic:
- shard-apl: [FAIL][41] ([i915#1635] / [i915#31]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-apl4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-apl2/igt@[email protected]
* igt@kms_vblank@pipe-b-wait-busy:
- shard-snb: [SKIP][43] ([fdo#109271]) -> [PASS][44] +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-snb4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-snb4/igt@[email protected]
* igt@perf_pmu@module-unload:
- shard-iclb: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-iclb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-iclb1/igt@[email protected]
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-glk: [FAIL][47] ([i915#1755]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9102/shard-glk4/igt@sysfs_timeslice_duration@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/shard-glk8/igt@sysfs_timeslice_duration@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2469]: https://gitlab.freedesktop.org/drm/intel/issues/2469
[i915#2476]: https://gitlab.freedesktop.org/drm/intel/issues/2476
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9102 -> Patchwork_18631
CI-20190529: 20190529
CI_DRM_9102: 001564b45c93f68da80965b38a50eb77d12fa477 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5800: 982ca4122fd4f04ad3dfa80c6246f190b36e0c72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18631: 79a3042eaf97fb93693d93fd058968e3a439f689 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18631/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx