Skip to contentSkip to conversation

crypto/aesni_mb: fix incorrect clearing of security session

PATCH Superseded David Coyle 3 participants 5 messages Oct 6, 2020 – Oct 9, 2020 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/aesni_mb: fix incorrect clearing of security session

When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object.

This patch fixes this issue by now clearing the private session object.

Fixes fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol")
---
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c +1 -1
index 2362f0c3c..b11d7f12b 100644
@@ -911,7 +911,7 @@ aesni_mb_pmd_sec_sess_destroy(void *dev __rte_unused,
 
 	if (sess_priv) {
 		struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv);
-		memset(sess, 0, sizeof(struct aesni_mb_session));
+		memset(sess_priv, 0, sizeof(struct aesni_mb_session));
 		set_sec_session_private_data(sess, NULL);
 		rte_mempool_put(sess_mp, sess_priv);
 	}
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Hi David,

Quoted 14 lines

-----Original Message-----
From: Coyle, David <[email protected]>
Sent: Tuesday, October 6, 2020 10:42 AM
To: De Lara Guarch, Pablo <[email protected]>; Doherty, Declan <[email protected]>
Cc: [email protected]; [email protected]; Coyle, David <[email protected]>
Subject: [PATCH v1] crypto/aesni_mb: fix incorrect clearing of security session

When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object.

Quoted 5 lines

This patch fixes this issue by now clearing the private session object.

Fixes fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol")

Patch looks good, but you need to CC stable, as this should be backported since the issue was introduced in the previous release. So, add Cc: [email protected] after Fixes: fda... and send a v2.
Apart from that, you can keep my ack:

#2 lore raw

Hi Pablo

Quoted 8 lines
Quoted 8 lines

When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object.

This patch fixes this issue by now clearing the private session object.

Quoted 8 lines
Quoted 3 lines
Fixes fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol")

Patch looks good, but you need to CC stable, as this should be backported since the issue was introduced in the previous release.
So, add Cc: [email protected] after Fixes: fda... and send a v2. Apart from that, you can keep my ack:

[DC] Done, thanks for pointing that out

Quoted 2 lines
#3 lore raw

PATCH v2 1/1 crypto/aesni_mb: fix incorrect clearing of security session

In reply to David Coyle

When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object.

This patch fixes this issue by now clearing the private session object.

Fixes fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol")

---
v2:
* CC'ing [email protected]

 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c +1 -1
index 2362f0c3c..b11d7f12b 100644
@@ -911,7 +911,7 @@ aesni_mb_pmd_sec_sess_destroy(void *dev __rte_unused,
 
 	if (sess_priv) {
 		struct rte_mempool *sess_mp = rte_mempool_from_obj(sess_priv);
-		memset(sess, 0, sizeof(struct aesni_mb_session));
+		memset(sess_priv, 0, sizeof(struct aesni_mb_session));
 		set_sec_session_private_data(sess, NULL);
 		rte_mempool_put(sess_mp, sess_priv);
 	}
Signature · 1 line
2.17.1
Applied
#4 lore raw
Quoted 5 lines

When destroying a security session, the AESNI-MB PMD attempted to clear the private aesni_mb session object to remove any key material. However, the function aesni_mb_pmd_sec_sess_destroy() cleared the security session object instead of the private session object.

Quoted 8 lines

This patch fixes this issue by now clearing the private session object.

Fixes fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol")

---

Applied to dpdk-next-crypto

Thanks.