lib/igt_chamelium: Use curl timeout for xmlrpc calls
PATCH v2 1/1 lib/igt_chamelium: Use curl timeout for xmlrpc calls
Use of timeouts everywhere is meaningless if xmlrpc calls are allowed to be blocking forever.
v2: Use milliseconds correctly (Juha-Pekka)
--- lib/igt_chamelium.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
lib/igt_chamelium.c +12 -1
@@ -2427,11 +2427,22 @@ void chamelium_deinit_rpc_only(struct chamelium *chamelium)struct chamelium *chamelium_init_rpc_only (void ) {struct chamelium *chamelium =malloc (sizeof (struct chamelium )); +struct xmlrpc_clientparms clientparms; +struct xmlrpc_curl_xportparms curlparms;if (!chamelium)return NULL ;memset (chamelium,0 ,sizeof (*chamelium)); +memset (&clientparms,0 ,sizeof (clientparms)); +memset (&curlparms,0 ,sizeof (curlparms)); + +/* curl's timeout is in milliseconds */ + curlparms.timeout = _RECEIVER_RESPONSIVE_AFTER_RESET_SECONDS *1000 ; + + clientparms.transport ="curl" ; + clientparms.transportparmsP = &curlparms; + clientparms.transportparm_size =XMLRPC_CXPSIZE (timeout); chamelium->drm_fd =-1 ;
@@ -2439,7 +2450,7 @@ struct chamelium *chamelium_init_rpc_only(void)xmlrpc_env_init (&chamelium->env);xmlrpc_client_setup_global_const (&chamelium->env);xmlrpc_client_create (&chamelium->env,XMLRPC_CLIENT_NO_FLAGS ,PACKAGE , -PACKAGE_VERSION ,NULL ,0 , &chamelium->client); +PACKAGE_VERSION , &clientparms,0 , &chamelium->client);if (chamelium->env.fault_occurred) {igt_debug ("Failed to init xmlrpc: %s\n" , chamelium->env.fault_string);
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_chamelium: Use curl timeout for xmlrpc calls (rev2)
== Series Details ==
== Series Details ==
Series: lib/igt_chamelium: Use curl timeout for xmlrpc calls (rev2)
URL : https://patchwork.freedesktop.org/series/82061/
State : success
== Summary ==
CI Bug Log - changes from IGT_5794 -> IGTPW_5031
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/index.html
Known issues
------------
Here are the changes found in IGTPW_5031 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-bsw-kefka/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-byt-j1900/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-byt-j1900/igt@[email protected]
* igt@i915_selftest@live@active:
- fi-bsw-n3050: [DMESG-FAIL][7] ([i915#541]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-bsw-n3050/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-bsw-n3050/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][9] ([i915#1161] / [i915#262]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-kbl-7500u/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-icl-u2/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-icl-u2/igt@kms_flip@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][13] ([i915#62]) -> [DMESG-FAIL][14] ([i915#62] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-kbl-x1275/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +4 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 37)
------------------------------
Missing (8): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5794 -> IGTPW_5031
CI-20190529: 20190529
CI_DRM_9077: ae1f3f7de609df105aeceed2655656ffc838d720 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5031: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/index.html
IGT_5794: eeccb2a17453f90ad92d1ab6f81ad7d344119d72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_chamelium: Use curl timeout for xmlrpc calls (rev2)
In reply to Petri Latvala== Series Details ==
== Series Details ==
Series: lib/igt_chamelium: Use curl timeout for xmlrpc calls (rev2)
URL : https://patchwork.freedesktop.org/series/82061/
State : success
== Summary ==
CI Bug Log - changes from IGT_5794_full -> IGTPW_5031_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/index.html
Known issues
------------
Here are the changes found in IGTPW_5031_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-apl: [PASS][1] -> [FAIL][2] ([i915#1635] / [i915#2389])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-apl1/igt@gem_exec_reloc@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-apl1/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2389]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-glk8/igt@gem_exec_reloc@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-glk6/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-glk8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-glk9/igt@[email protected]
* igt@i915_module_load@reload:
- shard-tglb: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-tglb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-tglb2/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#454])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-iclb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-iclb6/igt@[email protected]
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [PASS][11] -> [INCOMPLETE][12] ([i915#151] / [i915#155])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl6/igt@[email protected]
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-iclb: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-iclb5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-iclb3/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-tglb: [PASS][17] -> [SKIP][18] ([i915#1911])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-tglb8/igt@kms_psr2_su@page_flip.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-tglb6/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl6/igt@[email protected]
#### Possible fixes ####
* {igt@core_hotunplug@unbind-rebind}:
- shard-tglb: [INCOMPLETE][23] ([i915#1602]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-tglb2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-tglb2/igt@[email protected]
- shard-iclb: [INCOMPLETE][25] -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-iclb1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-iclb8/igt@[email protected]
* igt@gem_exec_nop@basic-parallel:
- shard-glk: [DMESG-WARN][27] ([i915#118] / [i915#95]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-glk8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-glk5/igt@[email protected]
* igt@kms_color@pipe-b-legacy-gamma:
- shard-kbl: [FAIL][29] ([i915#71]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl1/igt@[email protected]
- shard-apl: [FAIL][31] ([i915#1635] / [i915#71]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-apl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen:
- shard-kbl: [DMESG-WARN][33] ([i915#78]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +6 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl7/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_flip@modeset-vs-vblank-race@a-hdmi-a1:
- shard-glk: [FAIL][37] ([i915#407]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-glk5/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-tglb: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-tglb2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-tglb6/igt@[email protected]
- shard-glk: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-glk7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-glk6/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][43] ([fdo#109441]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf_pmu@busy-hang@vecs0:
- shard-iclb: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-iclb2/igt@perf_pmu@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-iclb3/igt@perf_pmu@[email protected]
* igt@syncobj_timeline@etime-single-wait-submitted:
- shard-kbl: [DMESG-WARN][47] ([i915#165]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5794/shard-kbl2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/shard-kbl1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2469]: https://gitlab.freedesktop.org/drm/intel/issues/2469
[i915#2476]: https://gitlab.freedesktop.org/drm/intel/issues/2476
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#71]: https://gitlab.freedesktop.org/drm/intel/issues/71
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5794 -> IGTPW_5031
CI-20190529: 20190529
CI_DRM_9077: ae1f3f7de609df105aeceed2655656ffc838d720 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5031: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/index.html
IGT_5794: eeccb2a17453f90ad92d1ab6f81ad7d344119d72 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5031/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patch look ok to me. I suspect there may be revealed chamelium related issues by this but they probably can be 'fixed' by increasing timeouts if there show some complex timing problems.
Quoted 43 lines · Petri Latvala
Use of timeouts everywhere is meaningless if xmlrpc calls are allowed to be blocking forever.
v2: Use milliseconds correctly (Juha-Pekka)
Signed-off-by Petri Latvala <[email protected]>Cc Kunal Joshi <[email protected]>Cc Arkadiusz Hiler <[email protected]>Cc Juha-Pekka Heikkila <[email protected]>Reviewed-by Juha-Pekka Heikkila <[email protected]> #v1--- lib/igt_chamelium.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)lib/igt_chamelium.c +11
-0@@ -2427,11 +2427,22 @@ void chamelium_deinit_rpc_only(struct chamelium *chamelium)struct chamelium *chamelium_init_rpc_only (void ) {struct chamelium *chamelium =malloc (sizeof (struct chamelium )); +struct xmlrpc_clientparms clientparms; +struct xmlrpc_curl_xportparms curlparms;if (!chamelium)return NULL ;memset (chamelium,0 ,sizeof (*chamelium)); +memset (&clientparms,0 ,sizeof (clientparms)); +memset (&curlparms,0 ,sizeof (curlparms)); + +/* curl's timeout is in milliseconds */ + curlparms.timeout = _RECEIVER_RESPONSIVE_AFTER_RESET_SECONDS *1000 ; + + clientparms.transport ="curl" ; + clientparms.transportparmsP = &curlparms; + clientparms.transportparm_size =XMLRPC_CXPSIZE (timeout); chamelium->drm_fd =-1 ;
lib/igt_chamelium.c struct chamelium *chamelium_init_rpc_only(void) · line 2456
Quoted 8 lines
lib/igt_chamelium.c +1
-1@@ -2439,7 +2450,7 @@ struct chamelium *chamelium_init_rpc_only(void)xmlrpc_env_init (&chamelium->env);xmlrpc_client_setup_global_const (&chamelium->env);xmlrpc_client_create (&chamelium->env,XMLRPC_CLIENT_NO_FLAGS ,PACKAGE , -PACKAGE_VERSION ,NULL ,0 , &chamelium->client); +PACKAGE_VERSION , &clientparms,0 , &chamelium->client);if (chamelium->env.fault_occurred) {igt_debug ("Failed to init xmlrpc: %s\n" , chamelium->env.fault_string);
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 5 lines · Juha-Pekka Heikkila
Patch look ok to me. I suspect there may be revealed chamelium related issues by this but they probably can be 'fixed' by increasing timeouts if there show some complex timing problems.
Reviewed-by Juha-Pekka Heikkila <[email protected]>
Thanks, merged. And ready to increase timeouts if weirdness ensues.
Signature · 5 lines
Petri Latvala _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev