Skip to contentSkip to conversation

drivers/leds/leds-tca6507.c:639 tca6507_register_gpios() error: uninitialized symbol 'gpios'.

PATCH New Dan Carpenter 1 participant 1 message Oct 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 17/31 drivers/leds/leds-tca6507.c:639 tca6507_register_gpios() error: uninitialized symbol 'gpios'.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kabel/linux.git leds-cleanup-for-pavel
head:   974272e79d48407fd82a556069a3f780e46473f5
commit: 2bf77804ba03c668694d89f7c4441be7bd971169 [17/31] leds: tca6507: register LEDs and GPIOs immediately after parsing
config: x86_64-randconfig-m001-20200930 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate

New smatch warnings:
drivers/leds/leds-tca6507.c:639 tca6507_register_gpios() error: uninitialized symbol 'gpios'.

vim +/gpios +639 drivers/leds/leds-tca6507.c

2bf77804ba03c6 Marek Behún 2020-09-19 629 static int tca6507_register_gpios(struct device *dev,
a6d511e5155406 NeilBrown 2012-01-10 630 struct tca6507_chip *tca,
2bf77804ba03c6 Marek Behún 2020-09-19 631 unsigned long gpio_bitmap)
a6d511e5155406 NeilBrown 2012-01-10 632 {
2bf77804ba03c6 Marek Behún 2020-09-19 633 int i, gpios, ret;
a6d511e5155406 NeilBrown 2012-01-10 634
2bf77804ba03c6 Marek Behún 2020-09-19 635 if (!gpio_bitmap)

a6d511e5155406 NeilBrown   2012-01-10  636  		return 0;
a6d511e5155406 NeilBrown   2012-01-10  637  
2bf77804ba03c6 Marek Behún 2020-09-19  638  	for_each_set_bit(i, &gpio_bitmap, NUM_LEDS)
2bf77804ba03c6 Marek Behún 2020-09-19 @639  		tca->gpio_map[gpios++] = i;
                                                                      ^^^^^^^

Uninitialized.

2bf77804ba03c6 Marek Behún 2020-09-19 640

a6d511e5155406 NeilBrown   2012-01-10  641  	tca->gpio.label = "gpio-tca6507";
a6d511e5155406 NeilBrown   2012-01-10  642  	tca->gpio.ngpio = gpios;
2bf77804ba03c6 Marek Behún 2020-09-19  643  	tca->gpio.base = -1;
a6d511e5155406 NeilBrown   2012-01-10  644  	tca->gpio.owner = THIS_MODULE;
a6d511e5155406 NeilBrown   2012-01-10  645  	tca->gpio.direction_output = tca6507_gpio_direction_output;
a6d511e5155406 NeilBrown   2012-01-10  646  	tca->gpio.set = tca6507_gpio_set_value;

faf6d5ff776bba Marek Behún 2020-09-19 647 tca->gpio.parent = dev;
10ead6e59934be NeilBrown 2013-10-31 648 #ifdef CONFIG_OF_GPIO
faf6d5ff776bba Marek Behún 2020-09-19 649 tca->gpio.of_node = of_node_get(dev_of_node(dev));
10ead6e59934be NeilBrown 2013-10-31 650 #endif

2bf77804ba03c6 Marek Behún 2020-09-19  651  	ret = gpiochip_add_data(&tca->gpio, tca);
2bf77804ba03c6 Marek Behún 2020-09-19  652  	if (ret)

a6d511e5155406 NeilBrown 2012-01-10 653 tca->gpio.ngpio = 0;
2bf77804ba03c6 Marek Behún 2020-09-19 654
2bf77804ba03c6 Marek Behún 2020-09-19 655 return ret;
a6d511e5155406 NeilBrown 2012-01-10 656 }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org