Skip to contentSkip to conversation

arm64: random: Remove no longer needed prototypes

PATCH Applied Andre Przywara 3 participants 3 messages Oct 6, 2020 – Oct 7, 2020 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: random: Remove no longer needed prototypes

Commit 9bceb80b3cc4 ("arm64: kaslr: Use standard early random function") removed the direct calls of the __arm64_rndr() and __early_cpu_has_rndr() functions, but left the dummy prototypes in the
#else branch of the #ifdef CONFIG_ARCH_RANDOM guard.

Remove the redundant prototypes, as they have no users outside of this header file.

---
 arch/arm64/include/asm/archrandom.h | 5 -----
 1 file changed, 5 deletions(-)
arch/arm64/include/asm/archrandom.h +0 -5
index 44209f6146aa..ffb1a40d5475 100644
@@ -79,10 +79,5 @@ arch_get_random_seed_long_early(unsigned long *v)
 }
 #define arch_get_random_seed_long_early arch_get_random_seed_long_early
 
-#else
-
-static inline bool __arm64_rndr(unsigned long *v) { return false; }
-static inline bool __init __early_cpu_has_rndr(void) { return false; }
-
 #endif /* CONFIG_ARCH_RANDOM */
 #endif /* _ASM_ARCHRANDOM_H */
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Andre Przywara

Commit 9bceb80b3cc4 ("arm64: kaslr: Use standard early random function") removed the direct calls of the __arm64_rndr() and __early_cpu_has_rndr() functions, but left the dummy prototypes in the
#else branch of the #ifdef CONFIG_ARCH_RANDOM guard.

Remove the redundant prototypes, as they have no users outside of this header file.

maintainer Applied
#2 lore raw
In reply to Andre Przywara
Quoted 7 lines · Andre Przywara

Commit 9bceb80b3cc4 ("arm64: kaslr: Use standard early random function") removed the direct calls of the __arm64_rndr() and __early_cpu_has_rndr() functions, but left the dummy prototypes in the
#else branch of the #ifdef CONFIG_ARCH_RANDOM guard.

Remove the redundant prototypes, as they have no users outside of this header file.

Applied to arm64 (for-next/late-arrivals), thanks!

[1/1] arm64: random: Remove no longer needed prototypes

      https://git.kernel.org/arm64/c/d433ab42fdc2

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev