Skip to contentSkip to conversation

package/mesa3d: add missing depends and driver name to r100 driver

PATCH New James Hilliard 3 participants 4 messages Feb 9, 2020 – Oct 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mesa3d: add missing depends and driver name to r100 driver

Propagate libdrm dependencies.

Add r100 to menu name to differentiate from r200 dri driver.

---
 package/mesa3d/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/mesa3d/Config.in +3 -1
index ff39652508..788705544d 100644
@@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 	  Support for Nvidia-based GPUs.
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	bool "DRI radeon driver"
+	bool "DRI radeon r100 driver"
+	depends on BR2_i386 || BR2_x86_64
+	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/mesa3d: add missing depends and driver name to r100 driver

Hi James,

Am Sun, 09 Feb 2020 11:34:41 -0700 schrieb James Hilliard:

Quoted 5 lines

Propagate libdrm dependencies.

Add r100 to menu name to differentiate from r200 dri driver.

Signed-off-by James Hilliard <james.hilliard1-

[email protected]>

Quoted 9 lines
---
 package/mesa3d/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/mesa3d/Config.in +0 -0
index ff39652508..788705544d 100644

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU · line 358

Quoted 5 lines
package/mesa3d/Config.in +1 -1
@@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 	  Support for Nvidia-based GPUs.
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	bool "DRI radeon driver"
+	bool "DRI radeon r100 driver"

ok.

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU · line 359

Quoted 1 line
package/mesa3d/Config.in +1 -0
+	depends on BR2_i386 || BR2_x86_64

Ok, the build system of mesa3d limits the driver to these archs:
https://cgit.freedesktop.org/mesa/mesa/tree/meson.build?h=20.1#n141

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU · line 360

Quoted 1 line
package/mesa3d/Config.in +1 -0
+	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC

ok.

Regards, Bernd

#2 lore raw

PATCH 1/1 package/mesa3d: add missing depends and driver name to r100 driver

In reply to James Hilliard

James, All,

On 2020-02-09 11:34 -0700, James Hilliard spake thusly:

Quoted 5 lines

Propagate libdrm dependencies.

Add r100 to menu name to differentiate from r200 dri driver.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/mesa3d/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/mesa3d/Config.in +3 -1
index ff39652508..788705544d 100644
@@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 	  Support for Nvidia-based GPUs.
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	bool "DRI radeon driver"
+	bool "DRI radeon r100 driver"
+	depends on BR2_i386 || BR2_x86_64
+	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/mesa3d: add missing depends and driver name to r100 driver

In reply to James Hilliard

James, All,

On 2020-02-09 11:34 -0700, James Hilliard spake thusly:

Quoted 14 lines

Propagate libdrm dependencies.

Add r100 to menu name to differentiate from r200 dri driver.

---
 package/mesa3d/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/mesa3d/Config.in +0 -0
index ff39652508..788705544d 100644

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU · line 360

Quoted 7 lines
package/mesa3d/Config.in +3 -1
@@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 	  Support for Nvidia-based GPUs.
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	bool "DRI radeon driver"
+	bool "DRI radeon r100 driver"
+	depends on BR2_i386 || BR2_x86_64
+	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC

This was causing a circular dependency, as noticed by Thomas:

package/gstreamer1/gstreamer1/Config.in:5:error: recursive dependency detected! package/gstreamer1/gstreamer1/Config.in:5:symbo l BR2_PACKAGE_GSTREAMER1 is selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
package/webkitgtk/Config.in:86:symbol BR2_PACKAGE_WEBKITGTK_MULTIMEDI A depends on BR2_PACKAGE_WEBKITGTK
package/webkitgtk/Config.in:23:symb ol BR2_PACKAGE_WEBKITGTK is selected by BR2_PACKAGE_MIDORI package/midori/Config.in:9:symbol BR2_PACKAGE_MIDORI depends on BR2_PACKAGE_LIBGTK3
package/libgtk3/Config.in:15:symbol BR2_PACKAGE_LIBGTK3 is selected b y BR2_PACKAGE_VTE
package/vte/Config.in:1:symbol BR2_PACKAGE_VTE depen ds on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
package/opengl/libegl/Config.in:4:symbol BR2_PACKAGE_HAS_LIBEGL_WAYLAND is selected by BR2_PACKAGE_MESA3D_OPENGL_ EGL
package/mesa3d/Config.in:436:symbol BR2_PACKAGE_MESA3D_OPENGL_EGL depends on BR2_PACKAGE_MESA3D_DRIVER
package/mesa3d/Config.in:75:symbo l BR2_PACKAGE_MESA3D_DRIVER is selected by BR2_PACKAGE_MESA3D_DRI_DRIVER
package/mesa3d/Config.in:61:symbol BR2_PACKAGE_MESA3D_DRI_DRIVER is s elected by BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
package/mesa3d/Config.in:372:symbol BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON depends on BR2_PACKAGE_LIBDRM_HAS _ATOMIC package/libdrm/Config.in:12:symbol BR2_PACKAGE_LIBDRM_HAS_ATOM IC depends on BR2_PACKAGE_LIBDRM
package/libdrm/Config.in:1:symbol BR2 _PACKAGE_LIBDRM is selected by BR2_PACKAGE_GST1_VAAPI
package/gstreamer1/gst1-vaapi/Config.in:1:symbol BR2_PACKAGE_GST1_VAAPI depends on BR2_PAC KAGE_GSTREAMER1

So, I dropped the dependency, like you already did in 00c1a8c34f7, and pushed that fix to master.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/mesa3d/Config.in +0 -0
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'