Skip to contentSkip to conversation

drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3651 icl_compute_tc_phy_dplls() warn: signedness bug returning '(-22)'

PATCH New Dan Carpenter 1 participant 1 message Oct 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 5/7 drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3651 icl_compute_tc_phy_dplls() warn: signedness bug returning '(-22)'

tree:   https://github.com/vsyrjala/linux.git crtc_clock_compute_3
head:   97c4a030c083dd28779000e380017473c63f7104
commit: e841fdbda72be2d2156b6e85b46595724f53eb7f [5/7] drm/i915: Split shared dpll .get_dplls into compute and get phases
config: i386-randconfig-m021-20201002 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/i915/display/intel_dpll_mgr.c:3651 icl_compute_tc_phy_dplls() warn: signedness bug returning '(-22)'

vim +3651 drivers/gpu/drm/i915/display/intel_dpll_mgr.c

e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä 2020-10-01 3640 static bool icl_compute_tc_phy_dplls(struct intel_atomic_state *state,

                                                                                                             ^^^^

e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä 2020-10-01 3641 struct intel_crtc *crtc)

c27e917e2bda748 drivers/gpu/drm/i915/intel_dpll_mgr.c         Paulo Zanoni          2018-04-27  3642  {
866955fa452e1f3 drivers/gpu/drm/i915/display/intel_dpll_mgr.c Imre Deak             2019-06-28  3643  	struct drm_i915_private *dev_priv = to_i915(state->base.dev);
866955fa452e1f3 drivers/gpu/drm/i915/display/intel_dpll_mgr.c Imre Deak             2019-06-28  3644  	struct intel_crtc_state *crtc_state =
866955fa452e1f3 drivers/gpu/drm/i915/display/intel_dpll_mgr.c Imre Deak             2019-06-28  3645  		intel_atomic_get_new_crtc_state(state, crtc);
e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä         2020-10-01  3646  	struct icl_port_dpll *port_dpll =
e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä         2020-10-01  3647  		&crtc_state->icl_port_dplls[ICL_PORT_DPLL_DEFAULT];
fc6200948275383 drivers/gpu/drm/i915/display/intel_dpll_mgr.c Imre Deak             2020-06-29  3648  	struct skl_wrpll_params pll_params = {};
17a3b15ac6afc7e drivers/gpu/drm/i915/intel_dpll_mgr.c         José Roberto de Souza 2018-10-30  3649  
e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä         2020-10-01  3650  	if (!icl_calc_tbt_pll(crtc_state, &pll_params))
e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä         2020-10-01 @3651  		return -EINVAL;
                                                                                                                ^^^^^^^^^^^^^^^

This becomes "return true;"

c27e917e2bda748 drivers/gpu/drm/i915/intel_dpll_mgr.c         Paulo Zanoni          2018-04-27  3652  
fc6200948275383 drivers/gpu/drm/i915/display/intel_dpll_mgr.c Imre Deak             2020-06-29  3653  	icl_calc_dpll_state(dev_priv, &pll_params, &port_dpll->hw_state);
fc6200948275383 drivers/gpu/drm/i915/display/intel_dpll_mgr.c Imre Deak             2020-06-29  3654  
e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä         2020-10-01  3655  	return 0;
e841fdbda72be2d drivers/gpu/drm/i915/display/intel_dpll_mgr.c Ville Syrjälä         2020-10-01  3656  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org