Skip to contentSkip to conversation

drm/amdgpu: Remove warning for virtual_display

PATCH In review Emily.Deng 2 participants 2 messages Oct 8, 2020

Subsystems (2)
lore
Share & tools
lore

Emily.Deng

author
#0 lore raw

PATCH 1/1 drm/amdgpu: Remove warning for virtual_display

Remove the virtual_display warning in drm_crtc_vblank_off when dev->num_crtcs is null.

Change-Id I755150a32478d8c128eed7ed98a71175d2b3aefc
---
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +3 -1
index 52d40b5e14db..fcf61d94fbc8 100644
@@ -189,8 +189,10 @@ static void dce_virtual_crtc_commit(struct drm_crtc *crtc)
 static void dce_virtual_crtc_disable(struct drm_crtc *crtc)
 {
 	struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
+	struct drm_device *dev = crtc->dev;
 
-	drm_crtc_vblank_off(crtc);
+	if (!dev->num_crtcs)
+		drm_crtc_vblank_off(crtc);
 
 	amdgpu_crtc->enabled = false;
 	amdgpu_crtc->pll_id = ATOM_PPLL_INVALID;
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw

Reviewed-by Andrey Grodzovsky<[email protected]>

Andrey

________________________________
From: amd-gfx <[email protected]> on behalf of Emily.Deng <[email protected]>
Sent: 07 October 2020 21:35
To: [email protected] <[email protected]>
Cc: Deng, Emily <[email protected]>
Subject: [PATCH] drm/amdgpu: Remove warning for virtual_display

Remove the virtual_display warning in drm_crtc_vblank_off when dev->num_crtcs is null.

Change-Id I755150a32478d8c128eed7ed98a71175d2b3aefc
---
 drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_virtual.c +3 -1
index 52d40b5e14db..fcf61d94fbc8 100644
@@ -189,8 +189,10 @@ static void dce_virtual_crtc_commit(struct drm_crtc *crtc)
 static void dce_virtual_crtc_disable(struct drm_crtc *crtc)
 {
         struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
+       struct drm_device *dev = crtc->dev;
 
-       drm_crtc_vblank_off(crtc);
+       if (!dev->num_crtcs)
+               drm_crtc_vblank_off(crtc);
 
         amdgpu_crtc->enabled = false;
         amdgpu_crtc->pll_id = ATOM_PPLL_INVALID;

--
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Candrey.grodzovsky%40amd.com%7Cfd5676290dcd40dc951b08d86b2a6ea1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637377177905980484&amp;sdata=7k9NLDRoiOFoLTxL%2BS2gHaIs5cQ7nNmch5onjEm9nnU%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx