net: smc: fix missing brace warning for old compilers
PATCH 1/2 net: smc: fix missing brace warning for old compilers
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all':net/smc/smc_llc.c:1317:9: warning: missing braces around initializer [-Wmissing-braces]
struct smc_llc_msg_del_link delllc = {0};
^net/smc/smc_llc.c:1317:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces]
1 warnings generated
--- net/smc/smc_llc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/smc/smc_llc.c +1 -1
@@ -1314,7 +1314,7 @@ static void smc_llc_process_cli_delete_link(struct smc_link_group *lgr)*/ void smc_llc_send_link_delete_all (struct smc_link_group *lgr,bool ord,u32 rsn) { -struct smc_llc_msg_del_link delllc = {0 }; +struct smc_llc_msg_del_link delllc = {};int i; delllc.hd.common.type =SMC_LLC_DELETE_LINK ;
Signature · 1 line
2.18.1
PATCH 2/2 net: smc: fix missing brace warning for old compilers
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_add_link_local':net/smc/smc_llc.c:1212:9: warning: missing braces around initializer [-Wmissing-braces]
struct smc_llc_msg_add_link add_llc = {0};
^
net/smc/smc_llc.c:1212:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces]
net/smc/smc_llc.c: In function 'smc_llc_srv_delete_link_local':
net/smc/smc_llc.c:1245:9: warning: missing braces around initializer [-Wmissing-braces]
struct smc_llc_msg_del_link del_llc = {0};
^net/smc/smc_llc.c:1245:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces]
2 warnings generated
--- net/smc/smc_llc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/smc/smc_llc.c +2 -2
@@ -1209,7 +1209,7 @@ static void smc_llc_process_srv_add_link(struct smc_link_group *lgr)/* enqueue a local add_link req to trigger a new add_link flow */ void smc_llc_add_link_local (struct smc_link *link) { -struct smc_llc_msg_add_link add_llc = {0 }; +struct smc_llc_msg_add_link add_llc = {}; add_llc.hd.length =sizeof (add_llc); add_llc.hd.common.type =SMC_LLC_ADD_LINK ;
@@ -1242,7 +1242,7 @@ static void smc_llc_add_link_work(struct work_struct *work)*/ void smc_llc_srv_delete_link_local (struct smc_link *link,u8 del_link_id) { -struct smc_llc_msg_del_link del_llc = {0 }; +struct smc_llc_msg_del_link del_llc = {}; del_llc.hd.length =sizeof (del_llc); del_llc.hd.common.type =SMC_LLC_DELETE_LINK ;
Signature · 1 line
2.18.1
Quoted 11 lines · On Thu, 8 Oct 2020 20:19:29 +0800 Pujin Shi <[email protected]> wrote:
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_add_link_local':net/smc/smc_llc.c:1212:9: warning: missing braces around initializer [-Wmissing-braces]struct smc_llc_msg_add_link add_llc = {0}; ^ net/smc/smc_llc.c:1212:9: warning: (near initialization for 'add_llc.hd') [-Wmissing-braces] net/smc/smc_llc.c: In function 'smc_llc_srv_delete_link_local': net/smc/smc_llc.c:1245:9: warning: missing braces around initializer [-Wmissing-braces] struct smc_llc_msg_del_link del_llc = {0}; ^
Quoted 4 lines
net/smc/smc_llc.c:1245:9: warning: (near initialization for 'del_llc.hd') [-Wmissing-braces]2 warnings generated
Signature · 1 line
Karsten
Quoted 10 lines · On Thu, 8 Oct 2020 20:19:28 +0800 Pujin Shi <[email protected]> wrote:
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all':net/smc/smc_llc.c:1317:9: warning: missing braces around initializer [-Wmissing-braces]struct smc_llc_msg_del_link delllc = {0}; ^
net/smc/smc_llc.c:1317:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces]1 warnings generated
Signature · 1 line
Karsten
Quoted 4 lines · On Thu, 8 Oct 2020 20:19:28 +0800 Pujin Shi wrote:
For older versions of gcc, the array = {0}; will cause warnings:
net/smc/smc_llc.c: In function 'smc_llc_send_link_delete_all':net/smc/smc_llc.c:1317:9: warning: missing braces around initializer [-Wmissing-braces]
Quoted 8 lines
struct smc_llc_msg_del_link delllc = {0}; ^
net/smc/smc_llc.c:1317:9: warning: (near initialization for 'delllc.hd') [-Wmissing-braces]1 warnings generated
Fixes f3811fd7bc97 ("net/smc: send DELETE_LINK, ALL message and wait for send to complete")Signed-off-by Pujin Shi <[email protected]>
Applied both, thanks!