Skip to contentSkip to conversation

package/mtd: add host-acl dependency for host

PATCH New Antoine Tenart 3 participants 5 messages Oct 8, 2020 – Oct 10, 2020 Journalling flash file system V2 (JFFS2)

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 package/mtd: add host-acl dependency for host

When compiling the host version of mtd, --with-jffs and --with-ubifs are always set, meaning --with-xattr is set by default. The xattr support only work if 'sys/acl.h' is available, otherwise the feature is silently dropped (a warning is shown during the configuration step).

This patch adds a dependency on host-acl for host-mtd, so that the xattr feature is correctly supported. Logic to have xattr support is already there and working for the non-host flavour.

---
 package/mtd/mtd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mtd/mtd.mk +1 -1
index 1186fa52d552..9f259b35d906 100644
@@ -53,7 +53,7 @@ else
 MTD_CONF_OPTS += --without-xattr
 endif
 
-HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd
+HOST_MTD_DEPENDENCIES = host-acl host-zlib host-lzo host-util-linux host-zstd
 HOST_MTD_CONF_OPTS = \
 	--with-jffs \
 	--with-ubifs \
Signature · 1 line
2.26.2
#1 lore raw

PATCH v3 2/2 fs/jffs2: copy xattrs

This patch sets the --with-xattr option when generating an image with mkfs.jffs2, so that SELinux security contexts and other extended attributes will be kept and available in jffs2 images.

---

Since v2:
- Removed condition on BR2_PACKAGE_LIBSELINUX.

Since v1:
- s/BR2_PACKAGE_REFPOLICY/BR2_PACKAGE_LIBSELINUX/

 fs/jffs2/jffs2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jffs2/jffs2.mk +1 -1
index 2adbc2320e38..0096af2ea966 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-JFFS2_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE)
+JFFS2_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE) --with-xattr
 SUMTOOL_OPTS = -e $(BR2_TARGET_ROOTFS_JFFS2_EBSIZE)
 
 ifeq ($(BR2_TARGET_ROOTFS_JFFS2_PAD),y)
Signature · 1 line
2.26.2
#2 lore raw

PATCH v3 2/2 fs/jffs2: copy xattrs

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Antoine" == Antoine Tenart <[email protected]> writes:

This patch sets the --with-xattr option when generating an image with mkfs.jffs2, so that SELinux security contexts and other extended attributes will be kept and available in jffs2 images.

Quoted 8 lines

---

Since v2:
- Removed condition on BR2_PACKAGE_LIBSELINUX.

Since v1:
- s/BR2_PACKAGE_REFPOLICY/BR2_PACKAGE_LIBSELINUX/

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v3 1/2 package/mtd: add host-acl dependency for host

In reply to Antoine Tenart
Quoted 9 lines · On Thu, 8 Oct 2020 11:08:35 +0200 Antoine Tenart <[email protected]>…

When compiling the host version of mtd, --with-jffs and --with-ubifs are always set, meaning --with-xattr is set by default. The xattr support only work if 'sys/acl.h' is available, otherwise the feature is silently dropped (a warning is shown during the configuration step).

This patch adds a dependency on host-acl for host-mtd, so that the xattr feature is correctly supported. Logic to have xattr support is already there and working for the non-host flavour.

Quoted 5 lines
---
 package/mtd/mtd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Series applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v3 1/2 package/mtd: add host-acl dependency for host

In reply to Antoine Tenart
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Antoine" == Antoine Tenart <[email protected]> writes:

When compiling the host version of mtd, --with-jffs and --with-ubifs are always set, meaning --with-xattr is set by default. The xattr support only work if 'sys/acl.h' is available, otherwise the feature is silently dropped (a warning is shown during the configuration step).

Quoted 6 lines

This patch adds a dependency on host-acl for host-mtd, so that the xattr feature is correctly supported. Logic to have xattr support is already there and working for the non-host flavour.

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard