Skip to contentSkip to conversation

vnc-stubs: Allow -vnc none

PATCH In review Jason Andryuk 2 participants 2 messages Oct 9, 2020 – Oct 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vnc-stubs: Allow -vnc none

Currently -vnc none is fatal when built with --disable-vnc. Make vnc_parse accept "none", so QEMU still run without using vnc.

---
 ui/vnc-stubs.c | 3 +++
 1 file changed, 3 insertions(+)
ui/vnc-stubs.c +3 -0
index 06c4ac6296..c6b737dcec 100644
@@ -12,6 +12,9 @@ int vnc_display_pw_expire(const char *id, time_t expires)
 };
 QemuOpts *vnc_parse(const char *str, Error **errp)
 {
+    if (strcmp(str, "none") == 0) {
+        return NULL;
+    }
     error_setg(errp, "VNC support is disabled");
     return NULL;
 }
Signature · 1 line
2.25.1
#1 lore raw
Quoted 4 lines · Jason Andryuk

Currently -vnc none is fatal when built with --disable-vnc. Make vnc_parse accept "none", so QEMU still run without using vnc.

Makes sense. Added to UI queue.

thanks,
Gerd