Skip to contentSkip to conversation

Fixed coding style issues raised by checkpatch.

PATCH In review Tabot Kevin 3 participants 3 messages Oct 9, 2020 – Oct 10, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixed coding style issues raised by checkpatch.

This patch fixes the following:
- Made sure alignment matched open parenthesis.

---
 drivers/staging/greybus/audio_module.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/greybus/audio_module.c +4 -4
index c52c4f3..a243d60 100644
@@ -175,8 +175,8 @@ static int gbaudio_codec_request_handler(struct gb_operation *op)
 }
 
 static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
-				struct greybus_descriptor_cport *cport_desc,
-				struct gb_bundle *bundle)
+					struct greybus_descriptor_cport *cport_desc,
+					struct gb_bundle *bundle)
 {
 	struct gb_connection *connection;
 
@@ -199,8 +199,8 @@ static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
 }
 
 static int gb_audio_add_data_connection(struct gbaudio_module_info *gbmodule,
-				struct greybus_descriptor_cport *cport_desc,
-				struct gb_bundle *bundle)
+					struct greybus_descriptor_cport *cport_desc,
+					struct gb_bundle *bundle)
 {
 	struct gb_connection *connection;
 	struct gbaudio_data_connection *dai;
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Tabot Kevin

This patch fixes the following:
- Made sure alignment matched open parenthesis.

---
 drivers/staging/greybus/audio_module.c | 8 ++++----

As my bot asked you to, please use scripts/get_maintainer.pl to determine who, and what mailing lists, to send patches to.

Also, I think this patch has been rejected many times in the past, please check the archives first before sending it again.

thanks,

greg k-h

#2 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Tabot Kevin

This patch fixes the following:
- Made sure alignment matched open parenthesis.

---
 drivers/staging/greybus/audio_module.c | 8 ++++----

As my bot asked you to, please use scripts/get_maintainer.pl to determine who, and what mailing lists, to send patches to.

fyi Tabot, he means you to use:

$ ./scripts/get_maintainer.pl -f drivers/staging/greybus/audio_module.c
Vaibhav Agarwal <[email protected]> (maintainer:GREYBUS AUDIO PROTOCOLS DRIVERS)
Mark Greer <[email protected]> (maintainer:GREYBUS AUDIO PROTOCOLS DRIVERS)
Johan Hovold <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <[email protected]> (maintainer:GREYBUS SUBSYSTEM)
[email protected] (moderated list:GREYBUS SUBSYSTEM)
[email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
Quoted 2 lines

Also, I think this patch has been rejected many times in the past, please check the archives first before sending it again.

Doubtful about that as almost the entire file uses alignment to open parenthesis.