Allow privileged user to map the OA buffer
Subsystems (3)
cover Allow privileged user to map the OA buffer
Allow user to map the OA buffer and also trigger reports into it.
CI fixes:
v1: Fixes a memory corruption due to addition of OA whitelist on demand.
v2: Spinlock when applying whitelist
v3: Use uncore->lock. Do not check for wal->count when applying whitelist.
v4: Refresh and rerun with newly added test (forked access). v5:
- Split patches into smaller units
- Grow the wal->list only for the engine that needs it.
- Bring back the wal->count check when applying whitelist during resume
v6: Fix checkpatch and sparse warnings
Test-with: [email protected]
Piotr Maciejewski (1):
drm/i915/perf: Ensure observation logic is not clock gated
Umesh Nerlige Ramappa (5):
drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock drm/i915/perf: Whitelist OA report trigger registers drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow drm/i915/perf: Whitelist OA counter and buffer registers drm/i915/perf: Map OA buffer to user space for gen12 performance query
drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + drivers/gpu/drm/i915/gt/intel_workarounds.c | 212 ++++++++++++---- drivers/gpu/drm/i915/gt/intel_workarounds.h | 7 + .../gpu/drm/i915/gt/intel_workarounds_types.h | 5 + drivers/gpu/drm/i915/i915_perf.c | 228 +++++++++++++++++- drivers/gpu/drm/i915/i915_perf_types.h | 8 + drivers/gpu/drm/i915/i915_reg.h | 10 + include/uapi/drm/i915_drm.h | 33 +++ 9 files changed, 455 insertions(+), 52 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/6 drm/i915/perf: Ensure observation logic is not clock gated
From: Piotr Maciejewski <[email protected]>
A clock gating switch can control if the performance monitoring and observation logic is enaled or not. Ensure that we enable the clocks.
v2: Separate code from other patches (Lionel)
v3: Reset PMON enable when disabling perf to save power (Lionel)
v4: Use intel_uncore_rmw and REG_BIT (Chris)
--- drivers/gpu/drm/i915/i915_perf.c | 9 +++++++++ drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 11 insertions(+)
drivers/gpu/drm/i915/i915_perf.c +9 -0
@@ -2520,6 +2520,12 @@ gen12_enable_metric_set(struct i915_perf_stream *stream, (period_exponent << GEN12_OAG_OAGLBCTXCTRL_TIMER_PERIOD_SHIFT)) : 0); +/* +* Initialize Super Queue Internal Cnt Register +* Set PMON Enable in order to collect valid metrics. +*/ +intel_uncore_rmw (uncore,GEN12_SQCNT1 ,0 ,GEN12_SQCNT1_PMON_ENABLE ); +/* * Update all contexts prior writing the mux configurations as we need * to make sure all slices/subslices are ON before writing to NOA
@@ -2579,6 +2585,9 @@ static void gen12_disable_metric_set(struct i915_perf_stream *stream)/* Make sure we disable noa to save power. */ intel_uncore_rmw (uncore,RPM_CONFIG1 ,GEN10_GT_NOA_ENABLE ,0 ); + +/* Reset PMON Enable to save power. */ +intel_uncore_rmw (uncore,GEN12_SQCNT1 ,GEN12_SQCNT1_PMON_ENABLE ,0 ); }static void gen7_oa_enable (struct i915_perf_stream *stream)
drivers/gpu/drm/i915/i915_reg.h +2 -0
@@ -696,6 +696,8 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define OABUFFER_SIZE_16M (7 << 3)#define GEN12_OA_TLB_INV_CR _MMIO(0xceec) +#define GEN12_SQCNT1 _MMIO(0x8718) +#define GEN12_SQCNT1_PMON_ENABLE REG_BIT(30)/* Gen12 OAR unit */ #define GEN12_OAR_OACONTROL _MMIO(0x2960)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/6 drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock
In reply to Umesh Nerlige RamappaRefactor intel_engine_apply_whitelist into locked and unlocked versions so that a caller who already has the lock can apply whitelist.
v2: Fix sparse warning
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 44 +++++++++++++++------ 1 file changed, 31 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +31 -13
@@ -1295,7 +1295,8 @@ void intel_gt_init_workarounds(struct drm_i915_private *i915) }static enum forcewake_domains -wal_get_fw_for_rmw (struct intel_uncore *uncore,const struct i915_wa_list *wal) +wal_get_fw (struct intel_uncore *uncore,const struct i915_wa_list *wal, +unsigned int op) {enum forcewake_domains fw =0 ;struct i915_wa *wa;
@@ -1304,8 +1305,7 @@ wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)for (i =0 , wa = wal->list; i < wal->count; i++, wa++) fw |=intel_uncore_forcewake_for_reg (uncore, wa->reg, -FW_REG_READ | -FW_REG_WRITE ); + op);return fw; }
@@ -1335,7 +1335,7 @@ wa_list_apply(struct intel_uncore *uncore, const struct i915_wa_list *wal)if (!wal->count)return ; - fw =wal_get_fw_for_rmw (uncore, wal); + fw =wal_get_fw (uncore, wal,FW_REG_READ |FW_REG_WRITE );spin_lock_irqsave (&uncore->lock, flags);intel_uncore_forcewake_get__locked (uncore, fw);
@@ -1645,27 +1645,45 @@ void intel_engine_init_whitelist(struct intel_engine_cs *engine)wa_init_finish (w); } -void intel_engine_apply_whitelist (struct intel_engine_cs *engine) +static void intel_engine_apply_whitelist_locked (struct intel_engine_cs *engine) {const struct i915_wa_list *wal = &engine->whitelist;struct intel_uncore *uncore = engine->uncore;const u32 base = engine->mmio_base;struct i915_wa *wa;unsigned int i; +enum forcewake_domains fw; -if (!wal->count) -return ; +lockdep_assert_held (&uncore->lock); + + fw =wal_get_fw (uncore, wal,FW_REG_WRITE ); +intel_uncore_forcewake_get__locked (uncore, fw);for (i =0 , wa = wal->list; i < wal->count; i++, wa++) -intel_uncore_write (uncore, -RING_FORCE_TO_NONPRIV (base, i), -i915_mmio_reg_offset (wa->reg)); +intel_uncore_write_fw (uncore, +RING_FORCE_TO_NONPRIV (base, i), +i915_mmio_reg_offset (wa->reg));/* And clear the rest just in case of garbage */ for (; i <RING_MAX_NONPRIV_SLOTS ; i++) -intel_uncore_write (uncore, -RING_FORCE_TO_NONPRIV (base, i), -i915_mmio_reg_offset (RING_NOPID (base))); +intel_uncore_write_fw (uncore, +RING_FORCE_TO_NONPRIV (base, i), +i915_mmio_reg_offset (RING_NOPID (base))); + +intel_uncore_forcewake_put__locked (uncore, fw); +} + +void intel_engine_apply_whitelist (struct intel_engine_cs *engine) +{ +unsigned long flags; +const struct i915_wa_list *wal = &engine->whitelist; + +if (!wal->count) +return ; + +spin_lock_irqsave (&engine->uncore->lock, flags); +intel_engine_apply_whitelist_locked (engine); +spin_unlock_irqrestore (&engine->uncore->lock, flags); } static void
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/6] drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock
Quoting Umesh Nerlige Ramappa (2020-10-10 01:21:01)
Quoted 44 lines
Refactor
intel_engine_apply_whitelistinto locked and unlocked versions so that a caller who already has the lock can apply whitelist.v2: Fix sparse warning
Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 44 +++++++++++++++------ 1 file changed, 31 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/gt/intel_workarounds.c +4
-4@@ -1295,7 +1295,8 @@ void intel_gt_init_workarounds(struct drm_i915_private *i915) }static enum forcewake_domains -wal_get_fw_for_rmw (struct intel_uncore *uncore,const struct i915_wa_list *wal) +wal_get_fw (struct intel_uncore *uncore,const struct i915_wa_list *wal, +unsigned int op) {enum forcewake_domains fw =0 ;struct i915_wa *wa;@@ -1304,8 +1305,7 @@ wal_get_fw_for_rmw(struct intel_uncore *uncore, const struct i915_wa_list *wal)for (i =0 , wa = wal->list; i < wal->count; i++, wa++) fw |=intel_uncore_forcewake_for_reg (uncore, wa->reg, -FW_REG_READ | -FW_REG_WRITE ); + op);return fw; }@@ -1335,7 +1335,7 @@ wa_list_apply(struct intel_uncore *uncore, const struct i915_wa_list *wal)if (!wal->count)return ; - fw =wal_get_fw_for_rmw (uncore, wal); + fw =wal_get_fw (uncore, wal,FW_REG_READ |FW_REG_WRITE );spin_lock_irqsave (&uncore->lock, flags);intel_uncore_forcewake_get__locked (uncore, fw);
drivers/gpu/drm/i915/gt/intel_workarounds.c void intel_engine_init_whitelist(struct intel_engine_cs *engine) · line 1648
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +1
-1@@ -1645,27 +1645,45 @@ void intel_engine_init_whitelist(struct intel_engine_cs *engine)wa_init_finish (w); } -void intel_engine_apply_whitelist (struct intel_engine_cs *engine) +static void intel_engine_apply_whitelist_locked (struct intel_engine_cs *engine)
Not too bad, but since it remains static, we could drop the prefix (and suffix):
__engine_apply_whitelist(engine, wal)
drivers/gpu/drm/i915/gt/intel_workarounds.c void intel_engine_init_whitelist(struct intel_engine_cs *engine) · line 1655
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +1
-0{const struct i915_wa_list *wal = &engine->whitelist;struct intel_uncore *uncore = engine->uncore;const u32 base = engine->mmio_base;struct i915_wa *wa;unsigned int i; +enum forcewake_domains fw;
(Christmas tree)
Quoted 22 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +8
-8-if (!wal->count) -return ; +lockdep_assert_held (&uncore->lock); + + fw =wal_get_fw (uncore, wal,FW_REG_WRITE ); +intel_uncore_forcewake_get__locked (uncore, fw);for (i =0 , wa = wal->list; i < wal->count; i++, wa++) -intel_uncore_write (uncore, -RING_FORCE_TO_NONPRIV (base, i), -i915_mmio_reg_offset (wa->reg)); +intel_uncore_write_fw (uncore, +RING_FORCE_TO_NONPRIV (base, i), +i915_mmio_reg_offset (wa->reg));/* And clear the rest just in case of garbage */ for (; i <RING_MAX_NONPRIV_SLOTS ; i++) -intel_uncore_write (uncore, -RING_FORCE_TO_NONPRIV (base, i), -i915_mmio_reg_offset (RING_NOPID (base))); + intel_uncore_write_fw(uncore,
drivers/gpu/drm/i915/gt/intel_workarounds.c void intel_engine_init_whitelist(struct intel_engine_cs *engine) · line 1679
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +10
-0+RING_FORCE_TO_NONPRIV (base, i), + i915_mmio_reg_offset(RING_NOPID(base))); + +intel_uncore_forcewake_put__locked (uncore, fw); +} + +void intel_engine_apply_whitelist (struct intel_engine_cs *engine) +{ +unsigned long flags; +const struct i915_wa_list *wal = &engine->whitelist;
Longest to shortest variable declaration (if no other reason prevents that).
-Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/6 drm/i915/perf: Whitelist OA report trigger registers
In reply to Umesh Nerlige RamappaOA reports can be triggered into the OA buffer by writing into the OAREPORTTRIG registers. Whitelist the registers to allow non-privileged user to trigger reports.
Whitelist registers only if perf_stream_paranoid is set to 0. In i915_perf_open_ioctl, this setting is checked and the whitelist is enabled accordingly. On closing the perf fd, the whitelist is removed.
This ensures that the access to the whitelist is gated by perf_stream_paranoid.
v2:
- Move related change to this patch (Lionel)
- Bump up perf revision (Lionel)
v3: Pardon whitelisted registers for selftest (Umesh)
v4: Document supported gens for the feature (Lionel)
v5: Whitelist registers only if perf_stream_paranoid is set to 0 (Jon)
v6: Move oa whitelist array to i915_perf (Chris)
v7: Fix OA writing beyond the wal->list memory (CI)
v8: Protect write to engine whitelist registers
v9: (Umesh)
- Use uncore->lock to protect write to forcepriv regs
- In case wal->count falls to zero on _wa_remove, make sure you still clear the registers. Remove wal->count check when applying whitelist.
v10: (Umesh)
- Split patches modifying intel_workarounds
- On some platforms there are no whitelisted regs. intel_engine_resume applies whitelist on these platforms too and the wal->count gates such platforms. Bring back the wal->count check.
- intel_engine_allow/deny_user_register_access modifies the engine whitelist and the wal->count. Use uncore->lock to serialize it with intel_engine_apply_whitelist.
- Grow the wal->list when adding whitelist registers after driver load.
v11: Fix checkpatch errors
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 118 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_workarounds.h | 7 ++ .../gpu/drm/i915/gt/intel_workarounds_types.h | 5 + drivers/gpu/drm/i915/i915_perf.c | 79 +++++++++++- drivers/gpu/drm/i915/i915_perf_types.h | 8 ++ 5 files changed, 214 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +118 -0
@@ -112,6 +112,66 @@ static void wa_init_finish(struct i915_wa_list *wal) wal->wa_count, wal->name, wal->engine_name); } +static int _wa_index (struct i915_wa_list *wal,i915_reg_t reg) +{ +unsigned int addr =i915_mmio_reg_offset (reg); +int start =0 , end = wal->count; + +/* addr and wal->list[].reg, both include the R/W flags */ +while (start < end) { +unsigned int mid = start + (end - start) /2 ; + +if (i915_mmio_reg_offset (wal->list[mid].reg) < addr) + start = mid +1 ; +else if (i915_mmio_reg_offset (wal->list[mid].reg) > addr) + end = mid; +else +return mid; + } + +return -ENOENT ; +} + +static int _wa_list_grow (struct i915_wa_list *wal,size_t count) +{ +struct i915_wa *list; + + list =kmalloc_array (ALIGN (count +1 ,WA_LIST_CHUNK ),sizeof (*list), +GFP_KERNEL ); +if (!list) { +DRM_ERROR ("No space for workaround init!\n" ); +return -ENOMEM ; + } + +if (wal->list) +memcpy (list, wal->list,sizeof (*list) * count); + + wal->list = list; + +return 0 ; +} + +static void _wa_remove (struct i915_wa_list *wal,i915_reg_t reg,u32 flags) +{ +int index; +struct i915_wa *wa = wal->list; + + reg.reg |= flags; + + index =_wa_index (wal, reg); +if (GEM_DEBUG_WARN_ON (index <0 )) +return ; + +memset (wa + index,0 ,sizeof (*wa)); + +while (index < wal->count -1 ) { +swap (wa[index], wa[index +1 ]); + index++; + } + + wal->count--; +} +static void _wa_add (struct i915_wa_list *wal,const struct i915_wa *wa) {unsigned int addr =i915_mmio_reg_offset (wa->reg);
@@ -2011,6 +2071,64 @@ void intel_engine_init_workarounds(struct intel_engine_cs *engine)wa_init_finish (wal); } +int intel_engine_allow_user_register_access (struct intel_engine_cs *engine, +struct i915_whitelist_reg *reg, +u32 count) +{ +unsigned long flags; +struct i915_wa_list *wal; +int ret; + +if (!engine || !reg || !count) +return -EINVAL ; + + wal = &engine->whitelist; + +/* +* i915 compacts the wa list by calling wa_init_finish during driver +* load. If we want to add additional workarounds after driver load, +* we need to grow the list. _wa_list_grow will add at least one free +* slot for a workaround. Any additional slot required are added by +* _wa_add in the below for loop. +* +* Once we remove the workarounds, we compact the list again in +* intel_engine_deny_user_register_access by calling wa_init_finish. +*/ + ret =_wa_list_grow (wal, wal->count); +if (ret <0 ) +return ret; + +spin_lock_irqsave (&engine->uncore->lock, flags); +for (; count--; reg++) +whitelist_reg_ext (wal, reg->reg, reg->flags); + +intel_engine_apply_whitelist_locked (engine); +spin_unlock_irqrestore (&engine->uncore->lock, flags); + +return 0 ; +} + +void intel_engine_deny_user_register_access (struct intel_engine_cs *engine, +struct i915_whitelist_reg *reg, +u32 count) +{ +unsigned long flags; +struct i915_wa_list *wal; + +if (!engine || !reg || !count) +return ; + + wal = &engine->whitelist; +spin_lock_irqsave (&engine->uncore->lock, flags); +for (; count--; reg++) +_wa_remove (wal, reg->reg, reg->flags); + +intel_engine_apply_whitelist_locked (engine); +spin_unlock_irqrestore (&engine->uncore->lock, flags); + +wa_init_finish (wal); +} +void intel_engine_apply_workarounds (struct intel_engine_cs *engine) {wa_list_apply (engine->uncore, &engine->wa_list);
drivers/gpu/drm/i915/gt/intel_workarounds.h +7 -0
@@ -37,4 +37,11 @@ void intel_engine_apply_workarounds(struct intel_engine_cs *engine);int intel_engine_verify_workarounds (struct intel_engine_cs *engine,const char *from); +int intel_engine_allow_user_register_access (struct intel_engine_cs *engine, +struct i915_whitelist_reg *reg, +u32 count); +void intel_engine_deny_user_register_access (struct intel_engine_cs *engine, +struct i915_whitelist_reg *reg, +u32 count); +#endif
drivers/gpu/drm/i915/gt/intel_workarounds_types.h +5 -0
@@ -11,6 +11,11 @@#include "i915_reg.h" +struct i915_whitelist_reg { +i915_reg_t reg; +u32 flags; +}; +struct i915_wa {i915_reg_t reg;u32 clr;
drivers/gpu/drm/i915/i915_perf.c +76 -3
134 lines not on this page · raw message
drivers/gpu/drm/i915/i915_perf_types.h +8 -0
@@ -311,6 +311,11 @@ struct i915_perf_stream {* buffer should be checked for available data. */ u64 poll_oa_period; + +/** +* @oa_whitelisted: Indicates that the oa registers are whitelisted. +*/ +bool oa_whitelisted; };/**
@@ -431,6 +436,9 @@ struct i915_perf {u32 ctx_oactxctrl_offset;u32 ctx_flexeu0_offset; +struct i915_whitelist_reg *oa_wl; +size_t num_oa_wl; +/** * The RPT_ID/reason field for Gen8+ includes a bit * to determine if the CTX ID in the report is valid
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/6 drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow
In reply to Umesh Nerlige RamappaSwitch the search and grow code of the _wa_add to use _wa_index and _wa_list_grow.
--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 54 +++++++-------------- 1 file changed, 17 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +17 -37
@@ -174,53 +174,33 @@ static void _wa_remove(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)static void _wa_add (struct i915_wa_list *wal,const struct i915_wa *wa) { -unsigned int addr =i915_mmio_reg_offset (wa->reg); -unsigned int start =0 , end = wal->count; +int index;const unsigned int grow =WA_LIST_CHUNK ;struct i915_wa *wa_;GEM_BUG_ON (!is_power_of_2 (grow)); -if (IS_ALIGNED (wal->count, grow)) {/* Either uninitialized or full. */ -struct i915_wa *list; - - list =kmalloc_array (ALIGN (wal->count +1 , grow),sizeof (*wa), -GFP_KERNEL ); -if (!list) { -DRM_ERROR ("No space for workaround init!\n" ); +if (IS_ALIGNED (wal->count, grow))/* Either uninitialized or full. */ +if (_wa_list_grow (wal, wal->count) <0 )return ; - } - -if (wal->list) -memcpy (list, wal->list,sizeof (*wa) * wal->count); - wal->list = list; - } + index =_wa_index (wal, wa->reg); +if (index >=0 ) { + wa_ = &wal->list[index]; -while (start < end) { -unsigned int mid = start + (end - start) /2 ; +if ((wa->clr | wa_->clr) && !(wa->clr & ~wa_->clr)) { +DRM_ERROR ("Discarding overwritten w/a for reg %04x (clear: %08x, set: %08x)\n" , +i915_mmio_reg_offset (wa_->reg), + wa_->clr, wa_->set); -if (i915_mmio_reg_offset (wal->list[mid].reg) < addr) { - start = mid +1 ; - }else if (i915_mmio_reg_offset (wal->list[mid].reg) > addr) { - end = mid; - }else { - wa_ = &wal->list[mid]; - -if ((wa->clr | wa_->clr) && !(wa->clr & ~wa_->clr)) { -DRM_ERROR ("Discarding overwritten w/a for reg %04x (clear: %08x, set: %08x)\n" , -i915_mmio_reg_offset (wa_->reg), - wa_->clr, wa_->set); - - wa_->set &= ~wa->clr; - } - - wal->wa_count++; - wa_->set |= wa->set; - wa_->clr |= wa->clr; - wa_->read |= wa->read; -return ; + wa_->set &= ~wa->clr; } + + wal->wa_count++; + wa_->set |= wa->set; + wa_->clr |= wa->clr; + wa_->read |= wa->read; +return ; } wal->wa_count++;
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/6] drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow
Quoting Umesh Nerlige Ramappa (2020-10-10 01:21:03)
Quoted 30 lines
Switch the search and grow code of the
_wa_addto use_wa_indexand_wa_list_grow.Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 54 +++++++-------------- 1 file changed, 17 insertions(+), 37 deletions(-)drivers/gpu/drm/i915/gt/intel_workarounds.c +1
-8@@ -174,53 +174,33 @@ static void _wa_remove(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)static void _wa_add (struct i915_wa_list *wal,const struct i915_wa *wa) { -unsigned int addr =i915_mmio_reg_offset (wa->reg); -unsigned int start =0 , end = wal->count; +int index;const unsigned int grow =WA_LIST_CHUNK ;struct i915_wa *wa_;GEM_BUG_ON (!is_power_of_2 (grow)); -if (IS_ALIGNED (wal->count, grow)) {/* Either uninitialized or full. */ -struct i915_wa *list; - - list =kmalloc_array (ALIGN (wal->count +1 , grow),sizeof (*wa), -GFP_KERNEL ); -if (!list) {
drivers/gpu/drm/i915/gt/intel_workarounds.c static void _wa_remove(struct i915_wa_list *wal, i915_reg_t reg, u32 flags) · line 197
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +2
-6-DRM_ERROR ("No space for workaround init!\n" ); +if (IS_ALIGNED (wal->count, grow))/* Either uninitialized or full. */ +if (_wa_list_grow (wal, wal->count) <0 )return ; - } - -if (wal->list) -memcpy (list, wal->list,sizeof (*wa) * wal->count); - wal->list = list;
An inherited problem, but I'm a little unnerved by the apparent leak of wa->list here.
Paging Tvrtko to see if he can remember if there's a hidden trick. -Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/6] drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow
Quoted 40 lines · Chris Wilson
Quoting Umesh Nerlige Ramappa (2020-10-10 01:21:03)
Quoted 39 lines
Switch the search and grow code of the
_wa_addto use_wa_indexand_wa_list_grow.Signed-off-by Umesh Nerlige Ramappa <[email protected]>--- drivers/gpu/drm/i915/gt/intel_workarounds.c | 54 +++++++-------------- 1 file changed, 17 insertions(+), 37 deletions(-)drivers/gpu/drm/i915/gt/intel_workarounds.c +3
-13@@ -174,53 +174,33 @@ static void _wa_remove(struct i915_wa_list *wal, i915_reg_t reg, u32 flags)static void _wa_add (struct i915_wa_list *wal,const struct i915_wa *wa) { -unsigned int addr =i915_mmio_reg_offset (wa->reg); -unsigned int start =0 , end = wal->count; +int index;const unsigned int grow =WA_LIST_CHUNK ;struct i915_wa *wa_;GEM_BUG_ON (!is_power_of_2 (grow)); -if (IS_ALIGNED (wal->count, grow)) {/* Either uninitialized or full. */ -struct i915_wa *list; - - list =kmalloc_array (ALIGN (wal->count +1 , grow),sizeof (*wa), -GFP_KERNEL ); -if (!list) { -DRM_ERROR ("No space for workaround init!\n" ); +if (IS_ALIGNED (wal->count, grow))/* Either uninitialized or full. */ +if (_wa_list_grow (wal, wal->count) <0 )return ; - } - -if (wal->list) -memcpy (list, wal->list,sizeof (*wa) * wal->count);
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c static void _wa_remove(struct i915_wa_list *wal, i915_reg_t reg, u32 flags) · line 197
Quoted 1 line
drivers/gpu/drm/i915/gt/intel_workarounds.c +0
-1- wal->list = list;An inherited problem, but I'm a little unnerved by the apparent leak of
wa->listhere.Paging Tvrtko to see if he can remember if there's a hidden trick.
I don't see any tricks, just a memory leak for all lists with more than 16 unique registers on the wa list. :(
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/6] drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow
Quoting Tvrtko Ursulin (2020-11-13 10:40:07)
Quoted 10 lines · Chris Wilson
Quoted 5 lines
Quoting Umesh Nerlige Ramappa (2020-10-10 01:21:03)
An inherited problem, but I'm a little unnerved by the apparent leak ofwa->listhere.Paging Tvrtko to see if he can remember if there's a hidden trick.
I don't see any tricks, just a memory leak for all lists with more than 16 unique registers on the wa list. :(
As I read it, since each pair of perf open/close will cause us to reallocate the lists, we need to address this leak first before it becomes user controllable. Apologies for yet another delay. -Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/6 drm/i915/perf: Whitelist OA counter and buffer registers
In reply to Umesh Nerlige RamappaIt is useful to have markers in the OA reports to identify triggered reports. Whitelist some OA counters that can be used as markers.
A triggered report can be found faster if we can sample the HW tail and head registers when the report was triggered. Whitelist OA buffer specific registers.
v2:
- Bump up the perf revision (Lionel)
- Use indexing for counters (Lionel)
- Fix selftest for oa ticking register (Umesh)
v3: Pardon whitelisted registers for selftest (Umesh)
v4:
- Document whitelisted registers (Lionel)
- Fix live isolated whitelist for OA regs (Umesh)
v5:
- Free up whitelist slots. Remove GPU_TICKS and A20 counter (Piotr)
- Whitelist registers only if perf_stream_paranoid is set to 0 (Jon)
v6: Move oa whitelist array to i915_perf (Chris)
--- drivers/gpu/drm/i915/i915_perf.c | 18 +++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 8 ++++++++ 2 files changed, 25 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_perf.c +17 -1
@@ -1365,11 +1365,19 @@ free_noa_wait(struct i915_perf_stream *stream)static struct i915_whitelist_reg gen9_oa_wl_regs[] = { {OAREPORTTRIG2 ,RING_FORCE_TO_NONPRIV_ACCESS_RW }, {OAREPORTTRIG6 ,RING_FORCE_TO_NONPRIV_ACCESS_RW }, + {OA_PERF_COUNTER_A (18 ),RING_FORCE_TO_NONPRIV_ACCESS_RW | +RING_FORCE_TO_NONPRIV_RANGE_4 }, + {GEN8_OASTATUS ,RING_FORCE_TO_NONPRIV_ACCESS_RD | +RING_FORCE_TO_NONPRIV_RANGE_4 }, };static struct i915_whitelist_reg gen12_oa_wl_regs[] = { {GEN12_OAG_OAREPORTTRIG2 ,RING_FORCE_TO_NONPRIV_ACCESS_RW }, {GEN12_OAG_OAREPORTTRIG6 ,RING_FORCE_TO_NONPRIV_ACCESS_RW }, + {GEN12_OAG_PERF_COUNTER_A (18 ),RING_FORCE_TO_NONPRIV_ACCESS_RW | +RING_FORCE_TO_NONPRIV_RANGE_4 }, + {GEN12_OAG_OASTATUS ,RING_FORCE_TO_NONPRIV_ACCESS_RD | +RING_FORCE_TO_NONPRIV_RANGE_4 }, };static int intel_engine_apply_oa_whitelist (struct i915_perf_stream *stream)
@@ -4541,8 +4549,16 @@ int i915_perf_ioctl_version(void)* into the OA buffer. This applies only to gen8+. The feature can * only be accessed if perf_stream_paranoid is set to 0 by privileged * user. +* +* 7: Whitelist below OA registers for user to identify the location of +* triggered reports in the OA buffer. This applies only to gen8+. +* The feature can only be accessed if perf_stream_paranoid is set to +* 0 by privileged user. +* +* - OA buffer head/tail/status/buffer registers for read only +* - OA counters A18, A19, A20 for read/write */ -return 6 ; +return 7 ; }#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )
drivers/gpu/drm/i915/i915_reg.h +8 -0
@@ -974,6 +974,14 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define OAREPORTTRIG8_NOA_SELECT_6_SHIFT 24#define OAREPORTTRIG8_NOA_SELECT_7_SHIFT 28 +/* Performance counters registers */ +#define OA_PERF_COUNTER_A (idx) _MMIO(0x2800 + 8 * (idx)) +#define OA_PERF_COUNTER_A_UPPER (idx) _MMIO(0x2800 + 8 * (idx) + 4) + +/* Gen12 Performance counters registers */ +#define GEN12_OAG_PERF_COUNTER_A (idx) _MMIO(0xD980 + 8 * (idx)) +#define GEN12_OAG_PERF_COUNTER_A_UPPER (idx) _MMIO(0xD980 + 8 * (idx) + 4) +/* Same layout as OASTARTTRIGX */ #define GEN12_OAG_OASTARTTRIG1 _MMIO(0xd900)#define GEN12_OAG_OASTARTTRIG2 _MMIO(0xd904)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/6 drm/i915/perf: Map OA buffer to user space for gen12 performance query
In reply to Umesh Nerlige Ramappai915 used to support time based sampling mode which is good for overall system monitoring, but is not enough for query mode used to measure a single draw call or dispatch. Gen9-Gen11 are using current i915 perf implementation for query, but Gen12+ requires a new approach for query based on triggered reports within oa buffer.
Triggering reports into the OA buffer is achieved by writing into a a trigger register. Optionally an unused counter/register is set with a marker value such that a triggered report can be identified in the OA buffer. Reports are usually triggered at the start and end of work that is measured.
Since OA buffer is large and queries can be frequent, an efficient way to look for triggered reports is required. By knowing the current head and tail offsets into the OA buffer, it is easier to determine the locality of the reports of interest.
Current perf OA interface does not expose head/tail information to the user and it filters out invalid reports before sending data to user. Also considering limited size of user buffer used during a query, creating a 1:1 copy of the OA buffer at the user space added undesired complexity.
The solution was to map the OA buffer to user space provided
(1) that it is accessed from a privileged user.
(2) OA report filtering is not used.
These 2 conditions would satisfy the safety criteria that the current perf interface addresses.
To enable the query:
- Add an ioctl to expose head and tail to the user
- Add an ioctl to return size and offset of the OA buffer
- Map the OA buffer to the user space
v2:
- Improve commit message (Chris)
- Do not mmap based on gem object filp. Instead, use perf_fd and support mmap syscall (Chris)
- Pass non-zero offset in mmap to enforce the right object is mapped (Chris)
- Do not expose gpu_address (Chris)
- Verify start and length of vma for page alignment (Lionel)
- Move SQNTL config out (Lionel)
v3: (Chris)
- Omit redundant checks
- Return VM_FAULT_SIGBUS is old stream is closed
- Maintain reference counts to stream in vm_open and vm_close
- Use switch to identify object to be mapped
v4: Call kref_put on closing perf fd (Chris)
v5:
- Strip access to OA buffer from unprivileged child of a privileged parent. Use VM_DONTCOPY
- Enforce MAP_PRIVATE by checking for VM_MAYSHARE
v6:
(Chris)
- Use len of -1 in unmap_mapping_range
- Don't use stream->oa_buffer.vma->obj in vm_fault_oa
- Use kernel block comment style
- do_mmap gets a reference to the file and puts it in do_munmap, so no need to maintain a reference to i915_perf_stream. Hence, remove vm_open/vm_close and stream->closed hooks/checks.
(Umesh)
- Do not allow mmap if SAMPLE_OA_REPORT is not set during i915_perf_open_ioctl.
- Drop ioctl returning head/tail since this information is already whitelisted. Remove hooks to read head register.
v7: (Chris)
- unmap before destroy
- change ioctl argument struct
v8: Documentation and more checks (Chris)
--- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + drivers/gpu/drm/i915/i915_perf.c | 126 ++++++++++++++++++++++- include/uapi/drm/i915_drm.h | 33 ++++++ 4 files changed, 161 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +1 -1
@@ -204,7 +204,7 @@ compute_partial_view(const struct drm_i915_gem_object *obj,return view; } -static vm_fault_t i915_error_to_vmf_fault (int err) +vm_fault_t i915_error_to_vmf_fault (int err) {switch (err) {default :
drivers/gpu/drm/i915/gem/i915_gem_mman.h +2 -0
@@ -29,4 +29,6 @@ void i915_gem_object_release_mmap_gtt(struct drm_i915_gem_object *obj);void i915_gem_object_release_mmap_offset (struct drm_i915_gem_object *obj); +vm_fault_t i915_error_to_vmf_fault (int err); +#endif
drivers/gpu/drm/i915/i915_perf.c +125 -1
173 lines not on this page · raw message
include/uapi/drm/i915_drm.h +33 -0
@@ -2101,6 +2101,39 @@ struct drm_i915_perf_open_param {*/ #define I915_PERF_IOCTL_CONFIG _IO('i', 0x2) +/** +* Returns OA buffer properties to be used with mmap. +* +* This ioctl is available in perf revision 8. +*/ +#define I915_PERF_IOCTL_GET_OA_BUFFER_INFO _IOWR('i', 0x3, struct drm_i915_perf_oa_buffer_info) + +/** +* OA buffer size and offset. +* +* OA output buffer +* type: 0 +* flags: mbz +* +* After querying the info, pass (size,offset) to mmap(), +* +* mmap(0, info.size, PROT_READ, MAP_PRIVATE, perf_fd, info.offset). +* +* Note that only a private (not shared between processes, or across fork()) +* read-only mmapping is allowed. +* +* Userspace must treat the incoming data as tainted, but it conforms to the OA +* format as specified by user config. The buffer provides reports that have +* OA counters - A, B and C. +*/ +struct drm_i915_perf_oa_buffer_info { +__u32 type;/* in */ +__u32 flags;/* in */ +__u64 size;/* out */ +__u64 offset;/* out */ +__u64 rsvd;/* mbz */ +}; +/** * Common to all i915 perf records */
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for Allow privileged user to map the OA buffer
In reply to Umesh Nerlige Ramappa== Series Details ==
== Series Details ==
Series: Allow privileged user to map the OA buffer
URL : https://patchwork.freedesktop.org/series/82532/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9123 -> Patchwork_18671
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18671 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18671, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18671:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-bdw-5557u: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html
Known issues
------------
Here are the changes found in Patchwork_18671 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-icl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-icl-u2/igt@[email protected]
* igt@vgem_basic@unload:
- fi-kbl-x1275: [PASS][5] -> [DMESG-WARN][6] ([i915#62] / [i915#92] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-kbl-x1275/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-kbl-x1275/igt@[email protected]
#### Possible fixes ####
* {igt@core_hotunplug@unbind-rebind}:
- fi-kbl-x1275: [DMESG-WARN][7] ([i915#62] / [i915#92]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-kbl-x1275/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-kbl-x1275/igt@kms_busy@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-bsw-n3050/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-bsw-n3050/igt@[email protected]
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-bsw-kefka/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-bsw-kefka/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-icl-u2/igt@[email protected]
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][17] ([i915#2203]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-skl-guc/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-skl-guc/igt@[email protected]
#### Warnings ####
* igt@debugfs_test@read_all_entries:
- fi-skl-6700k2: [{ABORT}][19] ([i915#1814]) -> [DMESG-WARN][20] ([i915#2203])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-skl-6700k2/igt@debugfs_test@read_all_entries.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][22] ([i915#62] / [i915#92]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-kbl-x1275/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-kbl-x1275/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-kbl-x1275/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92]) -> [DMESG-WARN][26] ([i915#1982] / [i915#62] / [i915#92] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9123/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 38)
------------------------------
Missing (7): fi-ilk-m540 fi-tgl-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper
Build changes
-------------
* IGT: IGT_5807 -> IGTPW_5038
* Linux: CI_DRM_9123 -> Patchwork_18671
CI-20190529: 20190529
CI_DRM_9123: ceff802db76def8e8689580b74df01db3722d8f9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5038: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5038/index.html
IGT_5807: 48005bda72a06669a73d26a7f6a3cdef4ac22689 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18671: 2e14c57631d2251e2522397865c1aaf2b0cab9bf @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2e14c57631d2 drm/i915/perf: Map OA buffer to user space for gen12 performance query 85bc094387a4 drm/i915/perf: Whitelist OA counter and buffer registers 7bc7f4fa6893 drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow 3afb7b328394 drm/i915/perf: Whitelist OA report trigger registers 7f8eb66862ea drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock c7803a980197 drm/i915/perf: Ensure observation logic is not clock gated
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18671/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx