Skip to contentSkip to conversation

PWM backlight patches from 'Add DM support for omap PWM backlight' series

PATCH Superseded Dario Binacchi 2 participants 4 messages Oct 11, 2020 – Oct 19, 2020 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

cover PWM backlight patches from 'Add DM support for omap PWM backlight' series

As suggested by Grygorii Strashko I have removed these patches from the 'Add DM support for omap PWM backlight' series and grouped them into this one. One of the two patches has already been reviewed by Simon Glass.

Dario Binacchi (2):
video: backlight: fix pwm data structure description
video: backlight: fix pwm's duty cycle calculation

 drivers/video/pwm_backlight.c |  4 ++--
 test/dm/panel.c               | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 video: backlight: fix pwm data structure description

The description of the 'max_level' field was incorrectly assigned to the 'min_level' field.

---

 drivers/video/pwm_backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/pwm_backlight.c +1 -1
index 468a5703bd..acfde7ba3d 100644
@@ -33,7 +33,7 @@
  * @cur_level: Current level for the backlight (index or value)
  * @default_level: Default level for the backlight (index or value)
  * @min_level: Minimum level of the backlight (full off)
- * @min_level: Maximum level of the backlight (full on)
+ * @max_level: Maximum level of the backlight (full on)
  * @enabled: true if backlight is enabled
  */
 struct pwm_backlight_priv {
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 video: backlight: fix pwm's duty cycle calculation

In reply to Dario Binacchi

For levels equal to the maximum value, the duty cycle must be equal to the period.

---

 drivers/video/pwm_backlight.c |  2 +-
 test/dm/panel.c               | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)
drivers/video/pwm_backlight.c +1 -1
index acfde7ba3d..9519180ceb 100644
@@ -63,7 +63,7 @@ static int set_pwm(struct pwm_backlight_priv *priv)
 	int ret;
 
 	duty_cycle = priv->period_ns * (priv->cur_level - priv->min_level) /
-		(priv->max_level - priv->min_level + 1);
+		(priv->max_level - priv->min_level);
 	ret = pwm_set_config(priv->pwm, priv->channel, priv->period_ns,
 			     duty_cycle);
 	if (ret)
test/dm/panel.c +6 -6
index a840fb4951..49f5ac7169 100644
@@ -40,7 +40,7 @@ static int dm_test_panel(struct unit_test_state *uts)
 	ut_assertok(sandbox_pwm_get_config(pwm, 0, &period_ns, &duty_ns,
 					   &enable, &polarity));
 	ut_asserteq(1000, period_ns);
-	ut_asserteq(170 * 1000 / 256, duty_ns);
+	ut_asserteq(170 * 1000 / 255, duty_ns);
 	ut_asserteq(true, enable);
 	ut_asserteq(false, polarity);
 	ut_asserteq(1, sandbox_gpio_get_value(gpio, 1));
@@ -49,29 +49,29 @@ static int dm_test_panel(struct unit_test_state *uts)
 	ut_assertok(panel_set_backlight(dev, 40));
 	ut_assertok(sandbox_pwm_get_config(pwm, 0, &period_ns, &duty_ns,
 					   &enable, &polarity));
-	ut_asserteq(64 * 1000 / 256, duty_ns);
+	ut_asserteq(64 * 1000 / 255, duty_ns);
 
 	ut_assertok(panel_set_backlight(dev, BACKLIGHT_MAX));
 	ut_assertok(sandbox_pwm_get_config(pwm, 0, &period_ns, &duty_ns,
 					   &enable, &polarity));
-	ut_asserteq(255 * 1000 / 256, duty_ns);
+	ut_asserteq(255 * 1000 / 255, duty_ns);
 
 	ut_assertok(panel_set_backlight(dev, BACKLIGHT_MIN));
 	ut_assertok(sandbox_pwm_get_config(pwm, 0, &period_ns, &duty_ns,
 					   &enable, &polarity));
-	ut_asserteq(0 * 1000 / 256, duty_ns);
+	ut_asserteq(0 * 1000 / 255, duty_ns);
 	ut_asserteq(1, sandbox_gpio_get_value(gpio, 1));
 
 	ut_assertok(panel_set_backlight(dev, BACKLIGHT_DEFAULT));
 	ut_assertok(sandbox_pwm_get_config(pwm, 0, &period_ns, &duty_ns,
 					   &enable, &polarity));
 	ut_asserteq(true, enable);
-	ut_asserteq(170 * 1000 / 256, duty_ns);
+	ut_asserteq(170 * 1000 / 255, duty_ns);
 
 	ut_assertok(panel_set_backlight(dev, BACKLIGHT_OFF));
 	ut_assertok(sandbox_pwm_get_config(pwm, 0, &period_ns, &duty_ns,
 					   &enable, &polarity));
-	ut_asserteq(0 * 1000 / 256, duty_ns);
+	ut_asserteq(0 * 1000 / 255, duty_ns);
 	ut_asserteq(0, sandbox_gpio_get_value(gpio, 1));
 	ut_asserteq(false, regulator_get_enable(reg));
 
Signature · 1 line
2.17.1
#3 lore raw

cover PWM backlight patches from 'Add DM support for omap PWM backlight' series

In reply to Dario Binacchi

On Sun, 11 Oct 2020 14:28:02 +0200
Dario Binacchi dariobin at libero.it wrote:
...

Quoted 3 lines

Dario Binacchi (2):
video: backlight: fix pwm data structure description
video: backlight: fix pwm's duty cycle calculation

Series applied to u-boot-video/master, thanks!

--
Anatolij