Skip to contentSkip to conversation

nfsd: remove unneeded break

PATCH In review [email protected] 2 participants 2 messages Oct 11, 2020 – Oct 12, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: remove unneeded break

From: Tom Rix <[email protected]>

Because every path through nfs4_find_file()'s switch does an explicit return, the break is not needed.

---
 fs/nfsd/nfs4state.c | 1 -
 1 file changed, 1 deletion(-)
fs/nfsd/nfs4state.c +0 -1
index c09a2a4281ec..741f64672d96 100644
@@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
 			return find_readable_file(s->sc_file);
 		else
 			return find_writeable_file(s->sc_file);
-		break;
 	}
 
 	return NULL;
Signature · 1 line
2.18.1
#1 lore raw
Quoted 4 lines · On Sun, Oct 11, 2020 at 08:51:55AM -0700, [email protected] wrote:

From: Tom Rix <[email protected]>

Because every path through nfs4_find_file()'s switch does an explicit return, the break is not needed.

OK, applying.--b.

Quoted 20 lines
---
 fs/nfsd/nfs4state.c | 1 -
 1 file changed, 1 deletion(-)
fs/nfsd/nfs4state.c +0 -1
index c09a2a4281ec..741f64672d96 100644
@@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
 			return find_readable_file(s->sc_file);
 		else
 			return find_writeable_file(s->sc_file);
-		break;
 	}
 
 	return NULL;
Signature · 1 line
2.18.1