Skip to contentSkip to conversation

dt-bindings: sound: sun8i-a33-codec: Add Allwinner A64 codec compatible fallback

PATCH In review Clément Péron 2 participants 3 messages Oct 11, 2020 – Oct 12, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: sound: sun8i-a33-codec: Add Allwinner A64 codec compatible fallback

make dtbs_check report a warning because the documentation for the A64 codec compatible is missing.

The A64 codec compatible is actually a simple fallback to the A33.

Reflect this in the dt-bindings Documentation.

---
 .../bindings/sound/allwinner,sun8i-a33-codec.yaml           | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml +5 -1
index 55d28268d2f4..e78a22496e7c 100644
@@ -15,7 +15,11 @@ properties:
     const: 0
 
   compatible:
-    const: allwinner,sun8i-a33-codec
+    oneOf:
+      - const: allwinner,sun8i-a33-codec
+      - items:
+        - const: allwinner,sun50i-a64-codec
+        - const: allwinner,sun8i-a33-codec
 
   reg:
     maxItems: 1
Signature · 1 line
2.25.1
#1 lore raw

Hi!

Quoted 8 lines · Clément Péron

make dtbs_check report a warning because the documentation for the A64 codec compatible is missing.

The A64 codec compatible is actually a simple fallback to the A33.

Reflect this in the dt-bindings Documentation.

This patch is already in the ASoC tree and linux-next:

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml?id=cef305d4eb0733f25215793ed30b056a7db9bb62

Maxime

#2 lore raw

Hi Maxime and all,

Quoted 7 lines · Maxime Ripard

Hi!

Quoted 3 lines · Clément Péron

make dtbs_check report a warning because the documentation for the A64 codec compatible is missing.

Quoted 7 lines
Quoted 5 lines

The A64 codec compatible is actually a simple fallback to the A33.

Reflect this in the dt-bindings Documentation.

This patch is already in the ASoC tree and linux-next:

I was indeed on top of sunxi/for-next and not linux-next/master

I will test on top of linux-next for the next ones.

Sorry for the duplicate patch and the noise :(.
Clement

Quoted 4 lines

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml?id=cef305d4eb0733f25215793ed30b056a7db9bb62

Maxime