mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
Subsystems (2)
Vignesh Raghavendra
maintainerPATCH 1/1 mtd: hyperbus: Fix build failure when only RPCIF_HYPERBUS is enabled
commit 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leads to build failure[1] with COMPILE_TEST and RPCIF_HYPERBUS enabled. This is because driver needs functions RENESAS_RPCIF which is only buildable for CONFIG_ARCH_RENESAS.
Fix this by dropping COMPILE_TEST from RPCIF_HYPERBUS Kconfig entry. This ensures driver can be built only when RENESAS_RPCIF is also selected.
[1]:
rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
[...]
---
Based on mtd/next
Richard,
Could you please pull this into mtd/next?
drivers/mtd/hyperbus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/hyperbus/Kconfig +1 -1
@@ -24,7 +24,7 @@ config HBMC_AM654 config RPCIF_HYPERBUS tristate "Renesas RPC-IF HyperBus driver" - depends on RENESAS_RPCIF || COMPILE_TEST + depends on RENESAS_RPCIF depends on MTD_CFI_BE_BYTE_SWAP help This option includes Renesas RPC-IF HyperBus support.
Signature · 1 line
2.28.0
----- Ursprüngliche Mail -----
Quoted 26 lines
Von: "Vignesh Raghavendra" <[email protected]>
An: "Vignesh Raghavendra" <[email protected]>, "Miquel Raynal" <[email protected]>, "richard" <[email protected]>
CC: "Sergei Shtylyov" <[email protected]>, "linux-mtd" <[email protected]>, "linux-kernel" <[email protected]>
Gesendet: Montag, 12. Oktober 2020 09:09:58
Betreff: [PATCH] mtd: hyperbus: Fix build failure when onlyRPCIF_HYPERBUSis enabledcommit
5de15b610f78("mtd: hyperbus: add Renesas RPC-IF driver") leads to build failure[1] withCOMPILE_TESTandRPCIF_HYPERBUSenabled. This is because driver needs functionsRENESAS_RPCIFwhich is only buildable forCONFIG_ARCH_RENESAS.Fix this by dropping
COMPILE_TESTfromRPCIF_HYPERBUSKconfigentry. This ensures driver can be built only whenRENESAS_RPCIFis also selected.[1]:
rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm' ld:drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare' ld:drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
[...]Fixes 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") leadsReported-by Richard Weinberger <[email protected]>Signed-off-by Vignesh Raghavendra <[email protected]>
Quoted 7 lines
---
Based on mtd/next
Richard,
Could you please pull this into mtd/next?
Applied! :-)
Thanks,
//richard