Skip to contentSkip to conversation

Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE

PATCH New Patrick Delaunay 3 participants 3 messages Oct 12, 2020 – Oct 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE

Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB storage boot initialization is correctly managed by distro boot command ('usb_boot' defined in include/config_distro_bootcmd.h already include the command 'usb start').

Fixes 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")

---

 common/Kconfig.boot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/Kconfig.boot +1 -1
index 4191bfb34d..522f5f3d6a 100644
@@ -880,7 +880,7 @@ config USE_PREBOOT
 config PREBOOT
 	string "preboot default value"
 	depends on USE_PREBOOT && !USE_DEFAULT_ENV_FILE
-	default "usb start" if USB_KEYBOARD || USB_STORAGE
+	default "usb start" if USB_KEYBOARD
 	default ""
 	help
 	  This is the default of "preboot" environment variable.
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE

Quoted 6 lines · Patrick Delaunay

Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB storage boot initialization is correctly managed by distro boot command ('usb_boot' defined in include/config_distro_bootcmd.h already include the command 'usb start').

Quoted 7 lines
Fixes 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")

---

 common/Kconfig.boot | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#2 lore raw

PATCH 1/1 Remove default value of CONFIG_PREBOOT for CONFIG_USB_STORAGE

In reply to Patrick Delaunay
Quoted 8 lines · Patrick Delaunay

Remove the default value "usb start" for CONFIG_USB_STORAGE as the USB storage boot initialization is correctly managed by distro boot command ('usb_boot' defined in include/config_distro_bootcmd.h already include the command 'usb start').

Fixes 324d77998ed6 ("Define default CONFIG_PREBOOT with right config option")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201022/831ad1e7/attachment.sig>