Skip to contentSkip to conversation

media: platform: ti-vpe: Update the path to firmware

PATCH In review Nikhil Devshatwar 4 participants 8 messages Oct 12, 2020 – Oct 30, 2020 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: platform: ti-vpe: Update the path to firmware

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +1 -1
index 2e5148ae7a0f..5a378449a4ff 100644
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
 
 const struct vpdma_data_format vpdma_yuv_fmts[] = {
 	[VPDMA_DATA_FMT_Y444] = {
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Nikhil,

Thank you for the patch.

Quoted 8 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

Quoted 17 lines
---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +1 -1
index 2e5148ae7a0f..5a378449a4ff 100644
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"
 
 const struct vpdma_data_format vpdma_yuv_fmts[] = {
 	[VPDMA_DATA_FMT_Y444] = {
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
In reply to Nikhil Devshatwar
Quoted 17 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +0 -0
index 2e5148ae7a0f..5a378449a4ff 100644

drivers/media/platform/ti-vpe/vpdma.c line 26

Quoted 5 lines
drivers/media/platform/ti-vpe/vpdma.c +1 -1
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#3 lore raw
Quoted 21 lines · Tomi Valkeinen
Quoted 20 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +0 -0
index 2e5148ae7a0f..5a378449a4ff 100644
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
Quoted 5 lines

drivers/media/platform/ti-vpe/vpdma.c line 26

Quoted 2 lines
drivers/media/platform/ti-vpe/vpdma.c +1 -1
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

The firmware is already merged at ti-connectivity/
I didn't create a new folder because I felt the exising ti-connectivity is good enough.

Quoted 6 lines

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#4 lore raw
Quoted 28 lines · Nikhil Devshatwar
Quoted 21 lines · Tomi Valkeinen
Quoted 20 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +0 -0
index 2e5148ae7a0f..5a378449a4ff 100644
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
Quoted 5 lines

drivers/media/platform/ti-vpe/vpdma.c line 26

Quoted 2 lines
drivers/media/platform/ti-vpe/vpdma.c +1 -1
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

Quoted 3 lines

The firmware is already merged at ti-connectivity/
I didn't create a new folder because I felt the exising ti-connectivity is good enough.

ti-connectivity is for TI wlan, no? I think the fw should either be in the root dir, as that's where the driver has been loading it from for a long time, or if we're going to change the path in the driver, put it into a proper directory.

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#5 lore raw
Quoted 29 lines · Tomi Valkeinen
Quoted 28 lines · Nikhil Devshatwar
Quoted 26 lines · Tomi Valkeinen
Quoted 17 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +0 -0
index 2e5148ae7a0f..5a378449a4ff 100644

drivers/media/platform/ti-vpe/vpdma.c line 26

Quoted 5 lines
drivers/media/platform/ti-vpe/vpdma.c +1 -1
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

I don't think "ti-connectivity/" makes sense for vpdma fw. I don't know if there are guidelines for directories in linux-firmware, but "ti/vpdma-1b8.bin" would be better in my opinion.

Quoted 5 lines
Quoted 3 lines

The firmware is already merged at ti-connectivity/
I didn't create a new folder because I felt the exising ti-connectivity is good enough.

ti-connectivity is for TI wlan, no?

I didn't know that. I assumed all ti firmwares regarding connectivity go here :)
I am not sure if the linux-firmware accept moving firmware path. I can try posting the patch and see what's the feedback.

Quoted 9 lines

I think the fw should either be in the root dir, as that's where
the driver has been loading it from for a long time, or if we're going to change the path in the driver, put it into a proper directory.

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#6 lore raw
In reply to Nikhil Devshatwar

Hi Nikhil,

Quoted 17 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +0 -0
index 2e5148ae7a0f..5a378449a4ff 100644

drivers/media/platform/ti-vpe/vpdma.c line 26

Quoted 5 lines
drivers/media/platform/ti-vpe/vpdma.c +1 -1
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

Based on the discussion, this will change to ti/vpdma-1b8.bin, right? At least once linux-firmware has been updated.

I'll wait for a v2.

Regards,

Hans

Quoted 4 lines
drivers/media/platform/ti-vpe/vpdma.c +0 -0
 const struct vpdma_data_format vpdma_yuv_fmts[] = {
 	[VPDMA_DATA_FMT_Y444] = {
 
#7 lore raw
Quoted 23 lines · Hans Verkuil

Hi Nikhil,

Quoted 20 lines · Nikhil Devshatwar

vpdma firmware is now available in the linux-firmware repo.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity/vpdma-1b8.bin

Update the firmware path requested by the VPDMA driver so that it gets looked up correctly in the filesystem.

---
 drivers/media/platform/ti-vpe/vpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/ti-vpe/vpdma.c +0 -0
index 2e5148ae7a0f..5a378449a4ff 100644
@@ -23,7 +23,7 @@
 #include "vpdma.h"
 #include "vpdma_priv.h"
 
Quoted 7 lines

drivers/media/platform/ti-vpe/vpdma.c line 26

Quoted 2 lines
drivers/media/platform/ti-vpe/vpdma.c +1 -1
-#define VPDMA_FIRMWARE	"vpdma-1b8.bin"
+#define VPDMA_FIRMWARE	"ti-connectivity/vpdma-1b8.bin"

Based on the discussion, this will change to ti/vpdma-1b8.bin, right? At least once linux-firmware has been updated.

I'll wait for a v2.

Yes, please wait for v2. I think it'll be ti/vpdma-1b8.bin, or alternatively keep it as it is now (in the root).

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki