checkpatch: improve EXECUTE_PERMISSIONS tests
PATCH 1/1 checkpatch: improve EXECUTE_PERMISSIONS tests
1. Use group capture regexp for file mode test to improve code readability.
2. The 'scripts/' directory test on filenames can be excluded as it has become obsolete because there are many source files that are not scripts in this directory and its subdirectories.
3. Replace unnecessary group capture regexp with non-capturing group.
Suggested-by Joe Perches <[email protected]>
Signed-off-by Ujjwal Kumar <[email protected]>
--- scripts/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +4 -3
@@ -2678,10 +2678,11 @@ sub process { } # Check for incorrect file permissions - if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { + if ($line =~ /^new (?:file )?mode (\d+)$/) { + my $mode = substr($1, -3); my $permhere = $here . "FILE: $realfile\n"; - if ($realfile !~ m@scripts/@ && - $realfile !~ /\.(py|pl|awk|sh)$/) { + if ($mode =~ /[1357]/ && + $realfile !~ /\.(?:py|pl|awk|sh)$/) { ERROR("EXECUTE_PERMISSIONS", "do not set execute permissions for source files\n" . $permhere); }
base-commit: d67bc7812221606e1886620a357b13f906814af7 --
2.26.2
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees