Skip to contentSkip to conversation

sh: Drop ARCH_NR_GPIOS definition

PATCH In review Andy Shevchenko 3 participants 10 messages Oct 12, 2020 – Jan 18, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: Drop ARCH_NR_GPIOS definition

The default by generic header is the same, hence drop unnecessary definition.

---
 arch/sh/include/asm/gpio.h | 1 -
 1 file changed, 1 deletion(-)
arch/sh/include/asm/gpio.h +0 -1
index 351918894e86..d643250f0a0f 100644
@@ -16,7 +16,6 @@
 #include <cpu/gpio.h>
 #endif
 
-#define ARCH_NR_GPIOS 512
 #include <asm-generic/gpio.h>
 
 #ifdef CONFIG_GPIOLIB
Signature · 1 line
2.28.0
#1 lore raw
Quoted 1 line · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

Any comment on this?

Quoted 20 lines
---
 arch/sh/include/asm/gpio.h | 1 -
 1 file changed, 1 deletion(-)
arch/sh/include/asm/gpio.h +0 -1
index 351918894e86..d643250f0a0f 100644
@@ -16,7 +16,6 @@
 #include <cpu/gpio.h>
 #endif
 
-#define ARCH_NR_GPIOS 512
 #include <asm-generic/gpio.h>
 
 #ifdef CONFIG_GPIOLIB
Signature · 1 line
2.28.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Acked-by
#2 lore raw
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

Any comment on this?

It's in the stack I forwarded to Rich to look at this weekend.

Rob

#3 lore raw
Quoted 7 lines · Rob Landley
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

Any comment on this?

Thanks!

Quoted 1 line

It's in the stack I forwarded to Rich to look at this weekend.

Unfortunately I still do not see this in the latest Linux Next.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Hi Andy!

Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Rob Landley
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

Any comment on this?

Quoted 7 lines
Quoted 1 line

Thanks!

Quoted 1 line

It's in the stack I forwarded to Rich to look at this weekend.

Unfortunately I still do not see this in the latest Linux Next.

Rich already mentioned that he planned to pick up any patches the next weeks/days.

I'm currently testing all the patches recently posted for any regressions.

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
#5 lore raw
Quoted 14 lines · John Paul Adrian Glaubitz

Hi Andy!

Quoted 11 lines · Andy Shevchenko
Quoted 7 lines · Rob Landley
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

Any comment on this?

Thanks!

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

It's in the stack I forwarded to Rich to look at this weekend.

Unfortunately I still do not see this in the latest Linux Next.

Rich already mentioned that he planned to pick up any patches the next weeks/days.

I'm currently testing all the patches recently posted for any regressions.

I spoke to him on wednesday and he said he was working on it.

Rob

#6 lore raw

Hi Rob!

Quoted 6 lines · Rob Landley
Quoted 4 lines

Rich already mentioned that he planned to pick up any patches the next weeks/days.

I'm currently testing all the patches recently posted for any regressions.

I spoke to him on wednesday and he said he was working on it.

Any news on this? I have tested or acked all patches now that I found on the list that are not applied yet. I can assemble a list of these if necessary.

Adrian

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
#7 lore raw
Quoted 6 lines · John Paul Adrian Glaubitz

Hi Rob!

Quoted 3 lines · Rob Landley
Quoted 3 lines

Rich already mentioned that he planned to pick up any patches the next weeks/days.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

I'm currently testing all the patches recently posted for any regressions.

I spoke to him on wednesday and he said he was working on it.

Any news on this? I have tested or acked all patches now that I found on the list that are not applied yet. I can assemble a list of these if necessary.

I spoke to him on the 13th and he said he was working on it, just like I spoke to him on the 6th and he said he was working on it. And so on for a few months now.

Assembling a list wouldn't hurt, but I've assembled a list at him multiple times. I suspect what I need to do is assemble a git tree and submit a pull request.

Rob

maintainer Tested-by on v1 1/1
#8 lore raw
In reply to Andy Shevchenko

Hi Andy!

Quoted 13 lines · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

---
 arch/sh/include/asm/gpio.h | 1 -
 1 file changed, 1 deletion(-)
arch/sh/include/asm/gpio.h +0 -0
index 351918894e86..d643250f0a0f 100644

arch/sh/include/asm/gpio.h line 21

Quoted 7 lines
arch/sh/include/asm/gpio.h +0 -1
@@ -16,7 +16,6 @@
 #include <cpu/gpio.h>
 #endif
 
-#define ARCH_NR_GPIOS 512
 #include <asm-generic/gpio.h>
 
 #ifdef CONFIG_GPIOLIB

Verified on my SH-7785LCR board. Boots fine.

Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
maintainer Acked-by on v1 1/1
#9 lore raw
In reply to Andy Shevchenko
Quoted 12 lines · Andy Shevchenko

The default by generic header is the same, hence drop unnecessary definition.

---
 arch/sh/include/asm/gpio.h | 1 -
 1 file changed, 1 deletion(-)
arch/sh/include/asm/gpio.h +0 -0
index 351918894e86..d643250f0a0f 100644

arch/sh/include/asm/gpio.h line 21

Quoted 7 lines
arch/sh/include/asm/gpio.h +0 -1
@@ -16,7 +16,6 @@
 #include <cpu/gpio.h>
 #endif
 
-#define ARCH_NR_GPIOS 512
 #include <asm-generic/gpio.h>
 
 #ifdef CONFIG_GPIOLIB
Signature · 4 lines
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - [email protected]
`. `'   Freie Universitaet Berlin - [email protected]
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913