Skip to contentSkip to conversation

xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n

PATCH In review Darrick J. Wong 2 participants 2 messages Oct 12, 2020 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n

From: Darrick J. Wong <[email protected]>

Pavel Machek complained that the question about supporting deprecated XFS v4 comes up even when XFS is disabled. This clearly makes no sense, so fix Kconfig.

---
 fs/xfs/Kconfig |    1 +
 1 file changed, 1 insertion(+)
fs/xfs/Kconfig +1 -0
index 5422227e9e93..9fac5ea8d0e4 100644
@@ -24,6 +24,7 @@ config XFS_FS
 
 config XFS_SUPPORT_V4
 	bool "Support deprecated V4 (crc=0) format"
+	depends on XFS_FS
 	default y
 	help
 	  The V4 filesystem format lacks certain features that are supported
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Pavel Machek complained that the question about supporting deprecated XFS v4 comes up even when XFS is disabled. This clearly makes no sense, so fix Kconfig.

Quoted 17 lines
---
 fs/xfs/Kconfig |    1 +
 1 file changed, 1 insertion(+)
fs/xfs/Kconfig +1 -0
index 5422227e9e93..9fac5ea8d0e4 100644
@@ -24,6 +24,7 @@ config XFS_FS
 
 config XFS_SUPPORT_V4
 	bool "Support deprecated V4 (crc=0) format"
+	depends on XFS_FS
 	default y
 	help
 	  The V4 filesystem format lacks certain features that are supported