net/bnx2x: fix to add QLogic vendor id
PATCH 1/1 net/bnx2x: fix to add QLogic vendor id
Add QLogic vendor id support for BCM57840 device ids.
--- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/bnx2x/bnx2x_ethdev.c +4 -0
@@ -17,6 +17,7 @@* The set of PCI devices this driver supports */ #define BROADCOM_PCI_VENDOR_ID 0x14E4 +#define QLOGIC_PCI_VENDOR_ID 0x1077static const struct rte_pci_id pci_id_bnx2x_map[] = { {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57800 ) }, {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57711 ) },
@@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, #endif { .vendor_id = 0, } };
@@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, { .vendor_id = 0, } };
Signature · 1 line
2.18.0
Quoted 8 lines · Rasesh Mody
Add QLogic vendor id support for BCM57840 device ids.
Fixes 9fb557035d90 ("bnx2x: enable PMD build")Reported-by Souvik Dey <[email protected]>Signed-off-by Rasesh Mody <[email protected]>
There was an error from CI on Broadcom CI,
Since this patch is about Broadcom PMD fix, Do we need to worry about this?
http://mails.dpdk.org/archives/test-report/2020-October/158246.html
Quoted 41 lines
--- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/bnx2x/bnx2x_ethdev.c +4
-1@@ -17,6 +17,7 @@* The set of PCI devices this driver supports */ #define BROADCOM_PCI_VENDOR_ID 0x14E4 +#define QLOGIC_PCI_VENDOR_ID 0x1077static const struct rte_pci_id pci_id_bnx2x_map[] = { {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57800 ) }, {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57711 ) },@@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, #endif { .vendor_id = 0, } };@@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, { .vendor_id = 0, } }; --2.18.0
Quoted 7 lines · Jerin Jacob
Quoted 6 lines · Rasesh Mody
Add QLogic vendor id support for BCM57840 device ids.
Fixes 9fb557035d90 ("bnx2x: enable PMD build")
Quoted 8 lines
Quoted 2 lines
Reported-by Souvik Dey <[email protected]>Signed-off-by Rasesh Mody <[email protected]>There was an error from CI on Broadcom CI,
Since this patch is about Broadcom PMD fix, Do we need to worry about this?
http://mails.dpdk.org/archives/test-report/2020-October/158246.html
Errors shouldn't be related to this patch, so I think error can be ignored for this patch.
But added Ajit & lab for the issue.
Quoted 42 lines
Quoted 42 lines
--- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/bnx2x/bnx2x_ethdev.c +4
-1@@ -17,6 +17,7 @@* The set of PCI devices this driver supports */ #define BROADCOM_PCI_VENDOR_ID 0x14E4 +#define QLOGIC_PCI_VENDOR_ID 0x1077static const struct rte_pci_id pci_id_bnx2x_map[] = { {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57800 ) }, {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57711 ) },@@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, #endif { .vendor_id = 0, } };@@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, { .vendor_id = 0, } }; --2.18.0
Quoted 13 lines · Ferruh Yigit
Quoted 11 lines · Jerin Jacob
Quoted 8 lines · Rasesh Mody
Add QLogic vendor id support for BCM57840 device ids.
Fixes 9fb557035d90 ("bnx2x: enable PMD build")Reported-by Souvik Dey <[email protected]>Signed-off-by Rasesh Mody <[email protected]>
Quoted 7 lines
Quoted 4 lines
There was an error from CI on Broadcom CI,
Since this patch is about Broadcom PMD fix, Do we need to worry about this?
http://mails.dpdk.org/archives/test-report/2020-October/158246.htmlErrors shouldn't be related to this patch, so I think error can be ignored for this patch.
+1
Quoted 2 lines
But added Ajit & lab for the issue.
I have seen this behavior earlier.
It showed up randomly on some patches which are not even related to Broadcom PMD. I will try to keep an eye on it.
Quoted 44 lines
Quoted 43 lines
Quoted 43 lines
--- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/bnx2x/bnx2x_ethdev.c +4
-1@@ -17,6 +17,7 @@* The set of PCI devices this driver supports */ #define BROADCOM_PCI_VENDOR_ID 0x14E4 +#define QLOGIC_PCI_VENDOR_ID 0x1077static const struct rte_pci_id pci_id_bnx2x_map[] = { {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57800 ) }, {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57711 ) },@@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, #endif { .vendor_id = 0, } };@@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, { .vendor_id = 0, } }; --2.18.0
Jerin Jacob
AppliedQuoted 22 lines · Ajit Khaparde
Quoted 13 lines · Ferruh Yigit
Quoted 11 lines · Jerin Jacob
Quoted 8 lines · Rasesh Mody
Add QLogic vendor id support for BCM57840 device ids.
Fixes 9fb557035d90 ("bnx2x: enable PMD build")Reported-by Souvik Dey <[email protected]>Signed-off-by Rasesh Mody <[email protected]>Quoted 7 lines
Quoted 4 lines
There was an error from CI on Broadcom CI,
Since this patch is about Broadcom PMD fix, Do we need to worry about this?
http://mails.dpdk.org/archives/test-report/2020-October/158246.htmlErrors shouldn't be related to this patch, so I think error can be ignored for this patch.
Quoted 7 lines
+1
Quoted 2 lines
But added Ajit & lab for the issue.
I have seen this behavior earlier.
It showed up randomly on some patches which are not even related to Broadcom PMD. I will try to keep an eye on it.
Applied to dpdk-next-net-mrvl/for-main. Thanks
Quoted 45 lines
Quoted 45 lines
Quoted 44 lines
Quoted 44 lines
--- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/net/bnx2x/bnx2x_ethdev.c +4
-1@@ -17,6 +17,7 @@* The set of PCI devices this driver supports */ #define BROADCOM_PCI_VENDOR_ID 0x14E4 +#define QLOGIC_PCI_VENDOR_ID 0x1077static const struct rte_pci_id pci_id_bnx2x_map[] = { {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57800 ) }, {RTE_PCI_DEVICE (BROADCOM_PCI_VENDOR_ID ,CHIP_NUM_57711 ) },@@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, #endif { .vendor_id = 0, } };@@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, { .vendor_id = 0, } }; --2.18.0