Skip to contentSkip to conversation

drm/i915/execbuf: don't allow zero batch_len

PATCH In review Matthew Auld 3 participants 7 messages Oct 13, 2020 – Oct 14, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/execbuf: don't allow zero batch_len

As per the ABI batch_len is u32, however if the batch_len is left unset, then the kernel will just assume batch_len is the size of the whole batch object, however since the vma->size is u64, while the batch_len is just u32 we can end up with batch_len = 0 if we are given too large batch object(e.g 1ULL << 32), which doesn't look the intended behaviour and probably leads to explosions on some HW.

Testcase: igt/gem_exec_params/larger-than-life-batch

Fixes 0b5372727be3 ("drm/i915/cmdparser: Use cached vmappings")
Cc Chris Wilson <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +6 -1
index 4b09bcd70cf4..80c738c72e6e 100644
@@ -869,8 +869,13 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb)
 		return -EINVAL;
 	}
 
-	if (eb->batch_len == 0)
+	if (eb->batch_len == 0) {
 		eb->batch_len = eb->batch->vma->size - eb->batch_start_offset;
+		if (unlikely(eb->batch_len == 0)) {
+			drm_dbg(&i915->drm, "Attempting to use too large batch\n");
+			return -EINVAL;
+		}
+	}
 
 	return 0;
 
Signature · 6 lines
2.26.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Matthew Auld (2020-10-13 12:18:39)

Quoted 9 lines

As per the ABI batch_len is u32, however if the batch_len is left unset, then the kernel will just assume batch_len is the size of the whole batch object, however since the vma->size is u64, while the batch_len is just u32 we can end up with batch_len = 0 if we are given too large batch object(e.g 1ULL << 32), which doesn't look the intended behaviour and probably leads to explosions on some HW.

Testcase: igt/gem_exec_params/larger-than-life-batch

Fixes 0b5372727be3 ("drm/i915/cmdparser: Use cached vmappings")

Nah. That's setting exec_len used for dispatch, not for parsing, which is still using

i915_gem_execbuffer_parse(engine, &shadow_exec_entry,

			  params->batch->obj,
			  eb,
			  args->batch_start_offset,
			  args->batch_len,
			  drm_is_current_master(file));

(and args->batch_len is straight from userspace and passed onwards)

It's right up until 435e8fc059db ("drm/i915: Allow parsing of unsized batches") where we are using the user value of batch_len for allocating the shadow object and parsing.

Fixes 435e8fc059db ("drm/i915: Allow parsing of unsized batches")
Quoted 11 lines
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +0 -0
index 4b09bcd70cf4..80c738c72e6e 100644

drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c static int eb_lookup_vmas(struct i915_execbuffer *eb) · line 873

Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1 -1
@@ -869,8 +869,13 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb)
                return -EINVAL;
        }
 
-       if (eb->batch_len == 0)
+       if (eb->batch_len == 0) {
                eb->batch_len = eb->batch->vma->size - eb->batch_start_offset;

if (overflows_type(eb->batch->vma->size - eb->batch_start_offset, eb->batch_len))

It should not have caused the cmdparser any trouble though, it should have been quite happy to copy nothing and reject the batch for reaching the end too early (with a very slim chance of a stale MI_BATCH_BUFFER_END to the rescue).

intel_gt_get_buffer_pool() looks suspect given a size of 0, it will either give the largest object it has cached or break upon creating/allocating internal pages.

In terms of HW fail, only gen2 used the parameter and it has a very limited batch/GTT size.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Quoting Chris Wilson (2020-10-13 12:58:31)

Quoted 42 lines

Quoting Matthew Auld (2020-10-13 12:18:39)

Quoted 9 lines

As per the ABI batch_len is u32, however if the batch_len is left unset, then the kernel will just assume batch_len is the size of the whole batch object, however since the vma->size is u64, while the batch_len is just u32 we can end up with batch_len = 0 if we are given too large batch object(e.g 1ULL << 32), which doesn't look the intended behaviour and probably leads to explosions on some HW.

Testcase: igt/gem_exec_params/larger-than-life-batch

Fixes 0b5372727be3 ("drm/i915/cmdparser: Use cached vmappings")

Nah. That's setting exec_len used for dispatch, not for parsing, which is still using

i915_gem_execbuffer_parse(engine, &shadow_exec_entry,

                          params->batch->obj,
                          eb,
                          args->batch_start_offset,
                          args->batch_len,
                          drm_is_current_master(file));

(and args->batch_len is straight from userspace and passed onwards)

It's right up until 435e8fc059db ("drm/i915: Allow parsing of unsized batches") where we are using the user value of batch_len for allocating the shadow object and parsing.

Fixes 435e8fc059db ("drm/i915: Allow parsing of unsized batches")
Quoted 14 lines
---
 drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +0 -0
index 4b09bcd70cf4..80c738c72e6e 100644
@@ -869,8 +869,13 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb)
                return -EINVAL;
        }
 
Quoted 5 lines

drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c static int eb_lookup_vmas(struct i915_execbuffer *eb) · line 873

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1 -1
-       if (eb->batch_len == 0)
+       if (eb->batch_len == 0) {
                eb->batch_len = eb->batch->vma->size - eb->batch_start_offset;

if (overflows_type(eb->batch->vma->size - eb->batch_start_offset, eb->batch_len))

And we shouldn't fail here. So bump to u64, and since the vma->size cannot be larger than the GTT, we will be safe for gen2 where it makes a difference.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Chris Wilson
Quoted 20 lines · Chris Wilson

Quoting Matthew Auld (2020-10-13 12:18:39)

Quoted 9 lines

As per the ABI batch_len is u32, however if the batch_len is left unset, then the kernel will just assume batch_len is the size of the whole batch object, however since the vma->size is u64, while the batch_len is just u32 we can end up with batch_len = 0 if we are given too large batch object(e.g 1ULL << 32), which doesn't look the intended behaviour and probably leads to explosions on some HW.

Testcase: igt/gem_exec_params/larger-than-life-batch

Fixes 0b5372727be3 ("drm/i915/cmdparser: Use cached vmappings")

Nah. That's setting exec_len used for dispatch, not for parsing, which is still using

i915_gem_execbuffer_parse(engine, &shadow_exec_entry,

			  params->batch->obj,
			  eb,
			  args->batch_start_offset,
			  args->batch_len,
			  drm_is_current_master(file));
Quoted 7 lines

(and args->batch_len is straight from userspace and passed onwards)

It's right up until 435e8fc059db ("drm/i915: Allow parsing of unsized batches") where we are using the user value of batch_len for allocating the shadow object and parsing.

Fixes 435e8fc059db ("drm/i915: Allow parsing of unsized batches")

On the topic of that patch, why is it looking at args->batch_len(might be zero), even though it looks like it is trying to move the eb->batch_len calculation to before we call eb_use_cmdparser(), so it can use it(the commit message seems to suggest that?), but then it only looks at the args version anyway. I don't get it.

Quoted 26 lines
Quoted 12 lines
---
  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +0 -0
index 4b09bcd70cf4..80c738c72e6e 100644

drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c static int eb_lookup_vmas(struct i915_execbuffer *eb) · line 873

Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1 -1
@@ -869,8 +869,13 @@ static int eb_lookup_vmas(struct i915_execbuffer *eb)
                 return -EINVAL;
         }
 
-       if (eb->batch_len == 0)
+       if (eb->batch_len == 0) {
                 eb->batch_len = eb->batch->vma->size - eb->batch_start_offset;

if (overflows_type(eb->batch->vma->size - eb->batch_start_offset, eb->batch_len))

It should not have caused the cmdparser any trouble though, it should have been quite happy to copy nothing and reject the batch for reaching the end too early (with a very slim chance of a stale MI_BATCH_BUFFER_END to the rescue).

Quoted 8 lines

intel_gt_get_buffer_pool() looks suspect given a size of 0, it will either give the largest object it has cached or break upon creating/allocating internal pages.

In terms of HW fail, only gen2 used the parameter and it has a very limited batch/GTT size.
-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Quoting Matthew Auld (2020-10-13 15:07:46)

Quoted 27 lines · Chris Wilson
Quoted 26 lines

Quoting Matthew Auld (2020-10-13 12:18:39)

Quoted 9 lines

As per the ABI batch_len is u32, however if the batch_len is left unset, then the kernel will just assume batch_len is the size of the whole batch object, however since the vma->size is u64, while the batch_len is just u32 we can end up with batch_len = 0 if we are given too large batch object(e.g 1ULL << 32), which doesn't look the intended behaviour and probably leads to explosions on some HW.

Testcase: igt/gem_exec_params/larger-than-life-batch

Fixes 0b5372727be3 ("drm/i915/cmdparser: Use cached vmappings")

Nah. That's setting exec_len used for dispatch, not for parsing, which is still using

i915_gem_execbuffer_parse(engine, &shadow_exec_entry,

                        params->batch->obj,
                        eb,
                        args->batch_start_offset,
                        args->batch_len,
                        drm_is_current_master(file));

(and args->batch_len is straight from userspace and passed onwards)

It's right up until 435e8fc059db ("drm/i915: Allow parsing of unsized batches") where we are using the user value of batch_len for allocating the shadow object and parsing.

Quoted 7 lines
Quoted 1 line
Fixes 435e8fc059db ("drm/i915: Allow parsing of unsized batches")

On the topic of that patch, why is it looking at args->batch_len(might be zero), even though it looks like it is trying to move the eb->batch_len calculation to before we call eb_use_cmdparser(), so it can use it(the commit message seems to suggest that?), but then it only looks at the args version anyway. I don't get it.

iirc, it was so that we could change the order around and later modify eb.batch_len before eb_use_cmdparser() [so eb.batch_len no longer would be zero, defeating the cheat].
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execbuf: don't allow zero batch_len

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: drm/i915/execbuf: don't allow zero batch_len
URL : https://patchwork.freedesktop.org/series/82620/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9135 -> Patchwork_18687
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/index.html

Known issues
------------

Here are the changes found in Patchwork_18687 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_flink_basic@basic:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-tgl-y/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-bsw-kefka/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-bsw-kefka/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-tgl-y/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-tgl-y/igt@[email protected]

* igt@vgem_basic@unload:
- fi-skl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#2203])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-skl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-skl-guc/igt@[email protected]

#### Possible fixes ####

* igt@gem_flink_basic@bad-flink:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-tgl-y/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-byt-j1900/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-byt-j1900/igt@[email protected]
- fi-bsw-n3050: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-bsw-n3050/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-bsw-n3050/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-icl-u2/igt@[email protected]
- fi-apl-guc: [DMESG-WARN][17] ([i915#1635] / [i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-apl-guc/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-apl-guc/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- {fi-tgl-dsi}: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-tgl-dsi/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-tgl-dsi/igt@[email protected]

#### Warnings ####

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [DMESG-WARN][21] ([i915#2411]) -> [DMESG-WARN][22] ([i915#2411] / [i915#402])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/fi-tgl-y/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/fi-tgl-y/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2089]: https://gitlab.freedesktop.org/drm/intel/issues/2089
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#2268]: https://gitlab.freedesktop.org/drm/intel/issues/2268
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (47 -> 41)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9135 -> Patchwork_18687

CI-20190529: 20190529
CI_DRM_9135: eb70ad33fcc91d3464b07679391fb477927ad4c7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5813: d4e6dd955a1dad02271aa41c9389f5097ee17765 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18687: e8e47513fb88d5bd8f0a8c1af1245215358ff1d1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

e8e47513fb88 drm/i915/execbuf: don't allow zero batch_len

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/execbuf: don't allow zero batch_len

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: drm/i915/execbuf: don't allow zero batch_len
URL : https://patchwork.freedesktop.org/series/82620/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9135_full -> Patchwork_18687_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_18687_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18687_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18687_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-glk7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-glk4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
- shard-tglb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html

#### Warnings ####

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- shard-tglb: [DMESG-FAIL][5] ([i915#1982]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-tglb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-tglb3/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_18687_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#658])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-iclb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-iclb5/igt@[email protected]

* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2389]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-glk1/igt@gem_exec_reloc@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-glk7/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-glk8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-glk2/igt@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-snb: [PASS][13] -> [INCOMPLETE][14] ([i915#82])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-snb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-snb6/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [PASS][15] -> [TIMEOUT][16] ([i915#2424])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl4/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][17] -> [DMESG-WARN][18] ([i915#1436] / [i915#716])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl6/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-b-64x64-right-edge:
- shard-apl: [PASS][19] -> [INCOMPLETE][20] ([i915#1635] / [i915#2377])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-apl8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-apl2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl7/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip@wf_vblank-ts-check-interruptible@a-edp1:
- shard-tglb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-tglb5/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-tglb1/igt@kms_flip@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#53])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl8/igt@[email protected]

* igt@kms_plane@plane-panning-top-left-pipe-c-planes:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl9/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl7/igt@[email protected]

* igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
- shard-iclb: [PASS][31] -> [DMESG-WARN][32] ([i915#1982])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-iclb3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-iclb3/igt@[email protected]

* igt@kms_psr@psr2_primary_render:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-iclb2/igt@kms_psr@psr2_primary_render.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-iclb5/igt@kms_psr@psr2_primary_render.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][35] -> [FAIL][36] ([i915#1635] / [i915#31])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-apl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-apl8/igt@[email protected]

#### Possible fixes ####

* {igt@kms_async_flips@alternate-sync-async-flip}:
- shard-kbl: [FAIL][37] ([i915#2521]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-kbl7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-kbl7/igt@[email protected]

* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-iclb: [FAIL][39] ([i915#2521]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-iclb6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-iclb1/igt@[email protected]
- shard-tglb: [FAIL][41] ([i915#2521]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-tglb1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-tglb6/igt@[email protected]

* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +7 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl2/igt@[email protected]

* igt@kms_cursor_legacy@pipe-b-torture-move:
- shard-tglb: [DMESG-WARN][45] ([i915#128]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-tglb7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-tglb2/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-glk: [DMESG-FAIL][47] ([i915#118] / [i915#95]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-glk3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-glk9/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-apl: [FAIL][49] ([i915#1635] / [i915#79]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-apl8/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-skl: [INCOMPLETE][51] ([i915#198]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl7/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl8/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [FAIL][53] ([i915#2122]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl8/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- shard-tglb: [FAIL][55] -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html

* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-iclb: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-iclb8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-iclb1/igt@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][59] ([i915#1188]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl5/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl1/igt@[email protected]

* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][61] ([fdo#109441]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-iclb4/igt@kms_psr@psr2_dpms.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-iclb2/igt@kms_psr@psr2_dpms.html

* igt@kms_setmode@basic:
- shard-skl: [FAIL][63] ([i915#31]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl9/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl7/igt@[email protected]

* igt@perf@blocking:
- shard-skl: [FAIL][65] ([i915#1542]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl10/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl5/igt@[email protected]

* igt@sysfs_heartbeat_interval@mixed@vcs1:
- shard-kbl: [INCOMPLETE][67] ([i915#1731]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-kbl4/igt@sysfs_heartbeat_interval@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-kbl7/igt@sysfs_heartbeat_interval@[email protected]

#### Warnings ####

* igt@kms_content_protection@atomic-dpms:
- shard-apl: [FAIL][69] ([fdo#110321] / [fdo#110336] / [i915#1635]) -> [TIMEOUT][70] ([i915#1319] / [i915#1635])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-apl3/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-apl4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [DMESG-WARN][71] ([i915#1982]) -> [DMESG-FAIL][72] ([i915#1982])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9135/shard-skl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/shard-skl3/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2377]: https://gitlab.freedesktop.org/drm/intel/issues/2377
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2424]: https://gitlab.freedesktop.org/drm/intel/issues/2424
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2553]: https://gitlab.freedesktop.org/drm/intel/issues/2553
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_9135 -> Patchwork_18687

CI-20190529: 20190529
CI_DRM_9135: eb70ad33fcc91d3464b07679391fb477927ad4c7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5813: d4e6dd955a1dad02271aa41c9389f5097ee17765 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18687: e8e47513fb88d5bd8f0a8c1af1245215358ff1d1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18687/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx