rtw88: add dump firmware fifo support

Hello Tzu-En Huang,

The patch 0fbc2f0f34cc: "rtw88: add dump firmware fifo support" from Sep 25, 2020, leads to the following static checker warning:

	drivers/net/wireless/realtek/rtw88/fw.c:1485 rtw_fw_dump_fifo()
	warn: this array is probably non-NULL. 'rtwdev->chip->fw_fifo_addr'

drivers/net/wireless/realtek/rtw88/fw.c
1482 int rtw_fw_dump_fifo(struct rtw_dev *rtwdev, u8 fifo_sel, u32 addr, u32 size,
1483 u32 *buffer)
1484 {

  1485          if (!rtwdev->chip->fw_fifo_addr) {
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^

Delete this check?

  1486                  rtw_dbg(rtwdev, RTW_DBG_FW, "chip not support dump fw fifo\n");
  1487                  return -ENOTSUPP;
  1488          }
  1489  
  1490          if (size == 0 || !buffer)
  1491                  return -EINVAL;

regards,
dan carpenter

Thanks for the report, and I saw Tom had sent a patch to fix it. I acked on the patch.

Tzu-En