Skip to contentSkip to conversation

xfrm: fail to create ixgbe offload of IPsec tunnel mode sa

RFC PATCH New Antony Antony 2 participants 3 messages Aug 28, 2020 – Oct 14, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 xfrm: fail to create ixgbe offload of IPsec tunnel mode sa

Based on talks and indirect references ixgbe driver does not support offloading IPsec tunnel mode. It only support transport mode. Now explicitly fail to avoid when trying to offload.

Fixes 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA")

---
I haven't tested this fix as I have no access to the hardware. This patch is based on a libreswan bug report.
https://github.com/libreswan/libreswan/issues/252
Is it useful to this bug report in kernel commit message?

 drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 5 +++++
 drivers/net/ethernet/intel/ixgbevf/ipsec.c     | 5 +++++
 2 files changed, 10 insertions(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c +5 -0
index eca73526ac86..e2b978efcc5a 100644
@@ -575,6 +575,11 @@ static int ixgbe_ipsec_add_sa(struct xfrm_state *xs)
 		return -EINVAL;
 	}
 
+	if (xs->props.mode != XFRM_MODE_TRANSPORT) {
+		netdev_err(dev, "Unsupported mode for ipsec offload\n");
+		return -EINVAL;
+	}
+
 	if (ixgbe_ipsec_check_mgmt_ip(xs)) {
 		netdev_err(dev, "IPsec IP addr clash with mgmt filters\n");
 		return -EINVAL;
drivers/net/ethernet/intel/ixgbevf/ipsec.c +5 -0
index 5170dd9d8705..d11b3f3414ea 100644
@@ -272,6 +272,11 @@ static int ixgbevf_ipsec_add_sa(struct xfrm_state *xs)
 		return -EINVAL;
 	}
 
+	if (xs->props.mode != XFRM_MODE_TRANSPORT) {
+		netdev_err(dev, "Unsupported mode for ipsec offload\n");
+		return -EINVAL;
+	}
+
 	if (xs->xso.flags & XFRM_OFFLOAD_INBOUND) {
 		struct rx_sa rsa;
 
Signature · 1 line
2.21.3
#1 lore raw

PATCH 1/1 ixgbe: fail to create xfrm offload of IPsec tunnel mode SA

Based on talks and indirect references ixgbe IPsec offlod do not support IPsec tunnel mode offload. It can only support IPsec transport mode offload. Now explicitly fail when creating non transport mode SA
with offload to avoid false performance expectations.

Fixes 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA")
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 5 +++++
 drivers/net/ethernet/intel/ixgbevf/ipsec.c     | 5 +++++
 2 files changed, 10 insertions(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c +5 -0
index eca73526ac86..54d47265a7ac 100644
@@ -575,6 +575,11 @@ static int ixgbe_ipsec_add_sa(struct xfrm_state *xs)
 		return -EINVAL;
 	}
 
+	if (xs->props.mode != XFRM_MODE_TRANSPORT) {
+		netdev_err(dev, "Unsupported mode for ipsec offload\n");
+		return -EINVAL;
+	}
+
 	if (ixgbe_ipsec_check_mgmt_ip(xs)) {
 		netdev_err(dev, "IPsec IP addr clash with mgmt filters\n");
 		return -EINVAL;
drivers/net/ethernet/intel/ixgbevf/ipsec.c +5 -0
index 5170dd9d8705..caaea2c920a6 100644
@@ -272,6 +272,11 @@ static int ixgbevf_ipsec_add_sa(struct xfrm_state *xs)
 		return -EINVAL;
 	}
 
+	if (xs->props.mode != XFRM_MODE_TRANSPORT) {
+		netdev_err(dev, "Unsupported mode for ipsec offload\n");
+		return -EINVAL;
+	}
+
 	if (xs->xso.flags & XFRM_OFFLOAD_INBOUND) {
 		struct rx_sa rsa;
 
Signature · 1 line
2.21.3
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] ixgbe: fail to create xfrm offload of IPsec tunnel mode SA

Quoted 7 lines · Antony Antony

Based on talks and indirect references ixgbe IPsec offlod do not support IPsec tunnel mode offload. It can only support IPsec transport mode offload. Now explicitly fail when creating non transport mode SA
with offload to avoid false performance expectations.

Fixes 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA")
Quoted 37 lines
---
  drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 5 +++++
  drivers/net/ethernet/intel/ixgbevf/ipsec.c     | 5 +++++
  2 files changed, 10 insertions(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c +5 -0
index eca73526ac86..54d47265a7ac 100644
@@ -575,6 +575,11 @@ static int ixgbe_ipsec_add_sa(struct xfrm_state *xs)
  		return -EINVAL;
  	}
 
+	if (xs->props.mode != XFRM_MODE_TRANSPORT) {
+		netdev_err(dev, "Unsupported mode for ipsec offload\n");
+		return -EINVAL;
+	}
+
  	if (ixgbe_ipsec_check_mgmt_ip(xs)) {
  		netdev_err(dev, "IPsec IP addr clash with mgmt filters\n");
  		return -EINVAL;
drivers/net/ethernet/intel/ixgbevf/ipsec.c +5 -0
index 5170dd9d8705..caaea2c920a6 100644
@@ -272,6 +272,11 @@ static int ixgbevf_ipsec_add_sa(struct xfrm_state *xs)
  		return -EINVAL;
  	}
 
+	if (xs->props.mode != XFRM_MODE_TRANSPORT) {
+		netdev_err(dev, "Unsupported mode for ipsec offload\n");
+		return -EINVAL;
+	}
+
  	if (xs->xso.flags & XFRM_OFFLOAD_INBOUND) {
  		struct rx_sa rsa;