Skip to contentSkip to conversation

ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

PATCH In review Khem Raj 3 participants 7 messages Oct 13, 2020 – Oct 14, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v2 1/1 ti-pdk-fetch.bbclass: Do not emit trailing slash during S forming

latest OE-core does not promote using trailing slash to make pseudo's life easier

---
v2: Strip slash from S if it exists

 classes/ti-pdk-fetch.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
classes/ti-pdk-fetch.bbclass +1 -1
index 0c9879be..cacd71a4 100644
@@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
 TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
 TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
 
-S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
+S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
 
 # Hard-link only required sources from PDK
 python do_unpack_append() {
Signature · 1 line
2.28.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 2 lines · Khem Raj

latest OE-core does not promote using trailing slash to make pseudo's life easier

This should be fine.

Quoted 1 line
Quoted 26 lines

---
v2: Strip slash from S if it exists

 classes/ti-pdk-fetch.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
classes/ti-pdk-fetch.bbclass +1 -1
index 0c9879be..cacd71a4 100644
@@ -15,7 +15,7 @@ TI_PDK_SOURCE_PN = "ti-pdk-source"
 TI_PDK_SOURCE_WORKDIR = "${TMPDIR}/work-shared/ti-pdk-${PV}"
 TI_PDK_SOURCE = "${TI_PDK_SOURCE_WORKDIR}/git"
 
-S = "${WORKDIR}/git/${TI_PDK_COMP_PATH}"
+S = "${@'${WORKDIR}/git/${TI_PDK_COMP_PATH}'.rstrip('/')}"
 
 # Hard-link only required sources from PDK
 python do_unpack_append() {
Signature · 1 line
2.28.0
#2 lore raw
In reply to Khem Raj

Khem

Quoted 6 lines · Khem Raj

latest OE-core does not promote using trailing slash to make pseudo's life easier

---
v2: Strip slash from S if it exists

There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?

Dan

#3 lore raw
Quoted 11 lines · Dan Murphy via lists.yoctoproject.org

Khem

Quoted 6 lines · Khem Raj

latest OE-core does not promote using trailing slash to make pseudo's life easier

---
v2: Strip slash from S if it exists

There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?

Dan,

I believe it is also needed.

Denys

#4 lore raw

Denys

Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Dan Murphy via lists.yoctoproject.org

Khem

Quoted 3 lines · Khem Raj

latest OE-core does not promote using trailing slash to make pseudo's life easier

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

---
v2: Strip slash from S if it exists

There were 2 patches submitted with v1.  Do we just drop the RTOS patch now?

Dan,

I believe it is also needed.

Yes I believe it is needed as well just need Khem to confirm or resubmit the series

Dan

Quoted 1 line

Denys

author
#5 lore raw
In reply to Dan Murphy
Quoted 4 lines · Dan Murphy

Khem

On 10/13/20 4:49 PM, Khem Raj wrote:

Quoted 9 lines
Quoted 6 lines

latest OE-core does not promote using trailing slash to make pseudo's life easier

---
v2: Strip slash from S if it exists

There were 2 patches submitted with v1. Do we just drop the RTOS patch now?

right you need v1 of one patch and v2 of the other. I usually update the series with the resent patches. If you want whole series to be resent I can do that.

Quoted 2 lines

Dan

#6 lore raw

Khem

Quoted 7 lines · Khem Raj
Quoted 6 lines · Dan Murphy

Khem

Quoted 3 lines · Khem Raj

latest OE-core does not promote using trailing slash to make pseudo's life easier

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

---
v2: Strip slash from S if it exists

There were 2 patches submitted with v1. Do we just drop the RTOS patch now?

right you need v1 of one patch and v2 of the other. I usually update the series with the resent patches. If you want whole series to be resent I can do that.

OK.  I will apply them.  Generally when you promote a patch version in a series the full series should be promoted and re-sent.

Otherwise patches might be missed.

Dan