Skip to contentSkip to conversation

col: fix --help short option in usage() output

PATCH In review Sami Kerola 2 participants 2 messages Oct 14, 2020 – Oct 16, 2020 Util-Linux package

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 col: fix --help short option in usage() output

The col(1) is using unusual -H as --help short option. The -h is used for --tabs (horizontal tab?) in this implementation.

Fixes 62dee0176a0c8e687d9ff0cb87342a0f8b893aaa
---
 text-utils/col.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
text-utils/col.c +2 -1
index e35e581cd..6963eb68f 100644
@@ -181,7 +181,8 @@ static void __attribute__((__noreturn__)) usage(void)
 		" -x, --spaces           convert tabs to spaces\n"
 		" -l, --lines NUM        buffer at least NUM lines\n"
 		));
-	printf(USAGE_HELP_OPTIONS(24));
+	printf( " -H, --help             %s\n", USAGE_OPTSTR_HELP);
+	printf( " -v, --version          %s\n", USAGE_OPTSTR_VERSION);
 
 	printf(USAGE_MAN_TAIL("col(1)"));
 	exit(EXIT_SUCCESS);
Signature · 1 line
2.28.0
maintainer
#1 lore raw
Quoted 2 lines · Sami Kerola

The col(1) is using unusual -H as --help short option. The -h is used for --tabs (horizontal tab?) in this implementation.

Good catch. Applied, thanks.

Karel

Signature · 2 lines
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com