Skip to contentSkip to conversation

support/dependencies: set cmake version min to 3.15

PATCH New Fabrice Fontaine 2 participants 2 messages Oct 15, 2020 – Dec 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 support/dependencies: set cmake version min to 3.15

quazip requires cmake 3.15 since version 1.0 and
https://github.com/stachenov/quazip/commit/89e7c201f0215032d347eef6fc0c671a1845738b
https://github.com/stachenov/quazip/commit/818adc82246cefffa2e8851534016cf1db349da7

The rationale for this requirement is that "default locations for the install(TARGETS command based on the GNUInstallDirs package were only added in 3.14" and "3.15 is not that much of a difference from 3.14 and it introduced a lot of useful UI improvements.":
https://github.com/stachenov/quazip/issues/82

Fixes:
- http://autobuild.buildroot.org/results/5d848a46109aef448ea1d1b857a500d9461dc2d9

---
 support/dependencies/check-host-cmake.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
support/dependencies/check-host-cmake.mk +2 -2
index 01f38da376..e1bbcd62c8 100644
@@ -1,9 +1,9 @@
-# Set this to either 3.10 or higher, depending on the highest minimum
+# Set this to either 3.15 or higher, depending on the highest minimum
 # version required by any of the packages bundled in Buildroot. If a
 # package is bumped or a new one added, and it requires a higher
 # version, our cmake infra will catch it and build its own.
 #
-BR2_CMAKE_VERSION_MIN = 3.10
+BR2_CMAKE_VERSION_MIN = 3.15
 
 BR2_CMAKE_CANDIDATES ?= cmake cmake3
 BR2_CMAKE ?= $(call suitable-host-package,cmake,\
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 support/dependencies: set cmake version min to 3.15

Fabrice, All,

On 2020-10-15 07:46 +0200, Fabrice Fontaine spake thusly:

Quoted 10 lines

quazip requires cmake 3.15 since version 1.0 and
https://github.com/stachenov/quazip/commit/89e7c201f0215032d347eef6fc0c671a1845738b
https://github.com/stachenov/quazip/commit/818adc82246cefffa2e8851534016cf1db349da7

The rationale for this requirement is that "default locations for the install(TARGETS command based on the GNUInstallDirs package were only added in 3.14" and "3.15 is not that much of a difference from 3.14 and it introduced a lot of useful UI improvements.":
https://github.com/stachenov/quazip/issues/82

Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/5d848a46109aef448ea1d1b857a500d9461dc2d9

I was not too keen on applying this bump, because that is going to increas the build quite quite a bit on older distros...

However, there is not much we can do against upstream's will. Furthermore, we can only count on more packages requiring a newer cmake version as tiem passes, so bumping the requirement is inevitable. I've added a note to that effect in the commit log, and applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 27 lines
---
 support/dependencies/check-host-cmake.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
support/dependencies/check-host-cmake.mk +2 -2
index 01f38da376..e1bbcd62c8 100644
@@ -1,9 +1,9 @@
-# Set this to either 3.10 or higher, depending on the highest minimum
+# Set this to either 3.15 or higher, depending on the highest minimum
 # version required by any of the packages bundled in Buildroot. If a
 # package is bumped or a new one added, and it requires a higher
 # version, our cmake infra will catch it and build its own.
 #
-BR2_CMAKE_VERSION_MIN = 3.10
+BR2_CMAKE_VERSION_MIN = 3.15
 
 BR2_CMAKE_CANDIDATES ?= cmake cmake3
 BR2_CMAKE ?= $(call suitable-host-package,cmake,\
Signature · 6 lines
2.28.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'