nvme-rdma: fix crash due to incorrect cqe
PATCH 1/1 nvme-rdma: fix crash due to incorrect cqe
A crash happened due to injecting error test. The cqe has incorrect command id, host may find a request which already be freed. req->mr->rkey cause a crash in nvme_rdma_process_nvme_rsp. Because the mr is already freed.
Add a check for the mr to fix it.
Signed-off-by Chao Leng <[email protected]>
--- drivers/nvme/host/rdma.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/nvme/host/rdma.c +3 -2
@@ -1730,10 +1730,11 @@ static void nvme_rdma_process_nvme_rsp(struct nvme_rdma_queue *queue, req->result = cqe->result;if (wc->wc_flags &IB_WC_WITH_INVALIDATE ) { -if (unlikely (wc->ex.invalidate_rkey != req->mr->rkey)) { +if (unlikely (!req->mr || + wc->ex.invalidate_rkey != req->mr->rkey)) {dev_err (queue->ctrl->ctrl.device,"Bogus remote invalidation for rkey %#x\n" , - req->mr->rkey); + req->mr ? req->mr->rkey :0 );nvme_rdma_error_recovery (queue->ctrl); } }else if (req->mr) {
Signature · 7 lines
2.16.4 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Reviewed-by Sagi Grimberg <[email protected]>
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Applied to nvme-5.10, thanks.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme