Skip to contentSkip to conversation

acl: fix build failure with gcc 5.4.0

PATCH Applied Konstantin Ananyev 3 participants 3 messages Oct 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acl: fix build failure with gcc 5.4.0

gcc 5.4 fails with:
../lib/librte_acl/acl_run_avx512x8.h: In function 'match_process_avx512x8':
../lib/librte_acl/acl_run_avx512x8.h:382:31: error:
pointer targets in passing argument 1 of '_mm256_mask_i32scatter_epi32' differ in signedness [-Werror=pointer-sign]

Later gcc versions work fine, as for them parameter type was changed to 'void *'.
Fixed by applying explicit cast for offending argument.

Fixes b64c2295f7fc ("acl: add 256-bit AVX512 classify method")
Fixes 45da22e42ec3 ("acl: add 512-bit AVX512 classify method")
---
 lib/librte_acl/acl_run_avx512_common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/librte_acl/acl_run_avx512_common.h +2 -2
index 1baf79b7a..fafaf591e 100644
@@ -246,8 +246,8 @@ _F_(match_process)(struct acl_flow_avx512 *flow, uint32_t *fmsk,
 	tr_hi[0] = _M_I_(mask_mov_epi32)(tr_hi[0], rmsk[0], _SV_(trhi_idle));
 
 	/* save found match indexes */
-	_M_I_(mask_i32scatter_epi32)(flow->matches, rmsk[0], idx[0], res,
-			sizeof(flow->matches[0]));
+	_M_I_(mask_i32scatter_epi32)((void *)flow->matches, rmsk[0], idx[0],
+			res, sizeof(flow->matches[0]));
 
 	/* update masks and start new flows for matches */
 	n = update_flow_mask(flow, fmsk, rmsk);
Signature · 1 line
2.25.1
Tested-by on v1 1/1
#1 lore raw

Thanks Konstantin.

Quoted 18 lines

-----Original Message-----
From: Konstantin Ananyev <[email protected]>
Sent: Thursday, October 15, 2020 2:54 PM
To: [email protected]
Cc: [email protected]; [email protected]; Konstantin Ananyev <[email protected]>
Subject: [PATCH] acl: fix build failure with gcc 5.4.0

gcc 5.4 fails with:
../lib/librte_acl/acl_run_avx512x8.h: In function 'match_process_avx512x8':
../lib/librte_acl/acl_run_avx512x8.h:382:31: error:
pointer targets in passing argument 1 of '_mm256_mask_i32scatter_epi32' differ in signedness [-Werror=pointer-sign]

Later gcc versions work fine, as for them parameter type was changed to 'void *'.
Fixed by applying explicit cast for offending argument.

Quoted 5 lines
Fixes b64c2295f7fc ("acl: add 256-bit AVX512 classify method")
Fixes 45da22e42ec3 ("acl: add 512-bit AVX512 classify method")

---

- Ali

Tested-by Ali Alnubani on v1 1/1 Applied
#2 lore raw
In reply to Konstantin Ananyev
Quoted 11 lines · Konstantin Ananyev

gcc 5.4 fails with:
../lib/librte_acl/acl_run_avx512x8.h: In function 'match_process_avx512x8':
../lib/librte_acl/acl_run_avx512x8.h:382:31: error:
pointer targets in passing argument 1 of '_mm256_mask_i32scatter_epi32' differ in signedness [-Werror=pointer-sign]

Later gcc versions work fine, as for them parameter type was changed to 'void *'.
Fixed by applying explicit cast for offending argument.

Bugzilla ID: 556

Quoted 3 lines
Fixes b64c2295f7fc ("acl: add 256-bit AVX512 classify method")
Fixes 45da22e42ec3 ("acl: add 512-bit AVX512 classify method")
Quoted 1 line

Applied, thanks.

Signature · 1 line
David Marchand