Skip to contentSkip to conversation

remove never-used "snps,dw-apb-gpio-port"

PATCH In review Jisheng Zhang 3 participants 13 messages Oct 15, 2020 – Oct 16, 2020

Subsystems (8)
lore
Share & tools
lore
#0 lore raw

cover remove never-used "snps,dw-apb-gpio-port"

The "snps,dw-apb-gpio-port" is never used.

Jisheng Zhang (8):
ARM: dts: berlin: Remove compatible string from dw apb gpio port
ARM: dts: socfpga: Remove compatible string from dw apb gpio port
arm64: dts: apm: remove compatible string from dw apb gpio port
arm64: dts: bitmain: Remove compatible string from dw apb gpio port
arm64: dts: hip05: Remove compatible string from dw apb gpio port
arm: dts: socfpga: Remove compatible string from dw apb gpio port
arm64: dts: synaptics: Remove compatible string from dw apb gpio port
dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

 .../devicetree/bindings/gpio/snps,dw-apb-gpio.yaml          | 5 -----
 arch/arm/boot/dts/berlin2.dtsi                              | 6 ------
 arch/arm/boot/dts/berlin2cd.dtsi                            | 6 ------
 arch/arm/boot/dts/berlin2q.dtsi                             | 6 ------
 arch/arm/boot/dts/socfpga.dtsi                              | 3 ---
 arch/arm/boot/dts/socfpga_arria10.dtsi                      | 3 ---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi           | 2 --
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi                  | 1 -
 arch/arm64/boot/dts/apm/apm-storm.dtsi                      | 1 -
 arch/arm64/boot/dts/bitmain/bm1880.dtsi                     | 3 ---
 arch/arm64/boot/dts/hisilicon/hip05.dtsi                    | 2 --
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 --
 arch/arm64/boot/dts/synaptics/as370.dtsi                    | 2 --
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi                | 6 ------
 14 files changed, 48 deletions(-)
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/8 ARM: dts: berlin: Remove compatible string from dw apb gpio port

The compatible string is never used.

---
 arch/arm/boot/dts/berlin2.dtsi   | 6 ------
 arch/arm/boot/dts/berlin2cd.dtsi | 6 ------
 arch/arm/boot/dts/berlin2q.dtsi  | 6 ------
 3 files changed, 18 deletions(-)
arch/arm/boot/dts/berlin2.dtsi +0 -6
index 6194857f8a02..02c9b8b5b633 100644
@@ -188,7 +188,6 @@ gpio0: gpio@400 {
 				#size-cells = <0>;
 
 				porta: gpio-port@0 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -206,7 +205,6 @@ gpio1: gpio@800 {
 				#size-cells = <0>;
 
 				portb: gpio-port@1 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -224,7 +222,6 @@ gpio2: gpio@c00 {
 				#size-cells = <0>;
 
 				portc: gpio-port@2 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -242,7 +239,6 @@ gpio3: gpio@1000 {
 				#size-cells = <0>;
 
 				portd: gpio-port@3 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -443,7 +439,6 @@ sm_gpio1: gpio@5000 {
 				#size-cells = <0>;
 
 				portf: gpio-port@5 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -458,7 +453,6 @@ sm_gpio0: gpio@c000 {
 				#size-cells = <0>;
 
 				porte: gpio-port@4 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
arch/arm/boot/dts/berlin2cd.dtsi +0 -6
index 6f30d7eb3b41..f7698ab97abf 100644
@@ -178,7 +178,6 @@ gpio0: gpio@400 {
 				#size-cells = <0>;
 
 				porta: gpio-port@0 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -196,7 +195,6 @@ gpio1: gpio@800 {
 				#size-cells = <0>;
 
 				portb: gpio-port@1 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -214,7 +212,6 @@ gpio2: gpio@c00 {
 				#size-cells = <0>;
 
 				portc: gpio-port@2 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -232,7 +229,6 @@ gpio3: gpio@1000 {
 				#size-cells = <0>;
 
 				portd: gpio-port@3 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -470,7 +466,6 @@ sm_gpio1: gpio@5000 {
 				#size-cells = <0>;
 
 				portf: gpio-port@5 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
@@ -515,7 +510,6 @@ sm_gpio0: gpio@c000 {
 				#size-cells = <0>;
 
 				porte: gpio-port@4 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <8>;
arch/arm/boot/dts/berlin2q.dtsi +0 -6
index b6a0acac6836..831505b47e27 100644
@@ -249,7 +249,6 @@ gpio0: gpio@400 {
 				#size-cells = <0>;
 
 				porta: gpio-port@0 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -267,7 +266,6 @@ gpio1: gpio@800 {
 				#size-cells = <0>;
 
 				portb: gpio-port@1 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -285,7 +283,6 @@ gpio2: gpio@c00 {
 				#size-cells = <0>;
 
 				portc: gpio-port@2 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -303,7 +300,6 @@ gpio3: gpio@1000 {
 				#size-cells = <0>;
 
 				portd: gpio-port@3 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -549,7 +545,6 @@ sm_gpio1: gpio@5000 {
 				#size-cells = <0>;
 
 				portf: gpio-port@5 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -610,7 +605,6 @@ sm_gpio0: gpio@c000 {
 				#size-cells = <0>;
 
 				porte: gpio-port@4 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
Signature · 1 line
2.28.0
#2 lore raw

PATCH 2/8 ARM: dts: socfpga: Remove compatible string from dw apb gpio port

In reply to Jisheng Zhang

The compatible string is never used.

---
 arch/arm/boot/dts/socfpga.dtsi                    | 3 ---
 arch/arm/boot/dts/socfpga_arria10.dtsi            | 3 ---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 --
 3 files changed, 8 deletions(-)
arch/arm/boot/dts/socfpga.dtsi +0 -3
index 0b021eef0b53..2c06f1fa3d26 100644
@@ -609,7 +609,6 @@ gpio0: gpio@ff708000 {
 			status = "disabled";
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <29>;
@@ -630,7 +629,6 @@ gpio1: gpio@ff709000 {
 			status = "disabled";
 
 			portb: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <29>;
@@ -651,7 +649,6 @@ gpio2: gpio@ff70a000 {
 			status = "disabled";
 
 			portc: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <27>;
arch/arm/boot/dts/socfpga_arria10.dtsi +0 -3
index 0013ec3463c4..a52132d3c62f 100644
@@ -488,7 +488,6 @@ gpio0: gpio@ffc02900 {
 			status = "disabled";
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <29>;
@@ -508,7 +507,6 @@ gpio1: gpio@ffc02a00 {
 			status = "disabled";
 
 			portb: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <29>;
@@ -528,7 +526,6 @@ gpio2: gpio@ffc02b00 {
 			status = "disabled";
 
 			portc: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <27>;
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +0 -2
index a6fb01c7ab34..5da1a69d6e1d 100644
@@ -200,7 +200,6 @@ gpio0: gpio@ffc03200 {
 			status = "disabled";
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <24>;
@@ -220,7 +219,6 @@ gpio1: gpio@ffc03300 {
 			status = "disabled";
 
 			portb: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <24>;
Signature · 1 line
2.28.0
#3 lore raw

PATCH 3/8 arm64: dts: apm: remove compatible string from dw apb gpio port

In reply to Jisheng Zhang

The compatible string is never used.

---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi +0 -1
index 3feb1881bbc2..cc4265cc13f6 100644
@@ -714,7 +714,6 @@ dwgpio: gpio@1c024000 {
 			#size-cells = <0>;
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				snps,nr-gpios = <32>;
 				reg = <0>;
arch/arm64/boot/dts/apm/apm-storm.dtsi +0 -1
index 8c802d87e751..64b86b9d1b37 100644
@@ -830,7 +830,6 @@ dwgpio: gpio@1c024000 {
 			#size-cells = <0>;
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				snps,nr-gpios = <32>;
 				reg = <0>;
Signature · 1 line
2.28.0
#4 lore raw

PATCH 4/8 arm64: dts: bitmain: Remove compatible string from dw apb gpio port

In reply to Jisheng Zhang

The compatible string is never used.

---
 arch/arm64/boot/dts/bitmain/bm1880.dtsi | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/boot/dts/bitmain/bm1880.dtsi +0 -3
index fa6e6905f588..f80373358bba 100644
@@ -124,7 +124,6 @@ gpio0: gpio@50027000 {
 			reg = <0x0 0x50027000 0x0 0x400>;
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <32>;
@@ -142,7 +141,6 @@ gpio1: gpio@50027400 {
 			reg = <0x0 0x50027400 0x0 0x400>;
 
 			portb: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <32>;
@@ -160,7 +158,6 @@ gpio2: gpio@50027800 {
 			reg = <0x0 0x50027800 0x0 0x400>;
 
 			portc: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <8>;
Signature · 1 line
2.28.0
#5 lore raw

PATCH 5/8 arm64: dts: hip05: Remove compatible string from dw apb gpio port

In reply to Jisheng Zhang

The compatible string is never used.

---
 arch/arm64/boot/dts/hisilicon/hip05.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/hisilicon/hip05.dtsi +0 -2
index bc49955360db..390225f8979c 100644
@@ -332,7 +332,6 @@ peri_gpio0: gpio@802e0000 {
 			status = "disabled";
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <32>;
@@ -351,7 +350,6 @@ peri_gpio1: gpio@802f0000 {
 			status = "disabled";
 
 			portb: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <32>;
Signature · 1 line
2.28.0
#6 lore raw

PATCH 6/8 arm: dts: socfpga: Remove compatible string from dw apb gpio port

In reply to Jisheng Zhang

The compatible string is never used.

---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +0 -2
index 9d7f19e97df7..757c53ffe345 100644
@@ -199,7 +199,6 @@ gpio0: gpio@ffc03200 {
 			status = "disabled";
 
 			porta: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <24>;
@@ -219,7 +218,6 @@ gpio1: gpio@ffc03300 {
 			status = "disabled";
 
 			portb: gpio-controller@0 {
-				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
 				snps,nr-gpios = <24>;
Signature · 1 line
2.28.0
#7 lore raw

PATCH 7/8 arm64: dts: synaptics: Remove compatible string from dw apb gpio port

In reply to Jisheng Zhang

The compatible string is never used.

---
 arch/arm64/boot/dts/synaptics/as370.dtsi     | 2 --
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi | 6 ------
 2 files changed, 8 deletions(-)
arch/arm64/boot/dts/synaptics/as370.dtsi +0 -2
index addeb0efc616..f29b21f930b9 100644
@@ -140,7 +140,6 @@ gpio0: gpio@1800 {
 				#size-cells = <0>;
 
 				porta: gpio-port@0 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -158,7 +157,6 @@ gpio1: gpio@2000 {
 				#size-cells = <0>;
 
 				portb: gpio-port@1 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
arch/arm64/boot/dts/synaptics/berlin4ct.dtsi +0 -6
index 15625b99e336..4b563c0e015e 100644
@@ -137,7 +137,6 @@ gpio0: gpio@400 {
 				#size-cells = <0>;
 
 				porta: gpio-port@0 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -155,7 +154,6 @@ gpio1: gpio@800 {
 				#size-cells = <0>;
 
 				portb: gpio-port@1 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -173,7 +171,6 @@ gpio2: gpio@c00 {
 				#size-cells = <0>;
 
 				portc: gpio-port@2 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -191,7 +188,6 @@ gpio3: gpio@1000 {
 				#size-cells = <0>;
 
 				portd: gpio-port@3 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -266,7 +262,6 @@ sm_gpio0: gpio@8000 {
 				#size-cells = <0>;
 
 				porte: gpio-port@4 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
@@ -281,7 +276,6 @@ sm_gpio1: gpio@9000 {
 				#size-cells = <0>;
 
 				portf: gpio-port@5 {
-					compatible = "snps,dw-apb-gpio-port";
 					gpio-controller;
 					#gpio-cells = <2>;
 					snps,nr-gpios = <32>;
Signature · 1 line
2.28.0
#8 lore raw

PATCH 8/8 dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

In reply to Jisheng Zhang

The compatible string is never used.

---
 Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 -----
 1 file changed, 5 deletions(-)
Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +0 -5
index 1240f6289249..76e7b07d592f 100644
@@ -50,9 +50,6 @@ patternProperties:
   "^gpio-(port|controller)@[0-9a-f]+$":
     type: object
     properties:
-      compatible:
-        const: snps,dw-apb-gpio-port
-
       reg:
         maxItems: 1
 
@@ -111,7 +108,6 @@ examples:
       #size-cells = <0>;
 
       porta: gpio-port@0 {
-        compatible = "snps,dw-apb-gpio-port";
         reg = <0>;
         gpio-controller;
         #gpio-cells = <2>;
@@ -123,7 +119,6 @@ examples:
       };
 
       portb: gpio-port@1 {
-        compatible = "snps,dw-apb-gpio-port";
         reg = <1>;
         gpio-controller;
         #gpio-cells = <2>;
Signature · 1 line
2.28.0
#9 lore raw

Re: [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

Quoted 1 line · Jisheng Zhang

The compatible string is never used.

Before sending v2 could you run "make dt_binding_check" for the DT schema modified in this patch? Like this:

make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml

Quoted 11 lines
---
 Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 -----
 1 file changed, 5 deletions(-)
Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +0 -0
index 1240f6289249..76e7b07d592f 100644

Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml patternProperties: · line 56

Quoted 7 lines
Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +0 -3
@@ -50,9 +50,6 @@ patternProperties:
   "^gpio-(port|controller)@[0-9a-f]+$":
     type: object
     properties:
 
-      compatible:
-        const: snps,dw-apb-gpio-port
-

Yep, you've removed the "compatible" property but forgot to do the same from the "required:" property of the sub-nodes schema. That's why the suggested make-command above would have failed during the DT schema examples validation if you ran it. Please, fix it and resend the series.

Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml patternProperties: · line 54

Quoted 2 lines
Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +0 -0
       reg:
         maxItems: 1

Yeah. Here I've forgotten to add the "reg" property constraints. Since certainly the controller won't have more than four sub-nodes by design, could you add one in an additional patch of the series since you'll need to resend the patchset anyway? Like this:
reg:

-        maxItems: 1
+        minimum: 0
+        maximum: 3

-Sergey

Quoted 20 lines
Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml +0 -2
@@ -111,7 +108,6 @@ examples:
       #size-cells = <0>;
 
       porta: gpio-port@0 {
-        compatible = "snps,dw-apb-gpio-port";
         reg = <0>;
         gpio-controller;
         #gpio-cells = <2>;
@@ -123,7 +119,6 @@ examples:
       };
 
       portb: gpio-port@1 {
-        compatible = "snps,dw-apb-gpio-port";
         reg = <1>;
         gpio-controller;
         #gpio-cells = <2>;
Signature · 1 line
2.28.0
#10 lore raw

Re: [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

Quoted 7 lines · Serge Semin
Quoted 1 line · Jisheng Zhang

The compatible string is never used.

Before sending v2 could you run "make dt_binding_check" for the DT schema modified in this patch? Like this:

make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml

Do you really need to install all cross compilation tools for that? I think it should simple work as

% make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#11 lore raw

Re: [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Serge Semin
Quoted 1 line · Jisheng Zhang

The compatible string is never used.

Before sending v2 could you run "make dt_binding_check" for the DT schema modified in this patch? Like this:

Quoted 8 lines
Quoted 1 line

make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml

Do you really need to install all cross compilation tools for that? I think it should simple work as

% make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml

Of course you don't. I just cited my normal command. Your version should be enough to perform the bindings file validation. Note that there are host tools/libs requirements, which need to be satisfied to make that command working. See the next file for details:
Documentation/devicetree/writing-schema.rst

-Sergey

Quoted 4 lines
Signature · 3 lines
-- 
With Best Regards,
Andy Shevchenko
#12 lore raw
In reply to Jisheng Zhang

Hello Jisheng,

Thanks for sending this cleanup and for the work you've done in its framework. The compatible property is indeed redundant in the DW APB GPIO bindings, because any sub-node is considered as one of the device port from the set {A,B,C,D} and I don't see why would we need to be there for anything else. The port index is initialized by the reg property, which I've just realized lack of a proper constraints.

Anyway see my comment to the DT binding file. The rest of the series is up to the corresponding subsystem maintainers.

-Sergey

Quoted 31 lines · Jisheng Zhang

The "snps,dw-apb-gpio-port" is never used.

Jisheng Zhang (8):
ARM: dts: berlin: Remove compatible string from dw apb gpio port
ARM: dts: socfpga: Remove compatible string from dw apb gpio port
arm64: dts: apm: remove compatible string from dw apb gpio port
arm64: dts: bitmain: Remove compatible string from dw apb gpio port
arm64: dts: hip05: Remove compatible string from dw apb gpio port
arm: dts: socfpga: Remove compatible string from dw apb gpio port
arm64: dts: synaptics: Remove compatible string from dw apb gpio port
dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"

 .../devicetree/bindings/gpio/snps,dw-apb-gpio.yaml          | 5 -----
 arch/arm/boot/dts/berlin2.dtsi                              | 6 ------
 arch/arm/boot/dts/berlin2cd.dtsi                            | 6 ------
 arch/arm/boot/dts/berlin2q.dtsi                             | 6 ------
 arch/arm/boot/dts/socfpga.dtsi                              | 3 ---
 arch/arm/boot/dts/socfpga_arria10.dtsi                      | 3 ---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi           | 2 --
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi                  | 1 -
 arch/arm64/boot/dts/apm/apm-storm.dtsi                      | 1 -
 arch/arm64/boot/dts/bitmain/bm1880.dtsi                     | 3 ---
 arch/arm64/boot/dts/hisilicon/hip05.dtsi                    | 2 --
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 --
 arch/arm64/boot/dts/synaptics/as370.dtsi                    | 2 --
 arch/arm64/boot/dts/synaptics/berlin4ct.dtsi                | 6 ------
 14 files changed, 48 deletions(-)
Signature · 1 line
2.28.0