Skip to contentSkip to conversation

drm/amd/display: Fix incorrect dsc force enable logic

PATCH In review Eryk Brol 2 participants 2 messages Oct 15, 2020

Subsystems (3)
lore
Share & tools
lore

Eryk Brol

author
#0 lore raw

PATCH 1/1 drm/amd/display: Fix incorrect dsc force enable logic

[Why]
Missed removing a '!' which results in incorrect behavior

[How]
Remove the offending '!'

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +1 -1
index 98b4d5e2e336..fc87b9faec92 100644
@@ -644,7 +644,7 @@ static void try_disable_dsc(struct drm_atomic_state *state,
 	for (i = 0; i < count; i++) {
 		if (vars[i].dsc_enabled
 				&& vars[i].bpp_x16 == params[i].bw_range.max_target_bpp_x16
-				&& !params[i].clock_force_enable == DSC_CLK_FORCE_DEFAULT) {
+				&& params[i].clock_force_enable == DSC_CLK_FORCE_DEFAULT) {
 			kbps_increase[i] = params[i].bw_range.stream_kbps - params[i].bw_range.max_kbps;
 			tried[i] = false;
 			remaining_to_try += 1;
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Eryk Brol

[Why]
Missed removing a '!' which results in incorrect behavior

[How]
Remove the offending '!'

Harry

Quoted 10 lines
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +0 -0
index 98b4d5e2e336..fc87b9faec92 100644

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c static void try_disable_dsc(struct drm_atomic_state *state, · line 650

Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +1 -1
@@ -644,7 +644,7 @@ static void try_disable_dsc(struct drm_atomic_state *state,
  	for (i = 0; i < count; i++) {
  		if (vars[i].dsc_enabled
  				&& vars[i].bpp_x16 == params[i].bw_range.max_target_bpp_x16
-				&& !params[i].clock_force_enable == DSC_CLK_FORCE_DEFAULT) {
+				&& params[i].clock_force_enable == DSC_CLK_FORCE_DEFAULT) {
  			kbps_increase[i] = params[i].bw_range.stream_kbps - params[i].bw_range.max_kbps;
  			tried[i] = false;
  			remaining_to_try += 1;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx