usb: gadget: fsl: fix null pointer checking
Subsystems (2)
PATCH 1/1 usb: gadget: fsl: fix null pointer checking
fsl_ep_fifo_status() should return error if _ep->desc is null.
Fixes 75eaa498c99e (“usb: gadget: Correct NULL pointer checking in fsl gadget”)
Signed-off-by Ran Wang <[email protected]>
--- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/fsl_udc_core.c +1 -1
@@ -1051,7 +1051,7 @@ static int fsl_ep_fifo_status(struct usb_ep *_ep)u32 bitmask;struct ep_queue_head *qh; -if (!_ep || _ep->desc || !(_ep->desc->bEndpointAddress&0xF )) +if (!_ep || !_ep->desc || !(_ep->desc->bEndpointAddress&0xF ))return -ENODEV ; ep = container_of(_ep, struct fsl_ep, ep);
Signature · 1 line
2.7.4
Quoted 15 lines
Fixes 75eaa498c99e (“usb: gadget: Correct NULL pointer checking in fslgadget”)
Signed-off-by Ran Wang <[email protected]>--- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/gadget/udc/fsl_udc_core.c +0
-0
drivers/usb/gadget/udc/fsl_udc_core.c static int fsl_ep_fifo_status(struct usb_ep *_ep) · line 1056
Quoted 7 lines
drivers/usb/gadget/udc/fsl_udc_core.c +1
-1@@ -1051,7 +1051,7 @@ static int fsl_ep_fifo_status(struct usb_ep *_ep)u32 bitmask;struct ep_queue_head *qh; -if (!_ep || _ep->desc || !(_ep->desc->bEndpointAddress&0xF )) +if (!_ep || !_ep->desc || !(_ep->desc->bEndpointAddress&0xF ))return -ENODEV ;
Reviewed-by Peter Chen <[email protected]>
Peter