Skip to contentSkip to conversation

watchdog: pnx833x_wdt: convert to watchdog core

PATCH In review Sergey Yasinsky 2 participants 2 messages Oct 16, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 watchdog: pnx833x_wdt: convert to watchdog core

Convert driver from legacy to use the watchdog core and platform driver. Add new pnx833x_wdt_device platform device for pnx833x_wdt driver.

---
 arch/mips/pnx833x/common/platform.c |   6 +
 drivers/watchdog/Kconfig            |   2 +-
 drivers/watchdog/pnx833x_wdt.c      | 244 +++++++++-------------------
 3 files changed, 80 insertions(+), 172 deletions(-)
arch/mips/pnx833x/common/platform.c +6 -0
index 5fa0373f1c9e..3371f860efc2 100644
@@ -207,12 +207,18 @@ static struct platform_device pnx833x_flash_nand = {
 	},
 };
 
+static struct platform_device pnx833x_wdt_device = {
+	.name		= "pnx833x_wdt",
+	.id		= -1,
+};
+
 static struct platform_device *pnx833x_platform_devices[] __initdata = {
 	&pnx833x_uart_device,
 	&pnx833x_usb_ehci_device,
 	&pnx833x_ethernet_device,
 	&pnx833x_sata_device,
 	&pnx833x_flash_nand,
+	&pnx833x_wdt_device,
 };
 
 static int __init pnx833x_platform_init(void)
drivers/watchdog/Kconfig +1 -1
index ab7aad5a1e69..e9b86dbbb8fa 100644
@@ -1686,7 +1686,7 @@ config WDT_MTX1
 config PNX833X_WDT
 	tristate "PNX833x Hardware Watchdog"
 	depends on SOC_PNX8335
-	depends on BROKEN
+	select WATCHDOG_CORE
 	help
 	  Hardware driver for the PNX833x's watchdog. This is a
 	  watchdog timer that will reboot the machine after a programmable
drivers/watchdog/pnx833x_wdt.c +73 -171

321 lines not on this page · raw message

Signature · 1 line
2.26.2
#1 lore raw
Quoted 2 lines · Sergey Yasinsky

Convert driver from legacy to use the watchdog core and platform driver. Add new pnx833x_wdt_device platform device for pnx833x_wdt driver.

thank you for your patch, but pnx833x platform has been already removed in mips-next tree (which will be merged into v5.10 soon) and I have a patch to remove the watchdog driver waiting for submission...

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]