ethdev: move queue stats to xstats
Subsystems (3)
RFC 1/2 ethdev: move queue stats to xstats
Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.
As a result of technical board discussion, decided to remove the queue statistics from 'struct rte_eth_stats' in the long term.
Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using the basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, a temporary 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag is created. The PMDs providing the queue stats in the xstats should set this flag to bypass the relevant part in ethdev layer.
When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.
--- lib/librte_ethdev/rte_ethdev.c | 19 +++++++++++++++---- lib/librte_ethdev/rte_ethdev.h | 2 ++ 2 files changed, 17 insertions(+), 4 deletions(-)
lib/librte_ethdev/rte_ethdev.c +15 -4
@@ -2446,8 +2446,10 @@ get_xstats_basic_count(struct rte_eth_dev *dev) nb_txqs =RTE_MIN (dev->data->nb_tx_queues,RTE_ETHDEV_QUEUE_STAT_CNTRS ); count =RTE_NB_STATS ; - count += nb_rxqs *RTE_NB_RXQ_STATS ; - count += nb_txqs *RTE_NB_TXQ_STATS ; +if ((dev->data->dev_flags &RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS ) ==0 ) { + count += nb_rxqs *RTE_NB_RXQ_STATS ; + count += nb_txqs *RTE_NB_TXQ_STATS ; + }return count; }
@@ -2538,6 +2540,10 @@ rte_eth_basic_stats_get_names(struct rte_eth_dev *dev, sizeof(xstats_names[0].name)); cnt_used_entries++; } + +if (dev->data->dev_flags &RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS ) +return cnt_used_entries; + num_q =RTE_MIN (dev->data->nb_rx_queues,RTE_ETHDEV_QUEUE_STAT_CNTRS );for (id_queue =0 ; id_queue < num_q; id_queue++) {for (idx =0 ; idx <RTE_NB_RXQ_STATS ; idx++) {
@@ -2736,6 +2742,9 @@ rte_eth_basic_stats_get(uint16_t port_id, struct rte_eth_xstat *xstats) xstats[count++].value = val; } +if (dev->data->dev_flags &RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS ) +return count; +/* per-rxq stats */ for (q =0 ; q < nb_rxqs; q++) {for (i =0 ; i <RTE_NB_RXQ_STATS ; i++) {
@@ -2871,8 +2880,10 @@ rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats, nb_txqs =RTE_MIN (dev->data->nb_tx_queues,RTE_ETHDEV_QUEUE_STAT_CNTRS );/* Return generic statistics */ - count =RTE_NB_STATS + (nb_rxqs *RTE_NB_RXQ_STATS ) + - (nb_txqs *RTE_NB_TXQ_STATS ); + count =RTE_NB_STATS ; +if ((dev->data->dev_flags &RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS ) ==0 ) + count += (nb_rxqs *RTE_NB_RXQ_STATS ) + + (nb_txqs *RTE_NB_TXQ_STATS );/* implemented by the driver */ if (dev->dev_ops->xstats_get !=NULL ) {
lib/librte_ethdev/rte_ethdev.h +2 -0
@@ -1694,6 +1694,8 @@ struct rte_eth_dev_owner {#define RTE_ETH_DEV_REPRESENTOR 0x0010/** Device does not support MAC change after started */ #define RTE_ETH_DEV_NOLIVE_MAC_ADDR 0x0020 +/** Device provides queue stats in xstats */ +#define RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS 0x0040/** * Iterates over valid ethdev ports owned by a specific owner.
Signature · 1 line
2.26.2
RFC 2/2 doc: announce queue stats moving to xstats
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag created. PMDs switched to the xstats should set this flag to bypass ethdev layer for queue stats.
--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
config/rte_config.h +1 -1
@@ -55,7 +55,7 @@/* ether defines */ #define RTE_MAX_QUEUES_PER_PORT 1024 -#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 +#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16/* max 256 */ #define RTE_ETHDEV_RXTX_CALLBACKS 1/* cryptodev defines */
doc/guides/rel_notes/deprecation.rst +7 -0
@@ -164,6 +164,13 @@ Deprecation Notices following the IPv6 header, as proposed in RFC https://mails.dpdk.org/archives/dev/2020-August/177257.html. +* ethdev: Queue specific stats fields will be removed from ``struct rte_eth_stats``. + Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``, + ``q_errors``. + Instead queue stats will be received via xstats API. Current method support + will be limited to maximum 256 queues. + Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. + * security: The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to
lib/librte_ethdev/rte_ethdev.h +3 -0
@@ -253,6 +253,7 @@ struct rte_eth_stats {uint64_t ierrors;/**< Total number of erroneous received packets. */ uint64_t oerrors;/**< Total number of failed transmitted packets. */ uint64_t rx_nombuf;/**< Total number of RX mbuf allocation failures. */ +/* Queue stats are limited to max 256 queues */ uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS ];/**< Total number of queue RX packets. */ uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS ];
@@ -2701,6 +2702,7 @@ int rte_eth_xstats_reset(uint16_t port_id);* The per-queue packet statistics functionality number that the transmit * queue is to be assigned. * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. +* Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. * @return * Zero if successful. Non-zero otherwise. */
@@ -2721,6 +2723,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id,* The per-queue packet statistics functionality number that the receive * queue is to be assigned. * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. +* Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. * @return * Zero if successful. Non-zero otherwise. */
Signature · 1 line
2.26.2
Re: [dpdk-dev] [dpdk-techboard] [RFC 2/2] doc: announce queue stats moving to xstats
Quoted 11 lines · On Mon, 12 Oct 2020 17:46:01 +0100 Ferruh Yigit <[email protected]> wrote:
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag created. PMDs switched to the xstats should set this flag to bypass ethdev layer for queue stats.Signed-off-by Ferruh Yigit <[email protected]>
Maybe we need to have better API's to query per queue? For example, there is no way to query if queue is started or not.
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Yes
Quoted 1 line
Currently queue stats in the xstats are filled by ethdev layer, using
"some basic" queue stats
Quoted 18 lines
the basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, a temporary '
RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag is created. The PMDs providing the queue stats in the xstats should set this flag to bypass the relevant part in ethdev layer.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.Signed-off-by Ferruh Yigit <[email protected]>---
lib/librte_ethdev/rte_ethdev.h struct rte_eth_dev_owner { · line 1698
Quoted 2 lines
lib/librte_ethdev/rte_ethdev.h +2
-0+/** Device provides queue stats in xstats */ +#define RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS 0x0040
Not exact wording here and in the title.
We should try to convey the idea that the basic queue stats are not automatically converted from the array to some xstats. Something like RTE_ETH_DEV_NO_AUTOFILL_QUEUE_XSTATS
Or we can define the opposite flag and set it by default in all drivers which fill the basic queue stats. I suggest RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS
Quoted 11 lines · Thomas Monjalon
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Yes
I like Stephen's idea to have dedicated API to get stats per queue. Of course it is doable via getting xstats by IDs, but IMHO it is over-complicated. From the other hand it sounds like a duplication to have it in xstats and dedicated API (basically the same as we have for basic stats and xstats).
13/10/2020 10:31, Andrew Rybchenko:
Quoted 11 lines · Thomas Monjalon
Quoted 10 lines
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Quoted 8 lines
Quoted 1 line
Yes
I like Stephen's idea to have dedicated API to get stats per queue. Of course it is doable via getting xstats by IDs, but IMHO it is over-complicated. From the other hand it sounds like a duplication to have it in xstats and dedicated API (basically the same as we have for basic stats and xstats).
Please read my proposal to have fixed ids for common stats and fixed id ranges for stats per queue:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
(slide 11)
Quoted 21 lines · Thomas Monjalon
13/10/2020 10:31, Andrew Rybchenko:
Quoted 11 lines · Thomas Monjalon
Quoted 10 lines
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Quoted 8 lines
Quoted 1 line
Yes
I like Stephen's idea to have dedicated API to get stats per queue. Of course it is doable via getting xstats by IDs, but IMHO it is over-complicated. From the other hand it sounds like a duplication to have it in xstats and dedicated API (basically the same as we have for basic stats and xstats).
Quoted 5 lines
Please read my proposal to have fixed ids for common stats and fixed id ranges for stats per queue:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
(slide 11)
Ah, yes, I forgot that point. Makes sense and LGTM.
Quoted 22 lines · Andrew Rybchenko
Quoted 21 lines · Thomas Monjalon
13/10/2020 10:31, Andrew Rybchenko:
Quoted 19 lines · Thomas Monjalon
Quoted 11 lines
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Yes
I like Stephen's idea to have dedicated API to get stats per queue. Of course it is doable via getting xstats by IDs, but IMHO it is over-complicated. From the other hand it sounds like a duplication to have it in xstats and dedicated API (basically the same as we have for basic stats and xstats).
Quoted 8 lines
Quoted 5 lines
Please read my proposal to have fixed ids for common stats and fixed id ranges for stats per queue:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
(slide 11)Ah, yes, I forgot that point. Makes sense and LGTM.
But we don't have (and not planned for) the fixed id ranges in the xstats yes, and agree it will be complicated to parse the queue stats from xstats without it.
Should we wait for the fixed id ranges change before we continue with this patch?
Quoted 21 lines · On Tue, 13 Oct 2020 11:05:07 +0200 Thomas Monjalon <[email protected]> wrote:
13/10/2020 10:31, Andrew Rybchenko:
Quoted 11 lines · Thomas Monjalon
Quoted 10 lines
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Quoted 8 lines
Quoted 1 line
Yes
I like Stephen's idea to have dedicated API to get stats per queue. Of course it is doable via getting xstats by IDs, but IMHO it is over-complicated. From the other hand it sounds like a duplication to have it in xstats and dedicated API (basically the same as we have for basic stats and xstats).
Quoted 6 lines
Please read my proposal to have fixed ids for common stats and fixed id ranges for stats per queue:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
(slide 11)
Looks good. if id's are known than should be possible to go from port/queue to xstats id.
FYI - the inclusion of CRC in counters goes back to a Cisco vs Juniper fight. Cisco has more people wasting time on standards committees so they always get their way into the standards bodies.
Quoted 42 lines · Thomas Monjalon
12/10/2020 18:46, Ferruh Yigit:
Quoted 8 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Yes
Quoted 1 line
Currently queue stats in the xstats are filled by ethdev layer, using
"some basic" queue stats
Quoted 18 lines
the basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, a temporary '
RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' device flag is created. The PMDs providing the queue stats in the xstats should set this flag to bypass the relevant part in ethdev layer.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.Signed-off-by Ferruh Yigit <[email protected]>---
lib/librte_ethdev/rte_ethdev.h struct rte_eth_dev_owner { · line 1698
Quoted 2 lines
lib/librte_ethdev/rte_ethdev.h +2
-0+/** Device provides queue stats in xstats */ +#define RTE_ETH_DEV_QUEUE_STATS_IN_XSTATS 0x0040Not exact wording here and in the title.
We should try to convey the idea that the basic queue stats are not automatically converted from the array to some xstats. Something likeRTE_ETH_DEV_NO_AUTOFILL_QUEUE_XSTATS
Quoted 4 lines
Or we can define the opposite flag and set it by default in all drivers which fill the basic queue stats. I suggest
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS
Agree that opposite flag makes it easier to traces the PMDs missing implementation, will send another RFC with it.
RFC v2 1/2 ethdev: provide device flag to bypass ethdev queue xstats
In reply to Ferruh YigitQueue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.
As a result of technical board discussion, decided to remove the queue statistics from 'struct rte_eth_stats' in the long term.
Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.
When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.
--- drivers/net/af_packet/rte_eth_af_packet.c | 1 + drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + drivers/net/ark/ark_ethdev.c | 2 ++ drivers/net/atlantic/atl_ethdev.c | 2 ++ drivers/net/avp/avp_ethdev.c | 1 + drivers/net/axgbe/axgbe_ethdev.c | 2 ++ drivers/net/bnx2x/bnx2x_ethdev.c | 1 + drivers/net/bnxt/bnxt_ethdev.c | 1 + drivers/net/bnxt/bnxt_reps.c | 3 ++- drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- drivers/net/cxgbe/cxgbe_ethdev.c | 2 ++ drivers/net/dpaa/dpaa_ethdev.c | 2 ++ drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++ drivers/net/e1000/em_ethdev.c | 1 + drivers/net/e1000/igb_ethdev.c | 2 ++ drivers/net/ena/ena_ethdev.c | 2 ++ drivers/net/enetc/enetc_ethdev.c | 2 ++ drivers/net/enic/enic_ethdev.c | 1 + drivers/net/enic/enic_vf_representor.c | 3 ++- drivers/net/failsafe/failsafe.c | 3 ++- drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/hinic/hinic_pmd_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_vf_representor.c | 3 ++- drivers/net/iavf/iavf_ethdev.c | 1 + drivers/net/ice/ice_dcf_ethdev.c | 2 ++ drivers/net/ice/ice_ethdev.c | 2 ++ drivers/net/igc/igc_ethdev.c | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ipn3ke/ipn3ke_representor.c | 3 ++- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ drivers/net/kni/rte_eth_kni.c | 1 + drivers/net/liquidio/lio_ethdev.c | 1 + drivers/net/memif/rte_eth_memif.c | 1 + drivers/net/mlx4/mlx4.c | 1 + drivers/net/mlx5/linux/mlx5_os.c | 1 + drivers/net/mvneta/mvneta_ethdev.c | 1 + drivers/net/mvpp2/mrvl_ethdev.c | 1 + drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/nfb/nfb_ethdev.c | 2 ++ drivers/net/nfp/nfp_net.c | 2 ++ drivers/net/null/rte_eth_null.c | 1 + drivers/net/octeontx/octeontx_ethdev.c | 1 + drivers/net/octeontx2/otx2_ethdev.c | 1 + drivers/net/pcap/rte_eth_pcap.c | 1 + drivers/net/pfe/pfe_ethdev.c | 2 ++ drivers/net/qede/qede_ethdev.c | 1 + drivers/net/ring/rte_eth_ring.c | 1 + drivers/net/sfc/sfc_ethdev.c | 1 + drivers/net/szedata2/rte_eth_szedata2.c | 2 ++ drivers/net/tap/rte_eth_tap.c | 3 ++- drivers/net/thunderx/nicvf_ethdev.c | 1 + drivers/net/vhost/rte_eth_vhost.c | 3 ++- drivers/net/virtio/virtio_ethdev.c | 2 ++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + lib/librte_ethdev/rte_ethdev.c | 18 ++++++++++++++---- lib/librte_ethdev/rte_ethdev.h | 5 +++++ 60 files changed, 106 insertions(+), 12 deletions(-)
drivers/net/af_packet/rte_eth_af_packet.c +1 -0
@@ -859,6 +859,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, data->nb_tx_queues = (uint16_t )nb_queues; data->dev_link = pmd_link; data->mac_addrs = &(*internals)->eth_addr; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; (*eth_dev)->dev_ops = &ops;
drivers/net/af_xdp/rte_eth_af_xdp.c +1 -0
@@ -1561,6 +1561,7 @@ init_internals(struct rte_vdev_device *dev, const char *if_name, eth_dev->data->dev_private = internals; eth_dev->data->dev_link = pmd_link; eth_dev->data->mac_addrs = &internals->eth_addr; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->dev_ops = &ops; eth_dev->rx_pkt_burst = eth_af_xdp_rx; eth_dev->tx_pkt_burst = eth_af_xdp_tx;
drivers/net/ark/ark_ethdev.c +2 -0
@@ -256,6 +256,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev)return ret; pci_dev =RTE_ETH_DEV_TO_PCI (dev);rte_eth_copy_pci_info (dev, pci_dev); + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Use dummy function until setup */ dev->rx_pkt_burst = ð_ark_recv_pkts_noop;
@@ -383,6 +384,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) eth_dev->rx_pkt_burst = ark->eth_dev->rx_pkt_burst;rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->data->mac_addrs =rte_zmalloc (name,RTE_ETHER_ADDR_LEN ,0 );
drivers/net/atlantic/atl_ethdev.c +2 -0
@@ -380,6 +380,8 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)if (rte_eal_process_type () !=RTE_PROC_PRIMARY )return 0 ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* Vendor and Device ID need to be set before init of shared code */ hw->device_id = pci_dev->id.device_id; hw->vendor_id = pci_dev->id.vendor_id;
drivers/net/avp/avp_ethdev.c +1 -0
@@ -974,6 +974,7 @@ eth_avp_dev_init(struct rte_eth_dev *eth_dev) }rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Check current migration status */ if (avp_dev_migration_pending (eth_dev)) {
drivers/net/axgbe/axgbe_ethdev.c +2 -0
@@ -1970,6 +1970,8 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)if (rte_eal_process_type () !=RTE_PROC_PRIMARY )return 0 ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + pdata = eth_dev->data->dev_private;/* initial state */ rte_bit_relaxed_set32 (AXGBE_DOWN , &pdata->dev_state);
drivers/net/bnx2x/bnx2x_ethdev.c +1 -0
@@ -644,6 +644,7 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf) }rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; sc->pcie_bus = pci_dev->addr.bus; sc->pcie_device = pci_dev->addr.devid;
drivers/net/bnxt/bnxt_ethdev.c +1 -0
@@ -6003,6 +6003,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused)return 0 ;rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; bp = eth_dev->data->dev_private;
drivers/net/bnxt/bnxt_reps.c +2 -1
@@ -184,7 +184,8 @@ int bnxt_representor_init(struct rte_eth_dev *eth_dev, void *params) vf_rep_bp->rep_fc_r2f = rep_params->rep_fc_r2f; vf_rep_bp->rep_fc_f2r = rep_params->rep_fc_f2r; - eth_dev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->data->representor_id = rep_params->vf_id;rte_eth_random_addr (vf_rep_bp->dflt_mac_addr);
drivers/net/bonding/rte_eth_bond_pmd.c +2 -1
@@ -3223,7 +3223,8 @@ bond_alloc(struct rte_vdev_device *dev, uint8_t mode) } eth_dev->dev_ops = &default_dev_ops; - eth_dev->data->dev_flags =RTE_ETH_DEV_INTR_LSC ; + eth_dev->data->dev_flags =RTE_ETH_DEV_INTR_LSC | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;rte_spinlock_init (&internals->lock);rte_spinlock_init (&internals->lsc_lock);
drivers/net/cxgbe/cxgbe_ethdev.c +2 -0
@@ -1260,6 +1260,8 @@ static int eth_cxgbe_dev_init(struct rte_eth_dev *eth_dev)return 0 ; } + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +snprintf (name,sizeof (name),"cxgbeadapter%d" , eth_dev->data->port_id); adapter =rte_zmalloc (name,sizeof (*adapter),0 );if (!adapter)
drivers/net/dpaa/dpaa_ethdev.c +2 -0
@@ -2219,6 +2219,8 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv,if (dpaa_drv->drv_flags &RTE_DPAA_DRV_INTR_LSC ) eth_dev->data->dev_flags |=RTE_ETH_DEV_INTR_LSC ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* Invoke PMD device initialization function */ diag =dpaa_dev_init (eth_dev);if (diag ==0 ) {
drivers/net/dpaa2/dpaa2_ethdev.c +2 -0
@@ -2796,6 +2796,8 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,if (dpaa2_drv->drv_flags &RTE_DPAA2_DRV_INTR_LSC ) eth_dev->data->dev_flags |=RTE_ETH_DEV_INTR_LSC ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* Invoke PMD device initialization function */ diag =dpaa2_dev_init (eth_dev);if (diag ==0 ) {
drivers/net/e1000/em_ethdev.c +1 -0
@@ -265,6 +265,7 @@ eth_em_dev_init(struct rte_eth_dev *eth_dev) }rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->hw_addr = (void *)pci_dev->mem_resource[0 ].addr; hw->device_id = pci_dev->id.device_id;
drivers/net/e1000/igb_ethdev.c +2 -0
@@ -765,6 +765,7 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev) }rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->hw_addr= (void *)pci_dev->mem_resource[0 ].addr;
@@ -959,6 +960,7 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev) pci_dev =RTE_ETH_DEV_TO_PCI (eth_dev);rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->device_id = pci_dev->id.device_id; hw->vendor_id = pci_dev->id.vendor_id;
drivers/net/ena/ena_ethdev.c +2 -0
@@ -1775,6 +1775,8 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)if (rte_eal_process_type () !=RTE_PROC_PRIMARY )return 0 ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +memset (adapter,0 ,sizeof (struct ena_adapter )); ena_dev = &adapter->ena_dev;
drivers/net/enetc/enetc_ethdev.c +2 -0
@@ -881,6 +881,8 @@ enetc_dev_init(struct rte_eth_dev *eth_dev) eth_dev->rx_pkt_burst = &enetc_recv_pkts; eth_dev->tx_pkt_burst = &enetc_xmit_pkts; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* Retrieving and storing the HW base address of device */ hw->hw.reg = (void *)pci_dev->mem_resource[0 ].addr; hw->device_id = pci_dev->id.device_id;
drivers/net/enic/enic_ethdev.c +1 -0
@@ -1298,6 +1298,7 @@ static int eth_enic_dev_init(struct rte_eth_dev *eth_dev, pdev =RTE_ETH_DEV_TO_PCI (eth_dev);rte_eth_copy_pci_info (eth_dev, pdev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; enic->pdev = pdev; addr = &pdev->addr;
drivers/net/enic/enic_vf_representor.c +2 -1
@@ -670,7 +670,8 @@ int enic_vf_representor_init(struct rte_eth_dev *eth_dev, void *init_params) eth_dev->device->driver = pf->rte_dev->device->driver; eth_dev->dev_ops = &enic_vf_representor_dev_ops; - eth_dev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->data->representor_id = vf->vf_id; eth_dev->data->mac_addrs = rte_zmalloc("enic_mac_addr_vf", sizeof(struct rte_ether_addr) *
drivers/net/failsafe/failsafe.c +2 -1
@@ -264,7 +264,8 @@ fs_eth_dev_create(struct rte_vdev_device *vdev) mac->addr_bytes[0 ], mac->addr_bytes[1 ], mac->addr_bytes[2 ], mac->addr_bytes[3 ], mac->addr_bytes[4], mac->addr_bytes[5]); - dev->data->dev_flags |=RTE_ETH_DEV_INTR_LSC ; + dev->data->dev_flags |=RTE_ETH_DEV_INTR_LSC | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;PRIV (dev)->intr_handle = (struct rte_intr_handle ){ .fd =-1 , .type =RTE_INTR_HANDLE_EXT ,
drivers/net/fm10k/fm10k_ethdev.c +1 -0
@@ -3074,6 +3074,7 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev) }rte_eth_copy_pci_info (dev, pdev); + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; macvlan =FM10K_DEV_PRIVATE_TO_MACVLAN (dev->data->dev_private);memset (macvlan,0 ,sizeof (*macvlan));
drivers/net/hinic/hinic_pmd_ethdev.c +2 -0
@@ -3103,6 +3103,8 @@ static int hinic_func_init(struct rte_eth_dev *eth_dev)return 0 ; } + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + nic_dev =HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV (eth_dev);memset (nic_dev,0 ,sizeof (*nic_dev));
drivers/net/hns3/hns3_ethdev.c +2 -0
@@ -6102,6 +6102,8 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)return 0 ; } + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + ret =hns3_mp_init_primary ();if (ret) { PMD_INIT_LOG(ERR,
drivers/net/hns3/hns3_ethdev_vf.c +2 -0
@@ -2749,6 +2749,8 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)return 0 ; } + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + ret =hns3_mp_init_primary ();if (ret) { PMD_INIT_LOG(ERR,
drivers/net/i40e/i40e_ethdev.c +1 -0
@@ -1465,6 +1465,7 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) intr_handle = &pci_dev->intr_handle;rte_eth_copy_pci_info (dev, pci_dev); + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; pf->adapter =I40E_DEV_PRIVATE_TO_ADAPTER (dev->data->dev_private); pf->adapter->eth_dev = dev;
drivers/net/i40e/i40e_ethdev_vf.c +1 -0
@@ -1575,6 +1575,7 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev) }i40e_set_default_ptype_table (eth_dev);rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->vendor_id = pci_dev->id.vendor_id; hw->device_id = pci_dev->id.device_id;
drivers/net/i40e/i40e_vf_representor.c +2 -1
@@ -507,7 +507,8 @@ i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)return -ENODEV ; } - ethdev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR ; + ethdev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; ethdev->data->representor_id = representor->vf_id;/* Setting the number queues allocated to the VF */
drivers/net/iavf/iavf_ethdev.c +1 -0
@@ -1431,6 +1431,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)return 0 ; }rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->vendor_id = pci_dev->id.vendor_id; hw->device_id = pci_dev->id.device_id;
drivers/net/ice/ice_dcf_ethdev.c +2 -0
@@ -908,6 +908,8 @@ ice_dcf_dev_init(struct rte_eth_dev *eth_dev)if (rte_eal_process_type () !=RTE_PROC_PRIMARY )return 0 ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + adapter->real_hw.vc_event_msg_cb = ice_dcf_handle_pf_event_msg;if (ice_dcf_init_hw (eth_dev, &adapter->real_hw) !=0 ) {PMD_INIT_LOG (ERR ,"Failed to init DCF hardware" );
drivers/net/ice/ice_ethdev.c +2 -0
@@ -2137,6 +2137,8 @@ ice_dev_init(struct rte_eth_dev *dev)return 0 ; } + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +ice_set_default_ptype_table (dev); pci_dev =RTE_DEV_TO_PCI (dev->device); intr_handle = &pci_dev->intr_handle;
drivers/net/igc/igc_ethdev.c +1 -0
@@ -1240,6 +1240,7 @@ eth_igc_dev_init(struct rte_eth_dev *dev)return 0 ;rte_eth_copy_pci_info (dev, pci_dev); + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->back = pci_dev; hw->hw_addr = (void *)pci_dev->mem_resource[0 ].addr;
drivers/net/ionic/ionic_ethdev.c +1 -0
@@ -1001,6 +1001,7 @@ eth_ionic_dev_init(struct rte_eth_dev *eth_dev, void *init_params)return 0 ;rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; lif->index = adapter->nlifs; lif->eth_dev = eth_dev;
drivers/net/ipn3ke/ipn3ke_representor.c +2 -1
@@ -2964,7 +2964,8 @@ ipn3ke_rpst_init(struct rte_eth_dev *ethdev, void *init_params)return -ENODEV ; } - ethdev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR ; + ethdev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;rte_spinlock_lock (&ipn3ke_link_notify_list_lk);TAILQ_INSERT_TAIL (&ipn3ke_rpst_list, rpst, next);
drivers/net/ixgbe/ixgbe_ethdev.c +2 -0
@@ -1118,6 +1118,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)rte_atomic32_clear (&ad->link_thread_running);rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Vendor and Device ID need to be set before init of shared code */ hw->device_id = pci_dev->id.device_id;
@@ -1596,6 +1597,7 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev) pci_dev->device.devargs);rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; hw->device_id = pci_dev->id.device_id; hw->vendor_id = pci_dev->id.vendor_id;
drivers/net/kni/rte_eth_kni.c +1 -0
@@ -389,6 +389,7 @@ eth_kni_create(struct rte_vdev_device *vdev, data->mac_addrs = &internals->eth_addr; data->promiscuous =1 ; data->all_multicast =1 ; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;rte_eth_random_addr (internals->eth_addr.addr_bytes);
drivers/net/liquidio/lio_ethdev.c +1 -0
@@ -2090,6 +2090,7 @@ lio_eth_dev_init(struct rte_eth_dev *eth_dev)return 0 ;rte_eth_copy_pci_info (eth_dev, pdev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;if (pdev->mem_resource[0 ].addr) { lio_dev->hw_addr = pdev->mem_resource[0 ].addr;
drivers/net/memif/rte_eth_memif.c +1 -0
@@ -1539,6 +1539,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role, data->dev_link = pmd_link; data->mac_addrs = ether_addr; data->promiscuous =1 ; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->dev_ops = &ops; eth_dev->device = &vdev->device;
drivers/net/mlx4/mlx4.c +1 -0
@@ -1033,6 +1033,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) eth_dev->data->mac_addrs = priv->mac; eth_dev->device = &pci_dev->device;rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Initialize local interrupt handle for current port. */ memset (&priv->intr_handle,0 ,sizeof (struct rte_intr_handle )); priv->intr_handle.fd =-1 ;
drivers/net/mlx5/linux/mlx5_os.c +1 -0
@@ -1263,6 +1263,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, priv->dev_data = eth_dev->data; eth_dev->data->mac_addrs = priv->mac; eth_dev->device = dpdk_dev; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Configure the first MAC address by default. */ if (mlx5_get_mac (eth_dev, &mac.addr_bytes)) { DRV_LOG(ERR,
drivers/net/mvneta/mvneta_ethdev.c +1 -0
@@ -836,6 +836,7 @@ mvneta_eth_dev_create(struct rte_vdev_device *vdev, const char *name) eth_dev->rx_pkt_burst = mvneta_rx_pkt_burst;mvneta_set_tx_function (eth_dev); eth_dev->dev_ops = &mvneta_ops; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;rte_eth_dev_probing_finish (eth_dev);return 0 ;
drivers/net/mvpp2/mrvl_ethdev.c +1 -0
@@ -2865,6 +2865,7 @@ mrvl_eth_dev_create(struct rte_vdev_device *vdev, const char *name) eth_dev->rx_pkt_burst = mrvl_rx_pkt_burst;mrvl_set_tx_function (eth_dev); eth_dev->dev_ops = &mrvl_ops; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;rte_eth_dev_probing_finish (eth_dev);return 0 ;
drivers/net/netvsc/hn_ethdev.c +2 -0
@@ -947,6 +947,8 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)if (rte_eal_process_type () !=RTE_PROC_PRIMARY )return 0 ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* Since Hyper-V only supports one MAC address */ eth_dev->data->mac_addrs =rte_calloc ("hv_mac" ,HN_MAX_MAC_ADDRS ,sizeof (struct rte_ether_addr ),0 );
drivers/net/nfb/nfb_ethdev.c +2 -0
@@ -511,6 +511,8 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) data->all_multicast =nfb_eth_allmulticast_get (dev); internals->rx_filter_original = data->promiscuous; + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + RTE_LOG(INFO, PMD, "NFB device (" PCI_PRI_FMT ") successfully initialized\n", pci_addr->domain, pci_addr->bus, pci_addr->devid,
drivers/net/nfp/nfp_net.c +2 -0
@@ -2990,6 +2990,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev)if (!(hw->cap &NFP_NET_CFG_CTRL_LIVE_ADDR )) eth_dev->data->dev_flags |=RTE_ETH_DEV_NOLIVE_MAC_ADDR ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; + PMD_INIT_LOG(INFO, "port %d VendorID=0x%x DeviceID=0x%x " "mac=%02x:%02x:%02x:%02x:%02x:%02x", eth_dev->data->port_id, pci_dev->id.vendor_id,
drivers/net/null/rte_eth_null.c +1 -0
@@ -548,6 +548,7 @@ eth_dev_null_create(struct rte_vdev_device *dev, struct pmd_options *args) data->mac_addrs = &internals->eth_addr; data->promiscuous =1 ; data->all_multicast =1 ; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->dev_ops = &ops;
drivers/net/octeontx/octeontx_ethdev.c +1 -0
@@ -1376,6 +1376,7 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev, data->promiscuous =0 ; data->all_multicast =0 ; data->scattered_rx =0 ; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Get maximum number of supported MAC entries */ max_entries =octeontx_bgx_port_mac_entries_get (nic->port_id);
drivers/net/octeontx2/otx2_ethdev.c +1 -0
@@ -2422,6 +2422,7 @@ otx2_eth_dev_init(struct rte_eth_dev *eth_dev) pci_dev =RTE_ETH_DEV_TO_PCI (eth_dev);rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Zero out everything after OTX2_DEV to allow proper dev_reset() */ memset(&dev->otx2_eth_dev_data_start, 0, sizeof(*dev) -
drivers/net/pcap/rte_eth_pcap.c +1 -0
@@ -1156,6 +1156,7 @@ pmd_init_internals(struct rte_vdev_device *vdev, data->mac_addrs = &(*internals)->eth_addr; data->promiscuous =1 ; data->all_multicast =1 ; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* * NOTE: we'll replace the data element, of originally allocated
drivers/net/pfe/pfe_ethdev.c +2 -0
@@ -849,6 +849,8 @@ pfe_eth_init(struct rte_vdev_device *vdev, struct pfe *pfe, int id) eth_dev->data->nb_rx_queues =1 ; eth_dev->data->nb_tx_queues =1 ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* For link status, open the PFE CDEV; Error from this function * is silently ignored; In case of error, the link status will not * be available.
drivers/net/qede/qede_ethdev.c +1 -0
@@ -2543,6 +2543,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) }rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* @DPDK */ edev->vendor_id = pci_dev->id.vendor_id;
drivers/net/ring/rte_eth_ring.c +1 -0
@@ -358,6 +358,7 @@ do_eth_dev_ring_create(const char *name, data->mac_addrs = &internals->address; data->promiscuous =1 ; data->all_multicast =1 ; + data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; eth_dev->dev_ops = &ops; data->numa_node = numa_node;
drivers/net/sfc/sfc_ethdev.c +1 -0
@@ -2212,6 +2212,7 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)/* Copy PCI device info to the dev->data */ rte_eth_copy_pci_info (dev, pci_dev); + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; rc =sfc_kvargs_parse (sa);if (rc !=0 )
drivers/net/szedata2/rte_eth_szedata2.c +2 -0
@@ -1536,6 +1536,8 @@ rte_szedata2_eth_dev_init(struct rte_eth_dev *dev, struct port_info *pi)rte_ether_addr_copy (ð_addr, data->mac_addrs); + dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +PMD_INIT_LOG (INFO ,"%s device %s successfully initialized" ,RTE_STR (RTE_SZEDATA2_DRIVER_NAME ), data->name);
drivers/net/tap/rte_eth_tap.c +2 -1
@@ -1921,7 +1921,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name,/* Setup some default values */ data = dev->data; data->dev_private = pmd; - data->dev_flags =RTE_ETH_DEV_INTR_LSC ; + data->dev_flags =RTE_ETH_DEV_INTR_LSC | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; data->numa_node = numa_node; data->dev_link = pmd_link;
drivers/net/thunderx/nicvf_ethdev.c +1 -0
@@ -2152,6 +2152,7 @@ nicvf_eth_dev_init(struct rte_eth_dev *eth_dev) pci_dev =RTE_ETH_DEV_TO_PCI (eth_dev);rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; nic->device_id = pci_dev->id.device_id; nic->vendor_id = pci_dev->id.vendor_id;
drivers/net/vhost/rte_eth_vhost.c +2 -1
@@ -1444,7 +1444,8 @@ eth_dev_vhost_create(struct rte_vdev_device *dev, char *iface_name, internal->flags = flags; internal->disable_flags = disable_flags; data->dev_link = pmd_link; - data->dev_flags =RTE_ETH_DEV_INTR_LSC ; + data->dev_flags =RTE_ETH_DEV_INTR_LSC | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; data->promiscuous =1 ; data->all_multicast =1 ;
drivers/net/virtio/virtio_ethdev.c +2 -0
@@ -1718,6 +1718,8 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)else eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC ; + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ; +/* Setting up rx_header size for the device */ if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF) || vtpci_with_feature(hw, VIRTIO_F_VERSION_1) ||
drivers/net/vmxnet3/vmxnet3_ethdev.c +1 -0
@@ -250,6 +250,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)return 0 ;rte_eth_copy_pci_info (eth_dev, pci_dev); + eth_dev->data->dev_flags |=RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;/* Vendor and Device ID need to be set before init of shared code */ hw->device_id = pci_dev->id.device_id;
lib/librte_ethdev/rte_ethdev.c +14 -4
@@ -2496,8 +2496,10 @@ get_xstats_basic_count(struct rte_eth_dev *dev) nb_txqs =RTE_MIN (dev->data->nb_tx_queues,RTE_ETHDEV_QUEUE_STAT_CNTRS ); count =RTE_NB_STATS ; - count += nb_rxqs *RTE_NB_RXQ_STATS ; - count += nb_txqs *RTE_NB_TXQ_STATS ; +if (dev->data->dev_flags &RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ) { + count += nb_rxqs *RTE_NB_RXQ_STATS ; + count += nb_txqs *RTE_NB_TXQ_STATS ; + }return count; }
@@ -2588,6 +2590,10 @@ rte_eth_basic_stats_get_names(struct rte_eth_dev *dev, sizeof(xstats_names[0].name)); cnt_used_entries++; } + +if ((dev->data->dev_flags &RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ) ==0 ) +return cnt_used_entries; + num_q =RTE_MIN (dev->data->nb_rx_queues,RTE_ETHDEV_QUEUE_STAT_CNTRS );for (id_queue =0 ; id_queue < num_q; id_queue++) {for (idx =0 ; idx <RTE_NB_RXQ_STATS ; idx++) {
@@ -2786,6 +2792,9 @@ rte_eth_basic_stats_get(uint16_t port_id, struct rte_eth_xstat *xstats) xstats[count++].value = val; } +if ((dev->data->dev_flags &RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ) ==0 ) +return count; +/* per-rxq stats */ for (q =0 ; q < nb_rxqs; q++) {for (i =0 ; i <RTE_NB_RXQ_STATS ; i++) {
@@ -2921,8 +2930,9 @@ rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats, nb_txqs =RTE_MIN (dev->data->nb_tx_queues,RTE_ETHDEV_QUEUE_STAT_CNTRS );/* Return generic statistics */ - count =RTE_NB_STATS + (nb_rxqs *RTE_NB_RXQ_STATS ) + - (nb_txqs *RTE_NB_TXQ_STATS ); + count =RTE_NB_STATS ; +if (dev->data->dev_flags &RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ) + count += (nb_rxqs *RTE_NB_RXQ_STATS ) + (nb_txqs *RTE_NB_TXQ_STATS );/* implemented by the driver */ if (dev->dev_ops->xstats_get !=NULL ) {
lib/librte_ethdev/rte_ethdev.h +5 -0
@@ -1694,6 +1694,11 @@ struct rte_eth_dev_owner {#define RTE_ETH_DEV_REPRESENTOR 0x0010/** Device does not support MAC change after started */ #define RTE_ETH_DEV_NOLIVE_MAC_ADDR 0x0020 +/** +* Queue xstats filled automatically by ethdev layer. +* PMDs filling the queue xstats themselves should not set this flag +*/ +#define RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS 0x0040/** * Iterates over valid ethdev ports owned by a specific owner.
Signature · 1 line
2.26.2
RFC v2 2/2 doc: announce queue stats moving to xstats
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.
--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
config/rte_config.h +1 -1
@@ -55,7 +55,7 @@/* ether defines */ #define RTE_MAX_QUEUES_PER_PORT 1024 -#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 +#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16/* max 256 */ #define RTE_ETHDEV_RXTX_CALLBACKS 1/* cryptodev defines */
doc/guides/rel_notes/deprecation.rst +7 -0
@@ -164,6 +164,13 @@ Deprecation Notices following the IPv6 header, as proposed in RFC https://mails.dpdk.org/archives/dev/2020-August/177257.html. +* ethdev: Queue specific stats fields will be removed from ``struct rte_eth_stats``. + Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``, + ``q_errors``. + Instead queue stats will be received via xstats API. Current method support + will be limited to maximum 256 queues. + Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. + * security: The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to
lib/librte_ethdev/rte_ethdev.h +3 -0
@@ -253,6 +253,7 @@ struct rte_eth_stats {uint64_t ierrors;/**< Total number of erroneous received packets. */ uint64_t oerrors;/**< Total number of failed transmitted packets. */ uint64_t rx_nombuf;/**< Total number of RX mbuf allocation failures. */ +/* Queue stats are limited to max 256 queues */ uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS ];/**< Total number of queue RX packets. */ uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS ];
@@ -2704,6 +2705,7 @@ int rte_eth_xstats_reset(uint16_t port_id);* The per-queue packet statistics functionality number that the transmit * queue is to be assigned. * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. +* Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. * @return * Zero if successful. Non-zero otherwise. */
@@ -2724,6 +2726,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id,* The per-queue packet statistics functionality number that the receive * queue is to be assigned. * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. +* Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. * @return * Zero if successful. Non-zero otherwise. */
Signature · 1 line
2.26.2
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
Quoted 10 lines · Ferruh Yigit
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.
Quoted 7 lines
Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
Thomas Monjalon
Acked-byRe: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
14/10/2020 10:43, Kinsella, Ray:
Quoted 12 lines · Ferruh Yigit
Quoted 10 lines
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.
Quoted 8 lines
Quoted 7 lines
Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)Acked-by Ray Kinsella <[email protected]>
We need more acks for the deprecation notice to be accepted.
Bruce Richardson
Acked-byRe: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
Quoted 20 lines · Thomas Monjalon
14/10/2020 10:43, Kinsella, Ray:
Quoted 19 lines · Ferruh Yigit
Quoted 17 lines
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
Quoted 4 lines
Quoted 1 line
Acked-by Ray Kinsella <[email protected]>Acked-by Thomas Monjalon <[email protected]>
Jerin Jacob
Acked-byRe: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
In reply to Thomas MonjalonQuoted 21 lines · Thomas Monjalon
14/10/2020 10:43, Kinsella, Ray:
Quoted 19 lines · Ferruh Yigit
Quoted 17 lines
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
Quoted 5 lines
Quoted 1 line
Acked-by Ray Kinsella <[email protected]>Acked-by Thomas Monjalon <[email protected]>We need more acks for the deprecation notice to be accepted.
Quoted 2 lines
Stephen Hemminger
Acked-byRe: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
In reply to Thomas MonjalonQuoted 20 lines · On Fri, 16 Oct 2020 16:34:46 +0200 Thomas Monjalon <[email protected]> wrote:
14/10/2020 10:43, Kinsella, Ray:
Quoted 19 lines · Ferruh Yigit
Quoted 17 lines
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
Quoted 3 lines
Quoted 1 line
Acked-by Ray Kinsella <[email protected]>Acked-by Thomas Monjalon <[email protected]>
Ajit Khaparde
Acked-byRe: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
Quoted 24 lines · Stephen Hemminger
Quoted 20 lines · On Fri, 16 Oct 2020 16:34:46 +0200 Thomas Monjalon <[email protected]> wrote:
14/10/2020 10:43, Kinsella, Ray:
Quoted 19 lines · Ferruh Yigit
Quoted 17 lines
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Acked-by Ray Kinsella <[email protected]>Acked-by Thomas Monjalon <[email protected]>
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
In reply to Ferruh YigitHi Ferruh,
As rte_eth_stats is going to be changed, is it possible to add new counters there?
For example, in/out multicast/broadcast packets.
Igor
Quoted 91 lines · Ferruh Yigit
Queue stats will be removed from basic stats to xstats.
It will be PMDs responsibility to fill queue stats based on number of queues they have.
Until all PMDs implement the xstats, a temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched to the xstats should clear this flag to bypass the ethdev layer autofill for queue stats.Signed-off-by Ferruh Yigit <[email protected]>--- config/rte_config.h | 2 +- doc/guides/rel_notes/deprecation.rst | 7 +++++++ lib/librte_ethdev/rte_ethdev.h | 3 +++ 3 files changed, 11 insertions(+), 1 deletion(-)config/rte_config.h +1
-1@@ -55,7 +55,7 @@/* ether defines */ #define RTE_MAX_QUEUES_PER_PORT 1024 -#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 +#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16/* max 256 */ #define RTE_ETHDEV_RXTX_CALLBACKS 1/* cryptodev defines */ doc/guides/rel_notes/deprecation.rst +1
-0@@ -164,6 +164,13 @@ Deprecation Notices following the IPv6 header, as proposed in RFC https://mails.dpdk.org/archives/dev/2020-August/177257.html. +* ethdev: Queue specific stats fields will be removed from ``structrte_eth_stats``.
+ Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``, ``q_obytes``,doc/guides/rel_notes/deprecation.rst +2
-0+ ``q_errors``. + Instead queue stats will be received via xstats API. Current methodsupport
doc/guides/rel_notes/deprecation.rst +3
-0+ will be limited to maximum 256 queues. + Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. + * security: The API ``rte_security_session_create`` takes only singlemempool
for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead tolib/librte_ethdev/rte_ethdev.h +0
-0@@ -253,6 +253,7 @@ struct rte_eth_stats {uint64_t ierrors;/**< Total number of erroneous received packets. */
uint64_toerrors; /**< Total number of failed transmitted
packets. */
uint64_trx_nombuf; /**< Total number of RX mbuf allocation
failures. */lib/librte_ethdev/rte_ethdev.h +1
-0+/* Queue stats are limited to max 256 queues */ uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS ];/**< Total number of queue RX packets. */ uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS ];@@ -2704,6 +2705,7 @@ int rte_eth_xstats_reset(uint16_t port_id);* The per-queue packet statistics functionality number that the transmit
* queue is to be assigned. * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. + * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256.* @return
* Zero if successful. Non-zero otherwise.
*/lib/librte_ethdev/rte_ethdev.h +1
-0@@ -2724,6 +2726,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, * The per-queue packet statistics functionality number that the receive * queue is to be assigned. * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1]. + * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256. * @return * Zero if successful. Non-zero otherwise.*/
--
2.26.2
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
14/10/2020 11:35, Igor Ryzhov:
Quoted 5 lines
Hi Ferruh,
As
rte_eth_statsis going to be changed, is it possible to add new counters there?
For example, in/out multicast/broadcast packets.
Good question.
In order to avoid redundancy, I prefer focusing on xstats and plan deprecation of rte_eth_stats.
The basic stats you are asking for should have standardized names and reserved ids in xstats API.
Please see these slides:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
Hi Thomas,
Thanks for the slides, I checked the latest code and multicast/broadcast counters mostly look standardized. But mlx5 adds the "port" word to all its xstats names. I suppose you may be the right person to ask - is there any specific reason for this?
Quoted 19 lines · Thomas Monjalon
14/10/2020 11:35, Igor Ryzhov:
Quoted 3 lines
Hi Ferruh,
As
rte_eth_statsis going to be changed, is it possible to add newcounters
Quoted 2 lines
there?
For example, in/out multicast/broadcast packets.Good question.
In order to avoid redundancy, I prefer focusing on xstats and plan deprecation ofrte_eth_stats.The basic stats you are asking for should have standardized names and reserved ids in xstats API.
Please see these slides:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
15/10/2020 09:55, Igor Ryzhov:
Quoted 6 lines
Hi Thomas,
Thanks for the slides, I checked the latest code and multicast/broadcast counters mostly look standardized. But mlx5 adds the "port" word to all its xstats names. I suppose you may be the right person to ask - is there any specific reason for this?
No specific reason, I consider it as a bug.
Please could you open a bugzilla ticket?
Quoted 19 lines
Quoted 16 lines · Thomas Monjalon
14/10/2020 11:35, Igor Ryzhov:
Quoted 3 lines
Hi Ferruh,
As
rte_eth_statsis going to be changed, is it possible to add newcounters
Quoted 2 lines
there?
For example, in/out multicast/broadcast packets.Good question.
In order to avoid redundancy, I prefer focusing on xstats and plan deprecation ofrte_eth_stats.The basic stats you are asking for should have standardized names and reserved ids in xstats API.
Please see these slides:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
Done.
https://bugs.dpdk.org/show_bug.cgi?id=558
Quoted 36 lines · Thomas Monjalon
15/10/2020 09:55, Igor Ryzhov:
Quoted 6 lines
Hi Thomas,
Thanks for the slides, I checked the latest code and multicast/broadcast counters mostly look standardized. But mlx5 adds the "port" word to all its xstats names. I suppose you may be the right person to ask - is there any specific reason for this?
No specific reason, I consider it as a bug.
Please could you open a bugzilla ticket?Quoted 11 lines
Quoted 8 lines · Thomas Monjalon
14/10/2020 11:35, Igor Ryzhov:
Quoted 3 lines
Hi Ferruh,
As
rte_eth_statsis going to be changed, is it possible to add newcounters
Quoted 2 lines
there?
For example, in/out multicast/broadcast packets.Quoted 8 lines
Quoted 8 lines
Good question.
In order to avoid redundancy, I prefer focusing on xstats and plan deprecation ofrte_eth_stats.The basic stats you are asking for should have standardized names and reserved ids in xstats API.
Please see these slides:https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
15/10/2020 19:39, Igor Ryzhov:
Quoted 3 lines
Done.
Thanks
Quoted 40 lines
Quoted 36 lines · Thomas Monjalon
15/10/2020 09:55, Igor Ryzhov:
Quoted 6 lines
Hi Thomas,
Thanks for the slides, I checked the latest code and multicast/broadcast counters mostly look standardized. But mlx5 adds the "port" word to all its xstats names. I suppose you may be the right person to ask - is there any specific reason for this?
No specific reason, I consider it as a bug.
Please could you open a bugzilla ticket?Quoted 11 lines
Quoted 8 lines · Thomas Monjalon
14/10/2020 11:35, Igor Ryzhov:
Quoted 3 lines
Hi Ferruh,
As
rte_eth_statsis going to be changed, is it possible to add newcounters
Quoted 2 lines
there?
For example, in/out multicast/broadcast packets.Quoted 8 lines
Quoted 8 lines
Good question.
In order to avoid redundancy, I prefer focusing on xstats and plan deprecation ofrte_eth_stats.The basic stats you are asking for should have standardized names and reserved ids in xstats API.
Please see these slides:https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
In reply to Ferruh YigitQuoted 59 lines
-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Wednesday, October 14, 2020 10:27
To: Yigit, Ferruh <[email protected]>; John W. Linville <[email protected]>; Loftus, Ciara <[email protected]>; Zhang, Qi Z <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Steven Webster <[email protected]>; Matt Peters <[email protected]>; Somalapuram Amaranath <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Ajit Khaparde <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Gagandeep Singh <[email protected]>; John Daley <[email protected]>; Hyong Youb Kim <[email protected]>; Gaetan Rivet <[email protected]>; Wang, Xiao W <[email protected]>; Ziyang Xuan <[email protected]>; Xiaoyun Wang <[email protected]>; Guoyang Zhou <[email protected]>; Wei Hu (Xavier) <[email protected]>; Yisen Zhuang <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Xu, Rosen <[email protected]>; Shijith Thotton <[email protected]>; Srisivasubramanian Srinivasan <[email protected]>; Jakub Grajciar <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Martin Spinler <[email protected]>; Heinrich Kuhn <[email protected]>; Tetsuya Mukawa <[email protected]>; Harman Kalra <[email protected]>; Jerin Jacob <[email protected]>; Nithin Dabilpuram <[email protected]>; Kiran Kumar K <[email protected]>; Akhil Goyal <[email protected]>; Richardson, Bruce <[email protected]>; Andrew Rybchenko <[email protected]>; Wiles, Keith <[email protected]>; Maciej Czekaj <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>; Wang, Zhihong <[email protected]>; Yong Wang <[email protected]>; Thomas Monjalon <[email protected]>
Cc: [email protected]
Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstatsQueue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.
Quoted 8 lines
Signed-off-by Ferruh Yigit <[email protected]>---
drivers/net/e1000/em_ethdev.c | 1 + drivers/net/e1000/igb_ethdev.c | 2 ++ drivers/net/igc/igc_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
For e1000, igc, ixgbe PMDs,
Quoted 4 lines
/**
* Iterates over valid ethdev ports owned by a specific owner.
--
2.26.2
Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
In reply to Ferruh YigitHi,
BRs,
Xiao
Quoted 94 lines
-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Wednesday, October 14, 2020 10:27 AM
To: Yigit, Ferruh <[email protected]>; John W. Linville <[email protected]>; Loftus, Ciara <[email protected]>; Zhang, Qi Z <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Steven Webster <[email protected]>; Matt Peters <[email protected]>; Somalapuram Amaranath <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Ajit Khaparde <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Gagandeep Singh <[email protected]>; John Daley <[email protected]>; Hyong Youb Kim <[email protected]>; Gaetan Rivet <[email protected]>; Wang, Xiao W <[email protected]>; Ziyang Xuan <[email protected]>; Xiaoyun Wang <[email protected]>; Guoyang Zhou <[email protected]>; Wei Hu (Xavier) <[email protected]>; Yisen Zhuang <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Xu, Rosen <[email protected]>; Shijith Thotton <[email protected]>; Srisivasubramanian Srinivasan <[email protected]>; Jakub Grajciar <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Martin Spinler <[email protected]>; Heinrich Kuhn <[email protected]>; Tetsuya Mukawa <[email protected]>; Harman Kalra <[email protected]>; Jerin Jacob <[email protected]>; Nithin Dabilpuram <[email protected]>; Kiran Kumar K <[email protected]>; Akhil Goyal <[email protected]>; Richardson, Bruce <[email protected]>; Andrew Rybchenko <[email protected]>; Wiles, Keith <[email protected]>; Maciej Czekaj <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>; Wang, Zhihong <[email protected]>; Yong Wang <[email protected]>; Thomas Monjalon <[email protected]>
Cc: [email protected]
Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstatsQueue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS'
device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.Signed-off-by Ferruh Yigit <[email protected]>--- drivers/net/af_packet/rte_eth_af_packet.c | 1 + drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + drivers/net/ark/ark_ethdev.c | 2 ++ drivers/net/atlantic/atl_ethdev.c | 2 ++ drivers/net/avp/avp_ethdev.c | 1 + drivers/net/axgbe/axgbe_ethdev.c | 2 ++ drivers/net/bnx2x/bnx2x_ethdev.c | 1 + drivers/net/bnxt/bnxt_ethdev.c | 1 + drivers/net/bnxt/bnxt_reps.c | 3 ++- drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- drivers/net/cxgbe/cxgbe_ethdev.c | 2 ++ drivers/net/dpaa/dpaa_ethdev.c | 2 ++ drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++
Quoted 8 lines
drivers/net/e1000/em_ethdev.c | 1 + drivers/net/e1000/igb_ethdev.c | 2 ++ drivers/net/ena/ena_ethdev.c | 2 ++ drivers/net/enetc/enetc_ethdev.c | 2 ++ drivers/net/enic/enic_ethdev.c | 1 + drivers/net/enic/enic_vf_representor.c | 3 ++- drivers/net/failsafe/failsafe.c | 3 ++- drivers/net/fm10k/fm10k_ethdev.c | 1 +
For fm10k,
Quoted 3 lines
drivers/net/hinic/hinic_pmd_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev_vf.c | 2 ++
Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
In reply to Ferruh YigitQuoted 17 lines · Ferruh Yigit
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.
Quoted 7 lines
When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.Signed-off-by Ferruh Yigit <[email protected]>
Hi Thomas, Andrew,
What do you think having the patch for this release?
Connor, Xavier,
Are you OK to superseded your existing patch [1] with this approach?
[1] https://patches.dpdk.org/patch/78886/
Thomas Monjalon
Acked-byRe: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
16/10/2020 14:16, Ferruh Yigit:
Quoted 24 lines · Ferruh Yigit
Quoted 23 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.
Quoted 5 lines
Quoted 1 line
Signed-off-by Ferruh Yigit <[email protected]>Hi Thomas, Andrew,
What do you think having the patch for this release?
Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
Quoted 25 lines · Thomas Monjalon
16/10/2020 14:16, Ferruh Yigit:
Quoted 24 lines · Ferruh Yigit
Quoted 23 lines
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Ferruh Yigit <[email protected]>Hi Thomas, Andrew,
What do you think having the patch for this release?
Acked-by Thomas Monjalon <[email protected]>
Series applied to dpdk-next-net/main, thanks.
Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
In reply to Ferruh YigitQuoted 28 lines · Ferruh Yigit
Quoted 17 lines · Ferruh Yigit
Queue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.Quoted 7 lines
When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.Signed-off-by Ferruh Yigit <[email protected]>Hi Thomas, Andrew,
Quoted 7 lines
What do you think having the patch for this release?
Connor, Xavier,
Are you OK to superseded your existing patch [1] with this approach?
[1] https://patches.dpdk.org/patch/78886/
Hi, Ferruh,
it is ok, we will continue the work with your solution. Thanks.
Quoted 1 line
.
Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats
In reply to Ferruh YigitQuoted 160 lines
-----Original Message-----
From: Yigit, Ferruh <[email protected]>
Sent: Wednesday, October 14, 2020 10:27
To: Yigit, Ferruh <[email protected]>; John W. Linville <[email protected]>; Loftus, Ciara <[email protected]>; Zhang, Qi Z <[email protected]>; Shepard Siegel <[email protected]>; Ed Czeck <[email protected]>; John Miller <[email protected]>; Igor Russkikh <[email protected]>; Pavel Belous <[email protected]>; Steven Webster <[email protected]>; Matt Peters <[email protected]>; Somalapuram Amaranath <[email protected]>; Rasesh Mody <[email protected]>; Shahed Shaikh <[email protected]>; Ajit Khaparde <[email protected]>; Somnath Kotur <[email protected]>; Chas Williams <[email protected]>; Min Hu (Connor) <[email protected]>; Rahul Lakkireddy <[email protected]>; Hemant Agrawal <[email protected]>; Sachin Saxena <[email protected]>; Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; Guy Tzalik <[email protected]>; Evgeny Schemeilin <[email protected]>; Igor Chauskin <[email protected]>; Gagandeep Singh <[email protected]>; John Daley <[email protected]>; Hyong Youb Kim <[email protected]>; Gaetan Rivet <[email protected]>; Wang, Xiao W <[email protected]>; Ziyang Xuan <[email protected]>; Xiaoyun Wang <[email protected]>; Guoyang Zhou <[email protected]>; Wei Hu (Xavier) <[email protected]>; Yisen Zhuang <[email protected]>; Xing, Beilei <[email protected]>; Wu, Jingjing <[email protected]>; Yang, Qiming <[email protected]>; Alfredo Cardigliano <[email protected]>; Xu, Rosen <[email protected]>; Shijith Thotton <[email protected]>; Srisivasubramanian Srinivasan <[email protected]>; Jakub Grajciar <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko <[email protected]>; Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger <[email protected]>; K. Y. Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Long Li <[email protected]>; Martin Spinler <[email protected]>; Heinrich Kuhn <[email protected]>; Tetsuya Mukawa <[email protected]>; Harman Kalra <[email protected]>; Jerin Jacob <[email protected]>; Nithin Dabilpuram <[email protected]>; Kiran Kumar K <[email protected]>; Akhil Goyal <[email protected]>; Richardson, Bruce <[email protected]>; Andrew Rybchenko <[email protected]>; Wiles, Keith <[email protected]>; Maciej Czekaj <[email protected]>; Maxime Coquelin <[email protected]>; Xia, Chenbo <[email protected]>; Wang, Zhihong <[email protected]>; Yong Wang <[email protected]>; Thomas Monjalon
<[email protected]>
Cc: [email protected]
Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstatsQueue stats are stored in 'struct
rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.As a result of technical board discussion, decided to remove the queue statistics from 'struct
rte_eth_stats' in the long term.Instead PMDs should represent the queue statistics via xstats, this gives more flexibility on the number of the queues supported.
Currently queue stats in the xstats are filled by ethdev layer, using some basic stats, when queue stats removed from basic stats the responsibility to fill the relevant xstats will be pushed to the PMDs.
During the switch period, temporary '
RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS'
device flag is created. Initially all PMDs using xstats set this flag. The PMDs implemented queue stats in the xstats should clear the flag.When all PMDs switch to the xstats for the queue stats, queue stats related fields from 'struct
rte_eth_stats' will be removed, as well as 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be removed.Signed-off-by Ferruh Yigit <[email protected]>--- drivers/net/af_packet/rte_eth_af_packet.c | 1 + drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + drivers/net/ark/ark_ethdev.c | 2 ++ drivers/net/atlantic/atl_ethdev.c | 2 ++ drivers/net/avp/avp_ethdev.c | 1 + drivers/net/axgbe/axgbe_ethdev.c | 2 ++ drivers/net/bnx2x/bnx2x_ethdev.c | 1 + drivers/net/bnxt/bnxt_ethdev.c | 1 + drivers/net/bnxt/bnxt_reps.c | 3 ++- drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- drivers/net/cxgbe/cxgbe_ethdev.c | 2 ++ drivers/net/dpaa/dpaa_ethdev.c | 2 ++ drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++ drivers/net/e1000/em_ethdev.c | 1 + drivers/net/e1000/igb_ethdev.c | 2 ++ drivers/net/ena/ena_ethdev.c | 2 ++ drivers/net/enetc/enetc_ethdev.c | 2 ++ drivers/net/enic/enic_ethdev.c | 1 + drivers/net/enic/enic_vf_representor.c | 3 ++- drivers/net/failsafe/failsafe.c | 3 ++- drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/hinic/hinic_pmd_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev.c | 2 ++ drivers/net/hns3/hns3_ethdev_vf.c | 2 ++ drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_vf_representor.c | 3 ++- drivers/net/iavf/iavf_ethdev.c | 1 + drivers/net/ice/ice_dcf_ethdev.c | 2 ++ drivers/net/ice/ice_ethdev.c | 2 ++ drivers/net/igc/igc_ethdev.c | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ipn3ke/ipn3ke_representor.c | 3 ++- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ drivers/net/kni/rte_eth_kni.c | 1 + drivers/net/liquidio/lio_ethdev.c | 1 + drivers/net/memif/rte_eth_memif.c | 1 + drivers/net/mlx4/mlx4.c | 1 + drivers/net/mlx5/linux/mlx5_os.c | 1 + drivers/net/mvneta/mvneta_ethdev.c | 1 + drivers/net/mvpp2/mrvl_ethdev.c | 1 + drivers/net/netvsc/hn_ethdev.c | 2 ++ drivers/net/nfb/nfb_ethdev.c | 2 ++ drivers/net/nfp/nfp_net.c | 2 ++ drivers/net/null/rte_eth_null.c | 1 + drivers/net/octeontx/octeontx_ethdev.c | 1 + drivers/net/octeontx2/otx2_ethdev.c | 1 + drivers/net/pcap/rte_eth_pcap.c | 1 + drivers/net/pfe/pfe_ethdev.c | 2 ++ drivers/net/qede/qede_ethdev.c | 1 + drivers/net/ring/rte_eth_ring.c | 1 + drivers/net/sfc/sfc_ethdev.c | 1 + drivers/net/szedata2/rte_eth_szedata2.c | 2 ++ drivers/net/tap/rte_eth_tap.c | 3 ++- drivers/net/thunderx/nicvf_ethdev.c | 1 + drivers/net/vhost/rte_eth_vhost.c | 3 ++- drivers/net/virtio/virtio_ethdev.c | 2 ++ drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + lib/librte_ethdev/rte_ethdev.c | 18 ++++++++++++++---- lib/librte_ethdev/rte_ethdev.h | 5 +++++ 60 files changed, 106 insertions(+), 12 deletions(-)drivers/net/ipn3ke/ipn3ke_representor.c +2
-1@@ -2964,7 +2964,8 @@ ipn3ke_rpst_init(struct rte_eth_dev *ethdev, void *init_params)return -ENODEV ; } - ethdev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR ; + ethdev->data->dev_flags |=RTE_ETH_DEV_REPRESENTOR | +RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS ;
drivers/net/ipn3ke/ipn3ke_representor.c
Quoted 2 lines
drivers/net/ipn3ke/ipn3ke_representor.c +0
-0rte_spinlock_lock (&ipn3ke_link_notify_list_lk); TAILQ_INSERT_TAIL(&ipn3ke_rpst_list, rpst, next); diff --git