Skip to contentSkip to conversation

net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags

PATCH Applied Christian Eggers 4 participants 4 messages Oct 16, 2020 – Oct 24, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags

The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and KSZ9893 switches also use tail tags.

Fixes 7a6ffe764be3 ("net: dsa: point out the tail taggers")

---

Quoted 9 lines · Vladimir Oltean

Hi Christian,

The idea is perfect but the commit isn't.
...
Now if you run
"git show 7a6ffe764be35af0527d8cfd047945e8f8797ddf --pretty=fixes", you'll see:

Fixes 7a6ffe764be3 ("net: dsa: point out the tail taggers")

thanks for pointing out how to use this feature. I did this manually up to now.

Quoted 2 lines

Notice how there's no [net] tag?
People complain when the format of the Fixes: tag is not standardized.

I added it manually because the commit ID is not from Linus' tree. Is there any value using Fixes tags with id's from other trees?

regards
Christian

 net/dsa/tag_ksz.c | 2 ++
 1 file changed, 2 insertions(+)
net/dsa/tag_ksz.c +2 -0
index 945a9bd5ba35..0a5aa982c60d 100644
@@ -123,6 +123,7 @@ static const struct dsa_device_ops ksz8795_netdev_ops = {
 	.xmit	= ksz8795_xmit,
 	.rcv	= ksz8795_rcv,
 	.overhead = KSZ_INGRESS_TAG_LEN,
+	.tail_tag = true,
 };
 
 DSA_TAG_DRIVER(ksz8795_netdev_ops);
@@ -199,6 +200,7 @@ static const struct dsa_device_ops ksz9477_netdev_ops = {
 	.xmit	= ksz9477_xmit,
 	.rcv	= ksz9477_rcv,
 	.overhead = KSZ9477_INGRESS_TAG_LEN,
+	.tail_tag = true,
 };
 
 DSA_TAG_DRIVER(ksz9477_netdev_ops);
Signature · 8 lines
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
maintainer
#1 lore raw
Quoted 2 lines · Christian Eggers

I added it manually because the commit ID is not from Linus' tree. Is there any value using Fixes tags with id's from other trees?

Yes, that's what "git merge" does, it keeps sha1sums.
You should check out "git log --oneline --graph --decorate" some time. Every maintainer's history is linear, and so is Linus's.

maintainer Applied
#2 lore raw
Quoted 7 lines · On Fri, 16 Oct 2020 20:24:49 +0300 Vladimir Oltean wrote:
Quoted 2 lines · Christian Eggers

I added it manually because the commit ID is not from Linus' tree. Is there any value using Fixes tags with id's from other trees?

Yes, that's what "git merge" does, it keeps sha1sums.
You should check out "git log --oneline --graph --decorate" some time. Every maintainer's history is linear, and so is Linus's.

One thing to add is that we never rebase net or net-next trees (some maintainers would do that occasionally).

Applied, thanks everyone!

#3 lore raw
In reply to Christian Eggers
Thank you for the patch! Yet something to improve:

Hi Christian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-tag_ksz-KSZ8795-and-KSZ9477-also-use-tail-tags/20201017-011843
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2ecbc1f684482b4ed52447a39903bd9b0f222898
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/fe8fb49545331c296de8777fa5b795537410b5e3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christian-Eggers/net-dsa-tag_ksz-KSZ8795-and-KSZ9477-also-use-tail-tags/20201017-011843
        git checkout fe8fb49545331c296de8777fa5b795537410b5e3
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

>> net/dsa/tag_ksz.c:126:3: error: 'const struct dsa_device_ops' has no member named 'tail_tag'
     126 |  .tail_tag = true,
         |   ^~~~~~~~
   net/dsa/tag_ksz.c:126:14: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     126 |  .tail_tag = true,
         |              ^~~~
   net/dsa/tag_ksz.c:126:14: note: (near initialization for 'ksz8795_netdev_ops.name')
   net/dsa/tag_ksz.c:126:14: warning: initialized field overwritten [-Woverride-init]
   net/dsa/tag_ksz.c:126:14: note: (near initialization for 'ksz8795_netdev_ops.name')
   net/dsa/tag_ksz.c:203:3: error: 'const struct dsa_device_ops' has no member named 'tail_tag'
     203 |  .tail_tag = true,
         |   ^~~~~~~~
   net/dsa/tag_ksz.c:203:14: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     203 |  .tail_tag = true,
         |              ^~~~

net/dsa/tag_ksz.c:203:14: note: (near initialization for 'ksz9477_netdev_ops.name') net/dsa/tag_ksz.c:203:14: warning: initialized field overwritten [-Woverride-init] net/dsa/tag_ksz.c:203:14: note: (near initialization for 'ksz9477_netdev_ops.name')

vim +126 net/dsa/tag_ksz.c

119
120 static const struct dsa_device_ops ksz8795_netdev_ops = {
121 .name = "ksz8795",
122 .proto = DSA_TAG_PROTO_KSZ8795,
123 .xmit = ksz8795_xmit,
124 .rcv = ksz8795_rcv,
125 .overhead = KSZ_INGRESS_TAG_LEN,

 > 126		.tail_tag = true,

127 };
128

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org