kernel-resource-make-release_mem_region_adjustable-never-fail.patch removed from -mm tree
The patch titled
Subject: kernel/resource: make release_mem_region_adjustable() never fail
has been removed from the -mm tree. Its filename was
kernel-resource-make-release_mem_region_adjustable-never-fail.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: kernel/resource: make release_mem_region_adjustable() never fail
Patch series "selective merging of system ram resources", v4.
Some add_memory*() users add memory in small, contiguous memory blocks. Examples include virtio-mem, hyper-v balloon, and the XEN balloon.
This can quickly result in a lot of memory resources, whereby the actual resource boundaries are not of interest (e.g., it might be relevant for DIMMs, exposed via /proc/iomem to user space). We really want to merge added resources in this scenario where possible.
Resources are effectively stored in a list-based tree. Having a lot of resources not only wastes memory, it also makes traversing that tree more expensive, and makes /proc/iomem explode in size (e.g., requiring kexec-tools to manually merge resources when creating a kdump header. The current kexec-tools resource count limit does not allow for more than ~100GB of memory with a memory block size of 128MB on x86-64).
Let's allow to selectively merge system ram resources by specifying a new flag for add_memory*(). Patch #5 contains a /proc/iomem example. Only tested with virtio-mem.
This patch (of 8):
Let's make sure splitting a resource on memory hotunplug will never fail. This will become more relevant once we merge selected System RAM resources
- then, we'll trigger that case more often on memory hotunplug.
In general, this function is already unlikely to fail. When we remove memory, we free up quite a lot of metadata (memmap, page tables, memory block device, etc.). The only reason it could really fail would be when injecting allocation errors.
All other error cases inside release_mem_region_adjustable() seem to be sanity checks if the function would be abused in different context - let's add WARN_ON_ONCE() in these cases so we can catch them.
---
include/linux/ioport.h | 4 +-- kernel/resource.c | 49 ++++++++++++++++++++++----------------- mm/memory_hotplug.c | 22 ----------------- 3 files changed, 31 insertions(+), 44 deletions(-)
include/linux/ioport.h renamed from include/linux/ioport.h~kernel-resource-make-release_mem_region_adjustable-never-fail +2 -2
@@ -248,8 +248,8 @@ extern struct resource * __request_regioextern void __release_region (struct resource *,resource_size_t ,resource_size_t );#ifdef CONFIG_MEMORY_HOTREMOVE -extern int release_mem_region_adjustable (struct resource *,resource_size_t , -resource_size_t ); +extern void release_mem_region_adjustable (struct resource *,resource_size_t , +resource_size_t );#endif /* Wrappers for managed devices */
kernel/resource.c renamed from kernel/resource.c~kernel-resource-make-release_mem_region_adjustable-never-fail +28 -21
92 lines not on this page · raw message
mm/memory_hotplug.c renamed from mm/memory_hotplug.c~kernel-resource-make-release_mem_region_adjustable-never-fail +1 -21
@@ -1727,26 +1727,6 @@ void try_offline_node(int nid) }EXPORT_SYMBOL (try_offline_node); -static void __release_memory_resource (resource_size_t start, -resource_size_t size) -{ -int ret; - -/* -* When removing memory in the same granularity as it was added, -* this function never fails. It might only fail if resources -* have to be adjusted or split. We'll ignore the error, as -* removing of memory cannot fail. -*/ - ret =release_mem_region_adjustable (&iomem_resource, start, size); -if (ret) { -resource_size_t endres = start + size -1 ; - -pr_warn ("Unable to release resource <%pa-%pa> (%d)\n" , - &start, &endres, ret); - } -} -static int __ref try_remove_memory (int nid,u64 start,u64 size) {int rc =0 ;
@@ -1780,7 +1760,7 @@ static int __ref try_remove_memory(int nmemblock_remove (start, size); } -__release_memory_resource (start, size); +release_mem_region_adjustable (&iomem_resource, start, size);try_offline_node (nid);
_
Patches currently in -mm which might be from [email protected] are