Skip to contentSkip to conversation

mm-memory_hotplug-update-comment-regarding-zone-shuffling.patch removed from -mm tree

merged [email protected] 1 participant 1 message Oct 16, 2020

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: mm/memory_hotplug: update comment regarding zone shuffling
has been removed from the -mm tree. Its filename was
mm-memory_hotplug-update-comment-regarding-zone-shuffling.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: mm/memory_hotplug: update comment regarding zone shuffling

As we no longer shuffle via generic_online_page() and when undoing isolation, we can simplify the comment.

We now effectively shuffle only once (properly) when onlining new memory.

Cc Alexander Duyck <[email protected]>
Cc Mel Gorman <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Dave Hansen <[email protected]>
Cc Vlastimil Babka <[email protected]>
Cc Wei Yang <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Pankaj Gupta <[email protected]>
Cc Haiyang Zhang <[email protected]>
Cc "K. Y. Srinivasan" <[email protected]>
Cc Matthew Wilcox <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Scott Cheloha <[email protected]>
Cc Stephen Hemminger <[email protected]>
Cc Wei Liu <[email protected]>

---

 mm/memory_hotplug.c |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
mm/memory_hotplug.c renamed from mm/memory_hotplug.c~mm-memory_hotplug-update-comment-regarding-zone-shuffling +4 -7
@@ -858,13 +858,10 @@ int __ref online_pages(unsigned long pfn
 	undo_isolate_page_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE);
 
 	/*
-	 * When exposing larger, physically contiguous memory areas to the
-	 * buddy, shuffling in the buddy (when freeing onlined pages, putting
-	 * them either to the head or the tail of the freelist) is only helpful
-	 * for maintaining the shuffle, but not for creating the initial
-	 * shuffle. Shuffle the whole zone to make sure the just onlined pages
-	 * are properly distributed across the whole freelist. Make sure to
-	 * shuffle once pageblocks are no longer isolated.
+	 * Freshly onlined pages aren't shuffled (e.g., all pages are placed to
+	 * the tail of the freelist when undoing isolation). Shuffle the whole
+	 * zone to make sure the just onlined pages are properly distributed
+	 * across the whole freelist - to create an initial shuffle.
 	 */
 	shuffle_zone(zone);
 

_

Patches currently in -mm which might be from [email protected] are