counter/ti-eqep: Fix regmap max_register
Subsystems (3)
David Lechner
reviewerPATCH 1/1 counter/ti-eqep: Fix regmap max_register
The values given were the offset of the register after the last register instead of the actual last register in each range. Fix by using the correct last register of each range.
Signed-off-by David Lechner <[email protected]>
--- drivers/counter/ti-eqep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/counter/ti-eqep.c +2 -2
@@ -798,7 +798,7 @@ static const struct regmap_config ti_eqep_regmap32_config = { .reg_bits = 32, .val_bits = 32, .reg_stride = 4, - .max_register = 0x24, + .max_register = QUPRD, };static const struct regmap_config ti_eqep_regmap16_config = {
@@ -806,7 +806,7 @@ static const struct regmap_config ti_eqep_regmap16_config = { .reg_bits = 16, .val_bits = 16, .reg_stride = 2, - .max_register = 0x1e, + .max_register = QCPRDLAT, };static int ti_eqep_probe (struct platform_device *pdev)
Signature · 1 line
2.25.1
Quoted 5 lines · David Lechner
The values given were the offset of the register after the last register instead of the actual last register in each range. Fix by using the correct last register of each range.
Signed-off-by David Lechner <[email protected]>
Quoted 29 lines
--- drivers/counter/ti-eqep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/counter/ti-eqep.c +2
-2@@ -798,7 +798,7 @@ static const struct regmap_config ti_eqep_regmap32_config = { .reg_bits = 32, .val_bits = 32, .reg_stride = 4, - .max_register = 0x24, + .max_register = QUPRD, };static const struct regmap_config ti_eqep_regmap16_config = {@@ -806,7 +806,7 @@ static const struct regmap_config ti_eqep_regmap16_config = { .reg_bits = 16, .val_bits = 16, .reg_stride = 2, - .max_register = 0x1e, + .max_register = QCPRDLAT, };static int ti_eqep_probe (struct platform_device *pdev)Signature · 1 line
2.25.1
Jonathan Cameron
maintainerQuoted 5 lines · On Fri, 16 Oct 2020 14:58:37 -0500 David Lechner <[email protected]> wrote:
The values given were the offset of the register after the last register instead of the actual last register in each range. Fix by using the correct last register of each range.
Signed-off-by David Lechner <[email protected]>
Fixes tag please.
Thanks,
Jonathan
Quoted 26 lines
--- drivers/counter/ti-eqep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/counter/ti-eqep.c +2
-2@@ -798,7 +798,7 @@ static const struct regmap_config ti_eqep_regmap32_config = { .reg_bits = 32, .val_bits = 32, .reg_stride = 4, - .max_register = 0x24, + .max_register = QUPRD, };static const struct regmap_config ti_eqep_regmap16_config = {@@ -806,7 +806,7 @@ static const struct regmap_config ti_eqep_regmap16_config = { .reg_bits = 16, .val_bits = 16, .reg_stride = 2, - .max_register = 0x1e, + .max_register = QCPRDLAT, };static int ti_eqep_probe (struct platform_device *pdev)