arm64: Fix a broken copyright header in gen_vdso_offsets.sh
PATCH 1/1 arm64: Fix a broken copyright header in gen_vdso_offsets.sh
From: Palmer Dabbelt <[email protected]>
I was going to copy this but I didn't want to chase around the build system stuff so I did it a different way.
--- arch/arm64/kernel/vdso/gen_vdso_offsets.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/vdso/gen_vdso_offsets.sh +1 -1
@@ -8,7 +8,7 @@ # Doing this inside the Makefile will break the $(filter-out) function, # causing Kbuild to rebuild the vdso-offsets header file every time. # -# Author: Will Deacon <[email protected] +# Author: Will Deacon <[email protected]> # LC_ALL=C
Signature · 7 lines
2.29.0.rc1.297.gfa9743e501-goog _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Will Deacon
maintainerQuoted 4 lines · Palmer Dabbelt
From: Palmer Dabbelt <[email protected]>
I was going to copy this but I didn't want to chase around the build system stuff so I did it a different way.
How did you end up doing it? I remember trying to parse the ELF object at one time of day and not getting very far.
Will
Quoted 8 lines · On Tue, 20 Oct 2020 04:32:08 PDT (-0700), [email protected] wrote:
Quoted 4 lines · Palmer Dabbelt
From: Palmer Dabbelt <[email protected]>
I was going to copy this but I didn't want to chase around the build system stuff so I did it a different way.
How did you end up doing it? I remember trying to parse the ELF object at one time of day and not getting very far.
Mine really isn't any cleaner: I use nm and sed to produce an assembler file full of absolute symbols, which I compile to produce the object. That way I don't need a header file, which means I don't need to mess around with build ordering or change any of the other code (which was already using symbols).
I don't really like this whole thing we do where we just assume that symbols with a small offset from absolute address zero. We're sort of depending on that for undefined weak symbols, but that's only for actually zero not almost zero. Given that, I figured it'd be easier to just do it this way rather than trying to mess with build stuff.
I probably wouldn't bother changing unless there's something actively bad about that build stuff (I didn't really look).
Quoted 2 lines · Palmer Dabbelt
I was going to copy this but I didn't want to chase around the build system stuff so I did it a different way.
Applied to arm64 (for-next/core), thanks!
[1/1] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
https://git.kernel.org/arm64/c/7bdf468a5b40
Cheers,
Signature · 10 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel