Skip to contentSkip to conversation

tune-thunderx.inc: don't append _be to ARMPKGARCH for tune-thunderx_be

RFC PATCH New Martin Jansa 1 participant 3 messages Oct 17, 2020

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/3 tune-thunderx.inc: don't append _be to ARMPKGARCH for tune-thunderx_be

* the _be suffix is already included in ARMPKGARCH with:
ARMPKGARCH_tune-thunderx ?= "thunderx" ARMPKGARCH_tune-thunderx_be ?= "thunderx_be"

and then it was appended again through ARMPKGSFX_ENDIAN_64 in meta/conf/machine/include/arm/arch-arm64.inc:
TUNE_PKGARCH_64 = "${ARMPKGARCH}${ARMPKGSFX_ENDIAN_64}"

* broken since:
commit 08433cc58abf0cf3e42b22d20870a50287cfb8bc
Author: Khem Raj <[email protected]>
Date: Tue May 26 16:10:37 2020 -0700

armv8/tunes: Set TUNE_PKGARCH_64 based on ARMPKGARCH

* fixes:
scripts/tune/log.fake-thunderx.thunderx_be: Error, the PACKAGE_ARCHS variable (all any noarch aarch64_be thunderx_be fake_thunderx) for DEFAULTTUNE (thunderx_be) does not contain TUNE_PKGARCH (thunderx_be_be).

---
 meta/conf/machine/include/tune-thunderx.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/machine/include/tune-thunderx.inc +1 -1
index aa4d0501d4..d1aaf4891e 100644
@@ -8,7 +8,7 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'thunderx', ' -mcpu=thunde
 require conf/machine/include/arm/arch-armv8a.inc
 
 ARMPKGARCH_tune-thunderx ?= "thunderx"
-ARMPKGARCH_tune-thunderx_be ?= "thunderx_be"
+ARMPKGARCH_tune-thunderx_be ?= "thunderx"
 
 TUNE_FEATURES_tune-thunderx = "${TUNE_FEATURES_tune-aarch64} thunderx"
 TUNE_FEATURES_tune-thunderx_be = "${TUNE_FEATURES_tune-thunderx} bigendian"
Signature · 1 line
2.25.1
#1 lore raw

RFC PATCH 2/3 siteinfo: Recognize 32bit PPC LE

* since this commit, all powerpc little-endians (both 32bit and 64bit) use "le" suffix:
commit b6ac40f1cbabb20896bf113568f7735a462ed1a6
Author: Khem Raj <[email protected]>
Date: Sun Dec 29 10:44:03 2019 -0800

powerpc, powerpc64: Append little-endianness to tune arch

* 64bit variants were already fixed in:
commit e62cdb9b88b575b5cfcdd65ca558edc237c43b2a
Author: Khem Raj <[email protected]>
Date: Sun Dec 29 10:44:02 2019 -0800

siteinfo: Recognize 64bit PPC LE

* but 32bit are still failing:
scripts/tune/log.fake-power5.powerpcle
scripts/tune/log.fake-power5.powerpcle-nf
scripts/tune/log.fake-power6.powerpcle
scripts/tune/log.fake-power6.powerpcle-nf
scripts/tune/log.fake-power7.powerpcle
scripts/tune/log.fake-power7.powerpcle-nf
scripts/tune/log.fake-power9.powerpcle
scripts/tune/log.fake-power9.powerpcle-nf
scripts/tune/log.fake-power9.ppcp9le
scripts/tune/log.fake-ppc476.powerpcle
scripts/tune/log.fake-ppc476.powerpcle-nf
scripts/tune/log.fake-ppc603e.powerpcle
scripts/tune/log.fake-ppc603e.powerpcle-nf
scripts/tune/log.fake-ppc7400.powerpcle
scripts/tune/log.fake-ppc7400.powerpcle-nf
scripts/tune/log.fake-ppce300c2.powerpcle
scripts/tune/log.fake-ppce300c2.powerpcle-nf
scripts/tune/log.fake-ppce300c3.powerpcle
scripts/tune/log.fake-ppce300c3.powerpcle-nf
scripts/tune/log.fake-ppce500.powerpcle
scripts/tune/log.fake-ppce500.powerpcle-nf
scripts/tune/log.fake-ppce500mc.powerpcle
scripts/tune/log.fake-ppce500mc.powerpcle-nf
scripts/tune/log.fake-ppce500v2.powerpcle
scripts/tune/log.fake-ppce500v2.powerpcle-nf
scripts/tune/log.fake-ppce5500.powerpcle
scripts/tune/log.fake-ppce5500.powerpcle-nf
scripts/tune/log.fake-ppce6500.powerpcle
scripts/tune/log.fake-ppce6500.powerpcle-nf

Parsing recipes...
ERROR: /OE/build/oe-core/openembedded-core/meta/recipes-support/debianutils/debianutils_4.11.1.bb: Unable to determine endianness for architecture 'powerpcle'
ERROR: /OE/build/oe-core/openembedded-core/meta/recipes-support/debianutils/debianutils_4.11.1.bb: Please add your architecture to siteinfo.bbclass
...

---
 meta/classes/siteinfo.bbclass | 3 +++
 1 file changed, 3 insertions(+)
meta/classes/siteinfo.bbclass +3 -0
index 1a048c053f..1fe5eea717 100644
@@ -45,6 +45,7 @@ def siteinfo_data_for_machine(arch, os, d):
         "mipsisa32r6": "endian-big bit-32 mips-common",
         "mipsisa32r6el": "endian-little bit-32 mips-common",
         "powerpc": "endian-big bit-32 powerpc-common",
+        "powerpcle": "endian-little bit-32 powerpc-common",
         "nios2": "endian-little bit-32 nios2-common",
         "powerpc64": "endian-big bit-64 powerpc-common",
         "powerpc64le": "endian-little bit-64 powerpc-common",
@@ -100,6 +101,8 @@ def siteinfo_data_for_machine(arch, os, d):
         "mipsisa64r6el-linux-gnun32": "mipsisa32r6el-linux bit-32",
         "powerpc-linux": "powerpc32-linux",
         "powerpc-linux-musl": "powerpc-linux powerpc32-linux",
+        "powerpcle-linux": "powerpc32-linux",
+        "powerpcle-linux-musl": "powerpc-linux powerpc32-linux",
         "powerpc-linux-gnuspe": "powerpc-linux powerpc32-linux",
         "powerpc-linux-muslspe": "powerpc-linux powerpc32-linux",
         "powerpc64-linux-gnuspe": "powerpc-linux powerpc64-linux",
Signature · 1 line
2.25.1
#2 lore raw

RFC PATCH 3/3 siteinfo: Recognize bigendian sh3be and sh4be

In reply to Martin Jansa

* seems to be broken for many years, does someone still use sh3/sh4?

scripts/tune/log.fake-sh3.sh3eb:
Parsing recipes...
ERROR: /OE/build/oe-core/openembedded-core/meta/recipes-devtools/vala/vala_0.48.9.bb: Unable to determine endianness for architecture 'sh3eb'
ERROR: /OE/build/oe-core/openembedded-core/meta/recipes-devtools/vala/vala_0.48.9.bb: Please add your architecture to siteinfo.bbclass

scripts/tune/log.fake-sh4.sh4aeb
scripts/tune/log.fake-sh4.sh4eb:
Parsing recipes...
ERROR: /OE/build/oe-core/openembedded-core/meta/recipes-support/vim/vim-tiny_8.2.bb: Unable to determine endianness for architecture 'sh4eb'
ERROR: /OE/build/oe-core/openembedded-core/meta/recipes-support/vim/vim-tiny_8.2.bb: Please add your architecture to siteinfo.bbclass

---
 meta/classes/siteinfo.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/siteinfo.bbclass +2 -0
index 1fe5eea717..0bd1f36805 100644
@@ -55,7 +55,9 @@ def siteinfo_data_for_machine(arch, os, d):
         "riscv32": "endian-little bit-32 riscv-common",
         "riscv64": "endian-little bit-64 riscv-common",
         "sh3": "endian-little bit-32 sh-common",
+        "sh3eb": "endian-big bit-32 sh-common",
         "sh4": "endian-little bit-32 sh-common",
+        "sh4eb": "endian-big bit-32 sh-common",
         "sparc": "endian-big bit-32",
         "viac3": "endian-little bit-32 ix86-common",
         "x86_64": "endian-little", # bitinfo specified in targetinfo
Signature · 1 line
2.25.1