Skip to contentSkip to conversation

powerpc/powernv/dump: Handle multiple writes to ack attribute

PATCH Applied Vasant Hegde 2 participants 2 messages Oct 17, 2020 – Oct 20, 2020 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/powernv/dump: Handle multiple writes to ack attribute

Even though we use self removing sysfs helper, we still need to make sure we do the final kobject delete conditionally. sysfs_remove_file_self() will handle parallel calls to remove the sysfs attribute file and returns true only in the caller that removed the attribute file. The other parallel callers are returned false. Do the final kobject delete checking the return value of sysfs_remove_file_self().

Cc Aneesh Kumar K.V <[email protected]>
Cc Mahesh Salgaonkar <[email protected]>
---
 arch/powerpc/platforms/powernv/opal-dump.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
arch/powerpc/platforms/powernv/opal-dump.c +8 -3
index 0e6693bacb7e..00c5a59d82d9 100644
@@ -88,9 +88,14 @@ static ssize_t dump_ack_store(struct dump_obj *dump_obj,
 			      const char *buf,
 			      size_t count)
 {
-	dump_send_ack(dump_obj->id);
-	sysfs_remove_file_self(&dump_obj->kobj, &attr->attr);
-	kobject_put(&dump_obj->kobj);
+	/*
+	 * Try to self remove this attribute. If we are successful,
+	 * delete the kobject itself.
+	 */
+	if (sysfs_remove_file_self(&dump_obj->kobj, &attr->attr)) {
+		dump_send_ack(dump_obj->id);
+		kobject_put(&dump_obj->kobj);
+	}
 	return count;
 }
 
Signature · 1 line
2.26.2
#1 lore raw
Quoted 7 lines · Vasant Hegde

Even though we use self removing sysfs helper, we still need to make sure we do the final kobject delete conditionally. sysfs_remove_file_self() will handle parallel calls to remove the sysfs attribute file and returns true only in the caller that removed the attribute file. The other parallel callers are returned false. Do the final kobject delete checking the return value of sysfs_remove_file_self().

Applied to powerpc/fixes.

[1/1] powerpc/powernv/dump: Handle multiple writes to ack attribute

      https://git.kernel.org/powerpc/c/358ab796ce78ba271a6ff82834183ffb2cb68c4c

cheers