dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC
Subsystems (3)
PATCH 1/2 dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC
Add documentation for the auxadc binding for MT8516 SoC.
--- Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +1 -0
@@ -17,6 +17,7 @@ Required properties: - "mediatek,mt7622-auxadc": For MT7622 family of SoCs - "mediatek,mt8173-auxadc": For MT8173 family of SoCs - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs + - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs - reg: Address range of the AUXADC unit. - clocks: Should contain a clock specifier for each entry in clock-names - clock-names: Should contain "main".
Signature · 1 line
2.28.0
PATCH 2/2 arm64: dts: mediatek: mt8516: add auxadc node
Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC.
--- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/mediatek/mt8516.dtsi +10 -0
@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 { #phy-cells = <1>; }; }; + + auxadc: adc@11003000 { + compatible = "mediatek,mt8516-auxadc", + "mediatek,mt8173-auxadc"; + reg = <0 0x11003000 0 0x1000>; + clocks = <&topckgen CLK_TOP_AUX_ADC>; + clock-names = "main"; + #io-channel-cells = <1>; + status = "disabled"; + }; }; };
Signature · 1 line
2.28.0
Matthias Brugger
maintainerRe: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
Quoted 19 lines · Fabien Parent
Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC.
Signed-off-by Fabien Parent <[email protected]>--- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm64/boot/dts/mediatek/mt8516.dtsi +2
-0@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 { #phy-cells = <1>; }; }; + + auxadc: adc@11003000 {
arch/arm64/boot/dts/mediatek/mt8516.dtsi usb0_port: usb-phy@11110800 { · line 484
Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8516.dtsi +8
-0+ compatible = "mediatek,mt8516-auxadc", + "mediatek,mt8173-auxadc"; + reg = <0 0x11003000 0 0x1000>; + clocks = <&topckgen CLK_TOP_AUX_ADC>; + clock-names = "main"; + #io-channel-cells = <1>; + status = "disabled"; + }; }; };
Any reason you don't enable the status in the pumpkin dts?
Regards,
Matthias
Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
Hi Matthias,
Quoted 1 line
Any reason you don't enable the status in the pumpkin dts?
No particular reasons. I looked at what other MTK SoC did for this IP, and half went with the status to be disabled and the other half went with an enabled status. So I went the mt8183 way since it is the last MTK SoC to have been merged and disabled by default. If you think it is better to be enabled by default, I can change it, I don't have any strong opinion about this.
Matthias Brugger
maintainerRe: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
Quoted 11 lines · Fabien Parent
Hi Matthias,
Quoted 1 line
Any reason you don't enable the status in the pumpkin dts?
No particular reasons. I looked at what other MTK SoC did for this IP, and half went with the status to be disabled and the other half went with an enabled status. So I went the mt8183 way since it is the last MTK SoC to have been merged and disabled by default. If you think it is better to be enabled by default, I can change it, I don't have any strong opinion about this.
Well on mt8183 it is missing the thermal driver although as you can read the values via sysfs I'd say to enable it. No need to resend just because of that. I'll take the patch as-is as soon as Jonathan takes 1/2.
Regards,
Matthias
Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node
In reply to Fabien ParentQuoted 4 lines · Fabien Parent
Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC.
Signed-off-by Fabien Parent <[email protected]>
Applied to v5.10-tmp/dts64
Thanks!
Quoted 25 lines
--- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm64/boot/dts/mediatek/mt8516.dtsi +10
-0@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 { #phy-cells = <1>; }; }; + + auxadc: adc@11003000 { + compatible = "mediatek,mt8516-auxadc", + "mediatek,mt8173-auxadc"; + reg = <0 0x11003000 0 0x1000>; + clocks = <&topckgen CLK_TOP_AUX_ADC>; + clock-names = "main"; + #io-channel-cells = <1>; + status = "disabled"; + }; }; };
Quoted 3 lines · Fabien Parent
Add documentation for the auxadc binding for MT8516 SoC.
Signed-off-by Fabien Parent <[email protected]>
Quoted 17 lines
--- Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +1
-0@@ -17,6 +17,7 @@ Required properties: - "mediatek,mt7622-auxadc": For MT7622 family of SoCs - "mediatek,mt8173-auxadc": For MT8173 family of SoCs - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs + - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs - reg: Address range of the AUXADC unit. - clocks: Should contain a clock specifier for each entry in clock-names - clock-names: Should contain "main".
Jonathan Cameron
maintainerQuoted 6 lines · On Tue, 13 Oct 2020 08:00:25 +0200 Matthias Brugger <[email protected]>…
Quoted 3 lines · Fabien Parent
Add documentation for the auxadc binding for MT8516 SoC.
Signed-off-by Fabien Parent <[email protected]>Reviewed-by Matthias Brugger <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it (or do nothing given it's a txt file ;)
Jonathan
Quoted 18 lines
Quoted 18 lines
--- Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +1
-0@@ -17,6 +17,7 @@ Required properties: - "mediatek,mt7622-auxadc": For MT7622 family of SoCs - "mediatek,mt8173-auxadc": For MT8173 family of SoCs - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs + - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs - reg: Address range of the AUXADC unit. - clocks: Should contain a clock specifier for each entry in clock-names - clock-names: Should contain "main".
Quoted 7 lines · Fabien Parent
Add documentation for the auxadc binding for MT8516 SoC.
Signed-off-by Fabien Parent <[email protected]>--- Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + 1 file changed, 1 insertion(+)