Skip to contentSkip to conversation

dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC

PATCH Applied Fabien Parent 4 participants 9 messages Oct 12, 2020 – Oct 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: iio: adc: auxadc: add doc for MT8516 SoC

Add documentation for the auxadc binding for MT8516 SoC.

---
 Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +1 -0
index 78c06e05c8e5..1b7ff9e5615a 100644
@@ -17,6 +17,7 @@ Required properties:
     - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
     - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
     - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
+    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
   - reg: Address range of the AUXADC unit.
   - clocks: Should contain a clock specifier for each entry in clock-names
   - clock-names: Should contain "main".
Signature · 1 line
2.28.0
#1 lore raw

PATCH 2/2 arm64: dts: mediatek: mt8516: add auxadc node

Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC.

---
 arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm64/boot/dts/mediatek/mt8516.dtsi +10 -0
index 89af661e7f63..943c426e9aaf 100644
@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
 				#phy-cells = <1>;
 			};
 		};
+
+		auxadc: adc@11003000 {
+			compatible = "mediatek,mt8516-auxadc",
+				     "mediatek,mt8173-auxadc";
+			reg = <0 0x11003000 0 0x1000>;
+			clocks = <&topckgen CLK_TOP_AUX_ADC>;
+			clock-names = "main";
+			#io-channel-cells = <1>;
+			status = "disabled";
+		};
 	};
 };
Signature · 1 line
2.28.0
maintainer
#2 lore raw

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

Quoted 19 lines · Fabien Parent

Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC.

---
  arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)
arch/arm64/boot/dts/mediatek/mt8516.dtsi +2 -0
index 89af661e7f63..943c426e9aaf 100644
@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
  				#phy-cells = <1>;
  			};
  		};
+
+		auxadc: adc@11003000 {

arch/arm64/boot/dts/mediatek/mt8516.dtsi usb0_port: usb-phy@11110800 { · line 484

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8516.dtsi +8 -0
+			compatible = "mediatek,mt8516-auxadc",
+				     "mediatek,mt8173-auxadc";
+			reg = <0 0x11003000 0 0x1000>;
+			clocks = <&topckgen CLK_TOP_AUX_ADC>;
+			clock-names = "main";
+			#io-channel-cells = <1>;
+			status = "disabled";
+		};
  	};
  };

Any reason you don't enable the status in the pumpkin dts?

Regards,
Matthias

#3 lore raw

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

Hi Matthias,

Quoted 1 line

Any reason you don't enable the status in the pumpkin dts?

No particular reasons. I looked at what other MTK SoC did for this IP, and half went with the status to be disabled and the other half went with an enabled status. So I went the mt8183 way since it is the last MTK SoC to have been merged and disabled by default. If you think it is better to be enabled by default, I can change it, I don't have any strong opinion about this.

maintainer
#4 lore raw

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

Quoted 11 lines · Fabien Parent

Hi Matthias,

Quoted 1 line

Any reason you don't enable the status in the pumpkin dts?

No particular reasons. I looked at what other MTK SoC did for this IP, and half went with the status to be disabled and the other half went with an enabled status. So I went the mt8183 way since it is the last MTK SoC to have been merged and disabled by default. If you think it is better to be enabled by default, I can change it, I don't have any strong opinion about this.

Well on mt8183 it is missing the thermal driver although as you can read the values via sysfs I'd say to enable it. No need to resend just because of that. I'll take the patch as-is as soon as Jonathan takes 1/2.

Regards,
Matthias

maintainer Applied
#5 lore raw

Re: [PATCH 2/2] arm64: dts: mediatek: mt8516: add auxadc node

In reply to Fabien Parent
Quoted 4 lines · Fabien Parent

Add node for the auxadc IP. The IP is compatible with the one found in MT8173 SoC.

Applied to v5.10-tmp/dts64

Thanks!

Quoted 25 lines
---
  arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
  1 file changed, 10 insertions(+)
arch/arm64/boot/dts/mediatek/mt8516.dtsi +10 -0
index 89af661e7f63..943c426e9aaf 100644
@@ -470,5 +470,15 @@ usb0_port: usb-phy@11110800 {
  				#phy-cells = <1>;
  			};
  		};
+
+		auxadc: adc@11003000 {
+			compatible = "mediatek,mt8516-auxadc",
+				     "mediatek,mt8173-auxadc";
+			reg = <0 0x11003000 0 0x1000>;
+			clocks = <&topckgen CLK_TOP_AUX_ADC>;
+			clock-names = "main";
+			#io-channel-cells = <1>;
+			status = "disabled";
+		};
  	};
  };
maintainer Reviewed-by on v1 1/2
#6 lore raw
In reply to Fabien Parent
Quoted 3 lines · Fabien Parent

Add documentation for the auxadc binding for MT8516 SoC.

Quoted 17 lines
---
  Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +1 -0
index 78c06e05c8e5..1b7ff9e5615a 100644
@@ -17,6 +17,7 @@ Required properties:
      - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
      - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
      - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
+    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
    - reg: Address range of the AUXADC unit.
    - clocks: Should contain a clock specifier for each entry in clock-names
    - clock-names: Should contain "main".
maintainer
#7 lore raw
Quoted 6 lines · On Tue, 13 Oct 2020 08:00:25 +0200 Matthias Brugger <[email protected]>…
Quoted 3 lines · Fabien Parent

Add documentation for the auxadc binding for MT8516 SoC.

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it (or do nothing given it's a txt file ;)

Jonathan

Quoted 18 lines
Quoted 18 lines
---
  Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt +1 -0
index 78c06e05c8e5..1b7ff9e5615a 100644
@@ -17,6 +17,7 @@ Required properties:
      - "mediatek,mt7622-auxadc": For MT7622 family of SoCs
      - "mediatek,mt8173-auxadc": For MT8173 family of SoCs
      - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs
+    - "mediatek,mt8516-auxadc", "mediatek,mt8173-auxadc": For MT8516 family of SoCs
    - reg: Address range of the AUXADC unit.
    - clocks: Should contain a clock specifier for each entry in clock-names
    - clock-names: Should contain "main".