Skip to contentSkip to conversation

iio: light: vcnl4035 add i2c_device_id

PATCH Superseded Vaishnav M A 2 participants 2 messages Oct 16, 2020 – Oct 18, 2020 IIO

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: light: vcnl4035 add i2c_device_id

This patch aims to add i2c_device_id for the
vcnl4035 driver, while going through the initial driver submission patches, noticed that the i2c_device_id was removed on suggestion (https://lore.kernel.org/patchwork/patch/970970/),
will it be possible to consider this patch add the i2c_device_id, so that the device can be instantiated using i2c_new_client_device or say from the userspace?.This will be really helpful in cases where the device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus).

The particular usecase here is described over this RFC Patch for the mikroBUS driver:
https://lore.kernel.org/patchwork/patch/1290148/

Thanks and Regards,

Vaishnav M A

---
 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/light/vcnl4035.c +7 -0
index 765c44adac57..73a28e30dddc 100644
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 10 lines · On Sat, 17 Oct 2020 00:14:59 +0530 Vaishnav M A <[email protected]>…

This patch aims to add i2c_device_id for the
vcnl4035 driver, while going through the initial driver submission patches, noticed that the i2c_device_id was removed on suggestion (https://lore.kernel.org/patchwork/patch/970970/),
will it be possible to consider this patch add the i2c_device_id, so that the device can be instantiated using i2c_new_client_device or say from the userspace?.This will be really helpful in cases where the device tree based description is not possible now(Eg. a device on a gbphy i2c adapter created by greybus).

Quoted 7 lines

The particular usecase here is described over this RFC Patch for the mikroBUS driver:
https://lore.kernel.org/patchwork/patch/1290148/

Thanks and Regards,

Vaishnav M A

If you send out a v2 of a patch without there having been any replies please reply your self to say you have done so.

That avoids reviewers looking at the wrong version!

Thanks

Jonathan

Quoted 31 lines
---
 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/light/vcnl4035.c +7 -0
index 765c44adac57..73a28e30dddc 100644
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);