Skip to contentSkip to conversation

iio: proximity: vl53l0x-i2c add i2c_device_id

PATCH Superseded Vaishnav M A 2 participants 3 messages Oct 18, 2020

Subsystems (2)
IIO ST VL53L0X ToF ranger(I2C) IIO driver

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Vaishnav M A

author
#0 lore raw

PATCH v3 1/1 iio: proximity: vl53l0x-i2c add i2c_device_id

Add i2c_device_id table for the vl53l0x-i2c driver, helps in device instantiation using i2c_new_client_device or from userspace in cases where device-tree based description is not possible now (Example: device on a gbphy i2c adapter created by greybus)

Signed-off-by Vaishnav M A <[email protected]>

---
v3:
-modify commit message for readability
as suggested by Jonathan Cameron
v2:
-fix commit message

 drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/iio/proximity/vl53l0x-i2c.c +7 -0
index 5fbda9475ba9..7c29d4cae24a 100644
@@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client)
 	return devm_iio_device_register(&client->dev, indio_dev);
 }
 
+static const struct i2c_device_id vl53l0x_id[] = {
+	{ "vl53l0x", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
+
 static const struct of_device_id st_vl53l0x_dt_match[] = {
 	{ .compatible = "st,vl53l0x", },
 	{ }

@@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = {
 		.of_match_table = st_vl53l0x_dt_match,
 	},
 	.probe_new = vl53l0x_probe,
+	.id_table = vl53l0x_id,
 };
 module_i2c_driver(vl53l0x_driver);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Vaishnav M A

Add i2c_device_id table for the vl53l0x-i2c driver, helps in device instantiation using i2c_new_client_device or from userspace in cases where device-tree based description is not possible now (Example: device on a gbphy i2c adapter created by greybus)

Same comments as per v1.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#2 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Vaishnav M A

Add i2c_device_id table for the vl53l0x-i2c driver, helps in device instantiation using i2c_new_client_device or from userspace in cases where device-tree based description is not possible now (Example: device on a gbphy i2c adapter created by greybus)

Quoted 5 lines

Same comments as per v1.

--
With Best Regards,
Andy Shevchenko

Thank you Andy for your review, I have updated v4 patch with your suggestions : https://lore.kernel.org/patchwork/patch/1322218/

Thanks,
Vaishnav