iio: adc: mediatek: fix unset field
Subsystems (2)
PATCH v2 1/1 iio: adc: mediatek: fix unset field
dev_comp field is used in a couple of places but it is never set. This results in kernel oops when dereferencing a NULL pointer. Set the dev_comp field correctly in the probe function.
---
Changelog:
V2:
* s/of_device_get_match_data/device_get_match_data
* include mod_devicetable.h and property.h instead of of_*.h headers
drivers/iio/adc/mt6577_auxadc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/iio/adc/mt6577_auxadc.c +4 -2
@@ -9,9 +9,9 @@#include <linux/err.h> #include <linux/kernel.h> #include <linux/module.h> -#include <linux/of.h> -#include <linux/of_device.h> +#include <linux/mod_devicetable.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/iopoll.h> #include <linux/io.h> #include <linux/iio/iio.h>
@@ -276,6 +276,8 @@ static int mt6577_auxadc_probe(struct platform_device *pdev) goto err_disable_clk; } + adc_dev->dev_comp =device_get_match_data (&pdev->dev); +mutex_init (&adc_dev->lock); mt6577_auxadc_mod_reg(adc_dev->reg_base + MT6577_AUXADC_MISC,
Signature · 1 line
2.28.0
Quoted 8 lines · Fabien Parent
dev_compfield is used in a couple of places but it is never set. This results in kernel oops when dereferencing a NULL pointer. Set thedev_compfield correctly in the probe function.Fixes 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")Signed-off-by Fabien Parent <[email protected]>
Shouldn't be a blank line in the tag block.
I think Jonathan can fix it, but be more careful in the future.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Fabien Parent
dev_compfield is used in a couple of places but it is never set. This results in kernel oops when dereferencing a NULL pointer. Set thedev_compfield correctly in the probe function.
Quoted 7 lines
Quoted 3 lines
Fixes 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")Signed-off-by Fabien Parent <[email protected]>Shouldn't be a blank line in the tag block.
I think Jonathan can fix it, but be more careful in the future.
One more serious issue, you forgot to add tags you have gotten in the previous round.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy
Quoted 12 lines · Andy Shevchenko
Quoted 9 lines · Andy Shevchenko
Quoted 7 lines · Fabien Parent
dev_compfield is used in a couple of places but it is never set. This results in kernel oops when dereferencing a NULL pointer. Set thedev_compfield correctly in the probe function.Fixes 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Fabien Parent <[email protected]>Shouldn't be a blank line in the tag block.
I think Jonathan can fix it, but be more careful in the future.
One more serious issue, you forgot to add tags you have gotten in the previous round.
Thanks for the review. I will make it easy for the maintainer and send right away a v3 that fixes both issues you pointed out.
Quoted 3 lines
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek